Re: [OE-core] [PATCH] util-linux.inc: Set the correct license for util-linux-libuuid again

["Peter Kjellerstedt" <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> Sent: den 24 mars 2021 23:40
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] util-linux.inc: Set the correct license for
> util-linux-libuuid again
> 
> On Wed, 2021-03-24 at 22:38 +0000, Peter Kjellerstedt wrote:
> > > -----Original Message-----
> > > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > Sent: den 24 mars 2021 22:35
> > > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded-
> > > core@lists.openembedded.org
> > > Subject: Re: [OE-core] [PATCH] util-linux.inc: Set the correct license
> for
> > > util-linux-libuuid again
> > >
> > > On Wed, 2021-03-24 at 20:15 +0100, Peter Kjellerstedt wrote:
> > > > LICENSE_${PN}-libuuid was not updated when libuuid was moved to the
> > > > util-linux-uuid recipe. Use LICENSE_${BPN}-libuuid instead as BPN is
> > > > set to "util-linux" for both util-linux and util-linux-uuid.
> > > >
> > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > > ---
> > > >  meta/recipes-core/util-linux/util-linux.inc | 10 +++++-----
> > > >  1 file changed, 5 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> b/meta/recipes-
> > > core/util-linux/util-linux.inc
> > > > index 4031c586c9..bb93eb67d6 100644
> > > > --- a/meta/recipes-core/util-linux/util-linux.inc
> > > > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > > > @@ -7,11 +7,11 @@ disk partitioning, kernel message management,
> > > filesystem creation, and system lo
> > > >  SECTION = "base"
> > > >   LICENSE = "GPLv2+ & LGPLv2.1+ & BSD-3-Clause & BSD-4-Clause"
> > > > -LICENSE_${PN}-libblkid = "LGPLv2.1+"
> > > > -LICENSE_${PN}-libfdisk = "LGPLv2.1+"
> > > > -LICENSE_${PN}-libmount = "LGPLv2.1+"
> > > > -LICENSE_${PN}-libsmartcols = "LGPLv2.1+"
> > > > -LICENSE_${PN}-libuuid = "BSD-3-Clause"
> > > > +LICENSE_${BPN}-libblkid = "LGPLv2.1+"
> > > > +LICENSE_${BPN}-libfdisk = "LGPLv2.1+"
> > > > +LICENSE_${BPN}-libmount = "LGPLv2.1+"
> > > > +LICENSE_${BPN}-libsmartcols = "LGPLv2.1+"
> > > > +LICENSE_${BPN}-libuuid = "BSD-3-Clause"
> > >
> > > How was this tested? This will not work for multilibs or nativesdk.
> >
> > Well, we don't use either, so obviously I only tested building for
> > target. However, I believe it should work. At least `bitbake -e
> > nativesdk-util-linux-uuid` shows the expected value for
> > LICENSE_nativesdk-util-linux-libuuid.
> >
> > Note that BPN is explicitly set in the util-linux.inc file to
> > "util-linux", so the definitions above should be no different than
> > if I had used LICENSE_util-linux-libuuid = "BSD-3-Clause"
> > Or am I missing something?
> 
> It may fix libuuid but I think it will break libblkid and the others.

AFAICT, it looks correct when I try `bitbake -e util-linux` and
`bitbake -e nativesdk-util-linux`.

> Cheers,
> 
> Richard

//Peter