From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C9BC433F5 for ; Wed, 29 Sep 2021 08:14:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77C8961361 for ; Wed, 29 Sep 2021 08:14:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244683AbhI2IQZ convert rfc822-to-8bit (ORCPT ); Wed, 29 Sep 2021 04:16:25 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:56953 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244708AbhI2IQN (ORCPT ); Wed, 29 Sep 2021 04:16:13 -0400 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 18T8EDS40025405, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36503.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 18T8EDS40025405 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 29 Sep 2021 16:14:13 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36503.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 29 Sep 2021 16:14:13 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 29 Sep 2021 16:14:12 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098]) by RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098%5]) with mapi id 15.01.2106.013; Wed, 29 Sep 2021 16:14:12 +0800 From: Hayes Wang To: Jason-ch Chen , "matthias.bgg@gmail.com" CC: "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "Project_Global_Chrome_Upstream_Group@mediatek.com" , "hsinyi@google.com" , nic_swsd Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Topic: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Index: AQHXtPF6mRt31KuIqUSf0ySwz113xKu6nqYQ Date: Wed, 29 Sep 2021 08:14:12 +0000 Message-ID: References: <20210929051812.3107-1-jason-ch.chen@mediatek.com> In-Reply-To: <20210929051812.3107-1-jason-ch.chen@mediatek.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.203] x-kse-serverinfo: RTEXMBS04.realtek.com.tw, 9 x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering rules found x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2021/9/29_=3F=3F_07:00:00?= x-kse-bulkmessagesfiltering-scan-result: protection disabled Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-ServerInfo: RTEXH36503.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason-ch Chen > Sent: Wednesday, September 29, 2021 1:18 PM [...] > When unplugging RTL8152 Fast Ethernet Adapter which is plugged > into an USB HUB, the driver would get -EPROTO for bulk transfer. > There is a high probability to get the soft/hard lockup > information if the driver continues to submit Rx before the HUB > completes the detection of all hub ports and issue the > disconnect event. I don't think it is a good idea. For the other situations which return the same error code, you would stop the rx, too. However, the rx may re-work after being resubmitted for the other cases. Best Regards, Hayes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D41FC433F5 for ; Wed, 29 Sep 2021 08:15:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2194161407 for ; Wed, 29 Sep 2021 08:15:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2194161407 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ksFXkYiJZNoUog1jB8l/uef3PvuaOdWhzmprnC0DEg4=; b=UXZ2+O5KeRZ00g QVv6EsQ/Mx8/XeNCpxt1i5n292eKLYSVjOMZtwGs1QtzTuhELm7FlkDUz2k//evaQlyI1rDOqznk7 wWJcYBHCFnECj3M8OcsXre9z1JHOpEio8lUtxc5tlWdHfCCKwuA0G+d3VX/rshvRSMKdWohr/SVaJ UjjQ90qx/LgJWWj8E7bar6GjtsS9EPaoApPvDGpkUjcf+QggM8KsUi6CJWajPwFzV6RvT8/qUZgBT E8SByWmFjwbFLYowha1MjKvH5GTEq7EpF/x8fRvNurHaf1JexdPQJ5hlA/bd93QLKbj9nLfODtM6s kLLdcp4EYOanPm+EsVMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVUkL-00ALYP-4N; Wed, 29 Sep 2021 08:15:21 +0000 Received: from rtits2.realtek.com ([211.75.126.72] helo=rtits2.realtek.com.tw) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVUjR-00ALC3-LL; Wed, 29 Sep 2021 08:14:27 +0000 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 18T8EDS40025405, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36503.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 18T8EDS40025405 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 29 Sep 2021 16:14:13 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36503.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 29 Sep 2021 16:14:13 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 29 Sep 2021 16:14:12 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098]) by RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098%5]) with mapi id 15.01.2106.013; Wed, 29 Sep 2021 16:14:12 +0800 From: Hayes Wang To: Jason-ch Chen , "matthias.bgg@gmail.com" CC: "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "Project_Global_Chrome_Upstream_Group@mediatek.com" , "hsinyi@google.com" , nic_swsd Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Topic: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Index: AQHXtPF6mRt31KuIqUSf0ySwz113xKu6nqYQ Date: Wed, 29 Sep 2021 08:14:12 +0000 Message-ID: References: <20210929051812.3107-1-jason-ch.chen@mediatek.com> In-Reply-To: <20210929051812.3107-1-jason-ch.chen@mediatek.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.203] x-kse-serverinfo: RTEXMBS04.realtek.com.tw, 9 x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering rules found x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2021/9/29_=3F=3F_07:00:00?= x-kse-bulkmessagesfiltering-scan-result: protection disabled MIME-Version: 1.0 X-KSE-ServerInfo: RTEXH36503.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_011425_874331_567F04F8 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Jason-ch Chen > Sent: Wednesday, September 29, 2021 1:18 PM [...] > When unplugging RTL8152 Fast Ethernet Adapter which is plugged > into an USB HUB, the driver would get -EPROTO for bulk transfer. > There is a high probability to get the soft/hard lockup > information if the driver continues to submit Rx before the HUB > completes the detection of all hub ports and issue the > disconnect event. I don't think it is a good idea. For the other situations which return the same error code, you would stop the rx, too. However, the rx may re-work after being resubmitted for the other cases. Best Regards, Hayes _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F7CC433EF for ; Wed, 29 Sep 2021 08:17:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40F15613D0 for ; Wed, 29 Sep 2021 08:17:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 40F15613D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yxwt0iwckrY3Lnz5rqlONY3inKhtvCHjLU8PyKQCgv0=; b=WvtMtCzkKdvv2i nPTsy2sygecVuCLkkT0US6j1kSNB6k13t/MnYD0Z5w3MHAW3Wj73ZHvgZKTN93PXQsZ4VHvTRoi/n QITI6fmVyqr4zIqnQbWNN3cpemagm9mpiRsUrThWlS/89WdCF489bo1meDAAe0c2eEg3houKb2Glo gMygnuXY2emUTq6tURhCsosOPg0vljyphPNNTxn+KZBeNUiuby6/lDnvi4bEMMHHh+ULg3JWymJy6 aJ/a2DwiW7kEAGJUJapVvCtaAVzcLXI6jbMdaa2sPjJ2SObm5N/PLW3zJufHEmEYh51y25AdTqQWO itBxGIpmTq2o8k2MQEgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVUk7-00ALRq-Dy; Wed, 29 Sep 2021 08:15:07 +0000 Received: from rtits2.realtek.com ([211.75.126.72] helo=rtits2.realtek.com.tw) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVUjR-00ALC3-LL; Wed, 29 Sep 2021 08:14:27 +0000 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 18T8EDS40025405, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36503.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 18T8EDS40025405 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 29 Sep 2021 16:14:13 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36503.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 29 Sep 2021 16:14:13 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 29 Sep 2021 16:14:12 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098]) by RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098%5]) with mapi id 15.01.2106.013; Wed, 29 Sep 2021 16:14:12 +0800 From: Hayes Wang To: Jason-ch Chen , "matthias.bgg@gmail.com" CC: "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "Project_Global_Chrome_Upstream_Group@mediatek.com" , "hsinyi@google.com" , nic_swsd Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Topic: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Index: AQHXtPF6mRt31KuIqUSf0ySwz113xKu6nqYQ Date: Wed, 29 Sep 2021 08:14:12 +0000 Message-ID: References: <20210929051812.3107-1-jason-ch.chen@mediatek.com> In-Reply-To: <20210929051812.3107-1-jason-ch.chen@mediatek.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.203] x-kse-serverinfo: RTEXMBS04.realtek.com.tw, 9 x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering rules found x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2021/9/29_=3F=3F_07:00:00?= x-kse-bulkmessagesfiltering-scan-result: protection disabled MIME-Version: 1.0 X-KSE-ServerInfo: RTEXH36503.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_011425_874331_567F04F8 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Jason-ch Chen > Sent: Wednesday, September 29, 2021 1:18 PM [...] > When unplugging RTL8152 Fast Ethernet Adapter which is plugged > into an USB HUB, the driver would get -EPROTO for bulk transfer. > There is a high probability to get the soft/hard lockup > information if the driver continues to submit Rx before the HUB > completes the detection of all hub ports and issue the > disconnect event. I don't think it is a good idea. For the other situations which return the same error code, you would stop the rx, too. However, the rx may re-work after being resubmitted for the other cases. Best Regards, Hayes _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel