From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmi6I-0003Bh-9D for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:02:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmi6E-0006GT-Bl for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:02:14 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41276 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmi6E-0006GE-6x for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:02:10 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8LDwdth121901 for ; Wed, 21 Sep 2016 10:02:09 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0b-001b2d01.pphosted.com with ESMTP id 25knvrg4uy-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 21 Sep 2016 10:02:09 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Sep 2016 15:02:07 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4F0CB1B08023 for ; Wed, 21 Sep 2016 15:03:35 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8LE1hrI13435210 for ; Wed, 21 Sep 2016 14:01:43 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8LE1gum008076 for ; Wed, 21 Sep 2016 08:01:42 -0600 References: <1474463939-12223-1-git-send-email-pbonzini@redhat.com> From: Christian Borntraeger Date: Wed, 21 Sep 2016 16:01:41 +0200 MIME-Version: 1.0 In-Reply-To: <1474463939-12223-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, mst@redhat.com, famz@redhat.com On 09/21/2016 03:18 PM, Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove virtio_add_queue_aio > > 3) to simplify the dataplane start/stop code > > It achieves the first two objectives, and while it doesn't quite > achieve the third it does cleanup the generic ioeventfd code in > virtio-bus more than I expected. In particular, it reduces the set > of callbacks that transports must implement, and it removes the ugly > case where ioeventfd is started with generic callbacks and then moved > to the dataplane callbacks. It also enables some simplification of the > functions that deal with host notifiers. > > I've tested it with virtio-blk, virtio-scsi and vhost-net. > > Patches 1 and 2 are simplifications that are too nice to leave > them for later in the series. > > Patch 3 moves some of the ioeventfd code from virtio-bus.c to > virtio.c. At this point the transition is a bit half-assed, but > this changes as soon as we remove the generic->dataplane > handler transition. > > Patches 4 to 6 do exactly that, and then the spring cleaning > begins, lasting for the whole second half of the series. > > Opinions, reviews and bug reports? is there a branch?