All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	Avri Altman <avri.altman@wdc.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-scsi@vger.kernel.org,
	Mike Christie <michael.christie@oracle.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH 1/2] scsi: core: Extend struct scsi_exec_args
Date: Tue, 7 Feb 2023 08:30:50 +0000	[thread overview]
Message-ID: <cbdfa5e2-1b5b-2515-22d7-b285a0179855@oracle.com> (raw)
In-Reply-To: <bc1183a8-e4fa-20c6-0508-ec36d395a20d@acm.org>

On 06/02/2023 21:14, Bart Van Assche wrote:
>> On 02/02/2023 22:04, Bart Van Assche wrote:
>>> Allow SCSI LLDs to specify RQF_* and SCMD_* flags.
>>
>> As I see, if BLK_MQ_REQ_PM is set for scsi_exec_args.req_flags, then 
>> RQF_PM gets set automatically in blk_mq_rq_ctx_init() for 
>> request.rq_flags. Christoph previously mentioned that we are required 
>> to set both (BLK_MQ_REQ_PM and RQF_PM). So where does it matter that 
>> we need to set RQF_PM (that setting BLK_MQ_REQ_PM doesn't cover)?
> 
> I will rework this patch such that both flags are set instead of only 
> one of the two.

You are setting both flags (BLK_MQ_REQ_PM and RQF_PM) in this series, 
which is what I was curious about. However that is not a change in 
behavior for ufshcd_execute_start_stop().

Thanks,
John

  reply	other threads:[~2023-02-07  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 22:04 [PATCH 0/2] Simplify ufshcd_execute_start_stop() Bart Van Assche
2023-02-02 22:04 ` [PATCH 1/2] scsi: core: Extend struct scsi_exec_args Bart Van Assche
2023-02-03 15:08   ` Mike Christie
2023-02-06  9:50   ` John Garry
2023-02-06 21:14     ` Bart Van Assche
2023-02-07  8:30       ` John Garry [this message]
2023-02-02 22:04 ` [PATCH 2/2] scsi: ufs: Simplify ufshcd_execute_start_stop() Bart Van Assche
2023-02-03 15:09   ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbdfa5e2-1b5b-2515-22d7-b285a0179855@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=adrian.hunter@intel.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=jaegeuk@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.