From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEG6m-0001eN-3g for qemu-devel@nongnu.org; Thu, 03 May 2018 11:25:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEG6h-0006PE-4J for qemu-devel@nongnu.org; Thu, 03 May 2018 11:25:24 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37082 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEG6g-0006NV-VO for qemu-devel@nongnu.org; Thu, 03 May 2018 11:25:19 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w43FKvbL117655 for ; Thu, 3 May 2018 11:25:16 -0400 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hr3s7v3j1-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 03 May 2018 11:25:15 -0400 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 May 2018 09:25:15 -0600 References: <20180502125221.4877-1-cohuck@redhat.com> From: Farhan Ali Date: Thu, 3 May 2018 11:25:08 -0400 MIME-Version: 1.0 In-Reply-To: <20180502125221.4877-1-cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH] s390-ccw: force diag 308 subcode to unsigned long List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Christian Borntraeger , Thomas Huth Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org On 05/02/2018 08:52 AM, Cornelia Huck wrote: > We currently pass an integer as the subcode parameter. However, > the upper bits of the register containing the subcode need to > be 0, which is not guaranteed unless we explicitly specify the > subcode to be an unsigned long value. > > Fixes: d046c51dad3 ("pc-bios/s390-ccw: Get device address via diag 308/6") > Cc:qemu-stable@nongnu.org > Signed-off-by: Cornelia Huck Sorry for my ignorance, but is there a C standard that says upper bits of an int is not guaranteed to be 0? Thanks Farhan