From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Thu, 29 Jun 2017 19:24:39 +0900 Subject: [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function In-Reply-To: References: <1497278179-6439-1-git-send-email-j-keerthy@ti.com> <650f82d1-528f-895a-43f9-341ac5058a5e@samsung.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Keerthy, On 06/29/2017 06:59 PM, Keerthy wrote: > > > On Thursday 29 June 2017 03:09 PM, Jaehoon Chung wrote: >> Hi, >> >> On 06/12/2017 11:36 PM, Keerthy wrote: >>> The function wrongly returned an integer while it is supposed to >>> return boolean. Fix that. >>> >>> Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support") >>> Reported-by:Nishanth Menon >>> Signed-off-by: Keerthy >> >> Applied on u-boot-mmc for PMIC. Thanks! > > Jaehoon, > > Oops! This is not needed as per latest discussion here: > https://www.mail-archive.com/u-boot at lists.denx.de/msg253113.html I read it now..i will push patches to u-boot-mmc without your patch v2. :) I'm doing the build testing now. Thanks! Best Regards, Jaehoon Chung > > Regards, > Keerthy > >> >> Best Regards, >> Jaehoon Chung >> >>> --- >>> drivers/power/regulator/lp87565_regulator.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c >>> index 2a0b8ca..e5de578 100644 >>> --- a/drivers/power/regulator/lp87565_regulator.c >>> +++ b/drivers/power/regulator/lp87565_regulator.c >>> @@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev) >>> >>> ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable); >>> if (ret) >>> - return ret; >>> + return false; >>> >>> return enable; >>> } >>> >> > > >