From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Flax Subject: Re: [PATCH 2/3] ASoC: cs4265: Add native 32bit I2S transport Date: Wed, 29 Aug 2018 09:31:31 +1000 Message-ID: References: <20180826225844.13754-1-flatmax@flatmax.org> <20180826225844.13754-2-flatmax@flatmax.org> <20180827082843.GU32322@imbe.wolfsonmicro.main> <20180828185652.GJ2414@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mx.flatmax.org (mx.flatmax.org [13.55.16.222]) by alsa0.perex.cz (Postfix) with ESMTP id D1C1326779D for ; Wed, 29 Aug 2018 01:31:36 +0200 (CEST) In-Reply-To: <20180828185652.GJ2414@sirena.org.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown , Charles Keepax Cc: alsa-devel@alsa-project.org, Brian Austin , Paul Handrigan List-Id: alsa-devel@alsa-project.org On 29/08/18 04:56, Mark Brown wrote: > On Mon, Aug 27, 2018 at 09:28:43AM +0100, Charles Keepax wrote: > >> Are you sure this is correct? The datasheet for the part only >> says it supports up to 24-bit audio and I thought the defines >> SNDRV_PCM_FMTBIT_S24_LE and U24 are expected to have 32-bits >> in the slot whilst on the bus. > No, they're not. They're expected to be 32 bit in memory and 24 bit on > the bus. > If this is the case, then I would assume that 32bit formats are forced through ALSA plughw. If operation is forced through plughw, then this patch is necessary to allow native 32 operation on the bus. The codec drops the 8 LSBs during operation as it reads/writes the 24 MSBs. Matt