From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v3 1/3] clk: tegra: Mark HCLK, SCLK and EMC as critical Date: Mon, 15 Jan 2018 13:56:18 +0300 Message-ID: References: <699ce67980d71fd315085ea9785ee6213e0772cb.1515589507.git.digetx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <699ce67980d71fd315085ea9785ee6213e0772cb.1515589507.git.digetx@gmail.com> Content-Language: en-US Sender: linux-clk-owner@vger.kernel.org To: Peter De Schrijver , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Thierry Reding , Jonathan Hunter Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 10.01.2018 16:59, Dmitry Osipenko wrote: > Machine dies if HCLK, SCLK or EMC is disabled. Hence mark these clocks > as critical. > > Signed-off-by: Dmitry Osipenko > Acked-by: Peter De Schrijver > --- > > Change log: > v2: Fixed accidentally missed marking EMC as critical on Tegra30 and > Tegra124. Switched to a use of common EMC gate definition on Tegra20 > and Tegra30. > > v3: Dropped marking PLL_P outputs as critical, because seems they are > not so critical. Although, I still haven't got a definitive answer > about what exact HW functions are affected by the fixed-clocks. > Anyway it should be cleaner to correct the actual drivers. Stephen / Michael, would it be possible to schedule these patches for 4.16? My T20 and T30 devices aren't working without the 'critical clocks' patch. Things happen to work with the opensource u-boot, but not with the proprietary bootloader. It's probably not a big deal that out-of-tree devices are broken, although would be nice to have one problem less.