From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C053C433F5 for ; Thu, 3 Mar 2022 08:30:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD75E83B5B; Thu, 3 Mar 2022 09:30:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oYOhYTZN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2311E83A70; Thu, 3 Mar 2022 09:30:06 +0100 (CET) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DFFB783BEF for ; Thu, 3 Mar 2022 09:30:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pg1-x52d.google.com with SMTP id bc27so3909649pgb.4 for ; Thu, 03 Mar 2022 00:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6unSL7R4G6VonPKhViyVuuhBwP0Nf52lFVxJSPpmAa8=; b=oYOhYTZN3bVqZNQI/uoeEQCBu0AapxhRbcF9qYqV91W6T96x2Gz3sDLbB7OK6b6XEy I6HPlHqkQg+Wscqqu6ebuXEL8Fx0b/xeWDQyX3uH1qD5e0fMw7A9so7TPRjmoYRrtyUX tN1B3inW2Uopwit4UO2IoTr4O80VwUF/MF7KChjGYdaoaQ2YWbizFGpl9tCAozF/+NED gpD+GWSQRpKqztkfjjPT2xjX1/rsckGUsgID18QkctjbYhNuf2GGB3+DuIL+UrPlv6ra jL/g1l16Hovhpf9kUG6CEh5kdYRRbz+c3FmIN5xwooqBJ4UHxXa6ijvYIDKQrAJZR0Fh Bw1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6unSL7R4G6VonPKhViyVuuhBwP0Nf52lFVxJSPpmAa8=; b=RLq53VqgGXEzhbJ0rt79AMXD0tVYHpUiX3+1f4BB+aUJuwOQwN56JttZ3FZCvGjxUK e5L08tB8aEzLuJ0qLuDs/d0wKodTtsZl11aNoYoklAzMdeHN3LREzLTFdUqeIJYIMiBX msWPOKuNgBvPBy1PcAgecQhg/wbznWbIo8iu+3L2qPOq2S2NS5OXu90hJPzLJgth+tvD fEdlfI/2h3ZIgHgPFE3iKDRGvIll7zGEan/H1Ya7sl5fFsvmUMnLS6vOC4vA/BrYKhyu GkfY7mOKiq3033x7X6UhOmyCNJkzFuvwA3QZNpFUoIfzKIyKhZbiNnfUBd7KICvvHuZa ol9A== X-Gm-Message-State: AOAM533BtxuxIActt7ZtU8nCE+nklBV8gAZph9cGLrh5cpqzwZ4o/FdR LMQBJ/OwOHYUZxlFwxVhG4U= X-Google-Smtp-Source: ABdhPJzy5sQBYnQmdGxSpug38l008izWSWh+C9GzQ2KISqSXmt4HKj8d4AJN4kE1pUnftgrabzIgwQ== X-Received: by 2002:a63:aa08:0:b0:373:cc0b:5b71 with SMTP id e8-20020a63aa08000000b00373cc0b5b71mr29264804pgf.599.1646296200050; Thu, 03 Mar 2022 00:30:00 -0800 (PST) Received: from [192.168.0.52] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id y74-20020a62644d000000b004f129e94f40sm1664690pfb.131.2022.03.03.00.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 00:29:58 -0800 (PST) Message-ID: Date: Thu, 3 Mar 2022 17:29:53 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568 Content-Language: en-US To: Simon Glass , Jaehoon Chung Cc: Alper Nebi Yasak , U-Boot Mailing List , Jack Mitchell , Kever Yang , Heinrich Schuchardt , Yifeng Zhao , Samuel Dionne-Riel , Aswath Govindraju , Philipp Tomsich , Ashok Reddy Soma , Stephen Carlson , Michal Simek , Faiz Abbas , Jagan Teki , Peng Fan , Peter Robinson References: <20220128224240.4226-1-alpernebiyasak@gmail.com> <20220128224240.4226-5-alpernebiyasak@gmail.com> From: Jaehoon Chung In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 2/27/22 03:36, Simon Glass wrote: > Hi Jaehoon, > > On Tue, 8 Feb 2022 at 16:42, Jaehoon Chung wrote: >> On 1/29/22 07:42, Alper Nebi Yasak wrote: >>> On RK3568, a register bit must be set to enable Enhanced Strobe. >>> However, it appears that the address of this register may differ from >>> vendor to vendor and should be read from the underlying MMC IP. Let the >>> Rockchip SDHCI driver read this address and set the relevant bit when >>> Enhanced Strobe configuration is requested. >>> >>> Additionally, a bit signifying that the connected hardware is an eMMC >>> chip must be set to enable Data Strobe for HS400 and HS400ES modes. Also >>> make the driver set this bit as appropriate. >>> >>> This is partly ported from Linux's Synopsys DWC MSHC driver which >>> happens to be the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in >>> Linux tree). >>> >>> Signed-off-by: Alper Nebi Yasak >> Reviewed-by: Jaehoon Chung >> >> As you mentioned, if someone test this on RK3568 board, it will be more better. > That does not seem to have happened, but it will likely happen when it > is applied. Agreed. I will apply this on u-boot-mmc. Best Regards, Jaehoon Chung > > Regards, > Simon