Re: [PATCH v4 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

[Tomas Melin <tomas.melin@vaisala.com>]

Hi,

On 4/23/21 7:06 PM, Andy Shevchenko wrote:
> On Tue, Apr 20, 2021 at 4:24 PM Tomas Melin <tomas.melin@vaisala.com> wrote:
>> Add initial support for Murata SCA3300 3-axis industrial
>> accelerometer with digital SPI interface. This device also
>> provides a temperature measurement.
>
> ..
>
>> +       for_each_set_bit(bit, indio_dev->active_scan_mask,
>> +                        indio_dev->masklength) {
> One line?

 >80 if one line.


>
>> +               ret = sca3300_read_reg(data, sca3300_channels[bit].address,
>> +                                      &val);
>> +               if (ret) {
>> +                       dev_err_ratelimited(&data->spi->dev,
>> +                               "failed to read register, error: %d\n", ret);
>> +                       /* handled, but bailing out due to errors */
>> +                       goto out;
>> +               }
>> +               data->scan.channels[i++] = val;
>> +       }
> ...
>
>> +       int ret;
>> +       int value = 0;
> Reversed xmas tree ordering?
ok.
>
> ...
>
>> +       /*
>> +        * Wait 1ms after SW-reset command.
>> +        * Wait 15ms for settling of signal paths.
>> +        */
>> +       usleep_range(16e3, 50e3);
> Hmm... Perhaps re-use msleep_range()
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Fdrivers%2Fmedia%2Fi2c%2Fimx274.c%23L601&amp;data=04%7C01%7Ctomas.melin%40vaisala.com%7Ce224aae96fd14d09236408d90671cfb2%7C6d7393e041f54c2e9b124c2be5da5c57%7C0%7C0%7C637547908155668061%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=5ZrTdeWqw1YC6TFu2VTCt%2FT1B3UrPex4Vj6T2nYJtjg%3D&amp;reserved=0?
Checked that, but not sure if that would make this call any clearer? 
Delay is now only in this place and well documented. If you have some 
specific formatting in mind for this, please let me know. Otherwise 
keeping as is.

Thanks,

Tomas