All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tanu Kaskinen" <tanuk@iki.fi>
To: Stefan Ghinea <stefan.ghinea@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] pulseaudio: fix for ARM thumb + frame pointers compilation error
Date: Mon, 30 Mar 2020 19:52:22 +0300	[thread overview]
Message-ID: <cc08a2a1a00316be1e8c3eb17ba6e988e5788a59.camel@iki.fi> (raw)
In-Reply-To: <160121D94406B75D.27565@lists.openembedded.org>

On Mon, 2020-03-30 at 19:29 +0300, Tanu Kaskinen wrote:
> On Thu, 2020-03-26 at 17:26 +0200, Stefan Ghinea wrote:
> > From: Catalin Enache <catalin.enache@windriver.com>
> > 
> > When compiling for Thumb or Thumb2, frame pointers _must_ be disabled
> > since the Thumb frame pointer in r7 clashes with pulseaudio's use of inline
> > asm to make syscalls (where r7 is used for the syscall NR).
> 
> Do you have a pointer to the asm code that does syscalls? I'm an
> upstream maintainer of PulseAudio, and to me it sounds a bit strange
> that there would be inline asm that does syscalls.
> 
> It would be great to fix this problem in upstream (either by applying
> this fix/workaround in the build system, or by modifying the asm code
> so that the problem goes away).

I forgot to check if others had already commented on this... So the
real problem is that src/pulsecore/remap_neon.c uses the r7 register in
a few places. Andre McCurdy said: "In terms of a fix, then changing the
code to use r12 instead of r7 is probably the best solution (assuming
it works), but would need careful testing." I'll try this.

-- 
Tanu

https://www.patreon.com/tanuk
https://liberapay.com/tanuk


      parent reply	other threads:[~2020-03-30 16:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 15:26 [PATCH] pulseaudio: fix for ARM thumb + frame pointers compilation error Stefan Ghinea
2020-03-26 17:23 ` [OE-core] " Andre McCurdy
2020-03-26 19:16 ` Adrian Bunk
2020-03-26 19:53   ` Andre McCurdy
2020-03-26 20:26     ` Adrian Bunk
2020-03-26 21:23       ` Andre McCurdy
2020-03-27 18:56         ` Adrian Bunk
2020-07-17 10:09         ` Tanu Kaskinen
2020-07-17 19:19           ` Andre McCurdy
2020-07-18  4:09             ` Tanu Kaskinen
2020-03-30 16:29 ` Tanu Kaskinen
     [not found] ` <160121D94406B75D.27565@lists.openembedded.org>
2020-03-30 16:52   ` Tanu Kaskinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc08a2a1a00316be1e8c3eb17ba6e988e5788a59.camel@iki.fi \
    --to=tanuk@iki.fi \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=stefan.ghinea@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.