From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B840EC43461 for ; Thu, 17 Sep 2020 12:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C53A21974 for ; Thu, 17 Sep 2020 12:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbgIQMlq (ORCPT ); Thu, 17 Sep 2020 08:41:46 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:13237 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726741AbgIQMl0 (ORCPT ); Thu, 17 Sep 2020 08:41:26 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E55CB31BFF30A85B6887; Thu, 17 Sep 2020 20:41:23 +0800 (CST) Received: from [10.174.179.91] (10.174.179.91) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 17 Sep 2020 20:41:19 +0800 Subject: Re: [PATCH -next] gpu: host1x: Convert to DEFINE_SHOW_ATTRIBUTE To: Thierry Reding CC: Greg Kroah-Hartman , , , References: <20200716090323.13274-1-miaoqinglang@huawei.com> <20200716133450.GJ535268@ulmo> <5684dcb3-c5a4-96c1-dd96-c44f5a94938f@huawei.com> <20200717142524.GA1218823@ulmo> From: miaoqinglang Message-ID: Date: Thu, 17 Sep 2020 20:41:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200717142524.GA1218823@ulmo> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.91] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 在 2020/7/17 22:25, Thierry Reding 写道: > On Fri, Jul 17, 2020 at 09:32:21AM +0800, miaoqinglang wrote: >> >> 在 2020/7/16 21:34, Thierry Reding 写道: >>> On Thu, Jul 16, 2020 at 05:03:23PM +0800, Qinglang Miao wrote: >>>> From: Yongqiang Liu >>>> >>>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. >>>> >>>> Signed-off-by: Yongqiang Liu >>>> --- >>>> drivers/gpu/host1x/debug.c | 28 ++++------------------------ >>>> 1 file changed, 4 insertions(+), 24 deletions(-) >>> This doesn't apply. Can you please resend, based on something like >>> linux-next? >>> >>> Thanks, >>> Thierry >> Hi, Thierry >> >>   Sorry I didn't mention it in commit log, but this patch is based on >> linux-next where commit <4d4901c6d7> has switched over direct  seq_read >> method calls to seq_read_iter, this is why there's conflict in  your apply. >> >>   Do you think I should send a new patch based on 5.8rc? > > No need to. I'm about to send out the pull request for v5.9-rc1, so I'll > just defer this to v5.10 since it doesn't look like it's anything > urgent. > > Thierry > Hi, Thierry I've sent a new patch against linux-next(20200917), and can be applied to mainline cleanly now. So I suggest you v2 patch. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2C5C433E2 for ; Thu, 17 Sep 2020 14:07:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68913206B6 for ; Thu, 17 Sep 2020 14:07:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68913206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F33C6EC29; Thu, 17 Sep 2020 14:07:32 +0000 (UTC) Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by gabe.freedesktop.org (Postfix) with ESMTPS id B72AF6EA68 for ; Thu, 17 Sep 2020 12:41:26 +0000 (UTC) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E55CB31BFF30A85B6887; Thu, 17 Sep 2020 20:41:23 +0800 (CST) Received: from [10.174.179.91] (10.174.179.91) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 17 Sep 2020 20:41:19 +0800 Subject: Re: [PATCH -next] gpu: host1x: Convert to DEFINE_SHOW_ATTRIBUTE To: Thierry Reding References: <20200716090323.13274-1-miaoqinglang@huawei.com> <20200716133450.GJ535268@ulmo> <5684dcb3-c5a4-96c1-dd96-c44f5a94938f@huawei.com> <20200717142524.GA1218823@ulmo> From: miaoqinglang Message-ID: Date: Thu, 17 Sep 2020 20:41:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200717142524.GA1218823@ulmo> X-Originating-IP: [10.174.179.91] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Thu, 17 Sep 2020 14:07:28 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" CgrlnKggMjAyMC83LzE3IDIyOjI1LCBUaGllcnJ5IFJlZGluZyDlhpnpgZM6Cj4gT24gRnJpLCBK dWwgMTcsIDIwMjAgYXQgMDk6MzI6MjFBTSArMDgwMCwgbWlhb3FpbmdsYW5nIHdyb3RlOgo+Pgo+ PiDlnKggMjAyMC83LzE2IDIxOjM0LCBUaGllcnJ5IFJlZGluZyDlhpnpgZM6Cj4+PiBPbiBUaHUs IEp1bCAxNiwgMjAyMCBhdCAwNTowMzoyM1BNICswODAwLCBRaW5nbGFuZyBNaWFvIHdyb3RlOgo+ Pj4+IEZyb206IFlvbmdxaWFuZyBMaXUgPGxpdXlvbmdxaWFuZzEzQGh1YXdlaS5jb20+Cj4+Pj4K Pj4+PiBVc2UgREVGSU5FX1NIT1dfQVRUUklCVVRFIG1hY3JvIHRvIHNpbXBsaWZ5IHRoZSBjb2Rl Lgo+Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogWW9uZ3FpYW5nIExpdSA8bGl1eW9uZ3FpYW5nMTNA aHVhd2VpLmNvbT4KPj4+PiAtLS0KPj4+PiAgICBkcml2ZXJzL2dwdS9ob3N0MXgvZGVidWcuYyB8 IDI4ICsrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+PiAgICAxIGZpbGUgY2hhbmdlZCwg NCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPj4+IFRoaXMgZG9lc24ndCBhcHBseS4g Q2FuIHlvdSBwbGVhc2UgcmVzZW5kLCBiYXNlZCBvbiBzb21ldGhpbmcgbGlrZQo+Pj4gbGludXgt bmV4dD8KPj4+Cj4+PiBUaGFua3MsCj4+PiBUaGllcnJ5Cj4+IEhpLCBUaGllcnJ5Cj4+Cj4+ICDC oCBTb3JyeSBJIGRpZG4ndCBtZW50aW9uIGl0IGluIGNvbW1pdCBsb2csIGJ1dCB0aGlzIHBhdGNo IGlzIGJhc2VkIG9uCj4+IGxpbnV4LW5leHQgd2hlcmUgY29tbWl0IDw0ZDQ5MDFjNmQ3PiBoYXMg c3dpdGNoZWQgb3ZlciBkaXJlY3TCoCBzZXFfcmVhZAo+PiBtZXRob2QgY2FsbHMgdG8gc2VxX3Jl YWRfaXRlciwgdGhpcyBpcyB3aHkgdGhlcmUncyBjb25mbGljdCBpbsKgIHlvdXIgYXBwbHkuCj4+ Cj4+ICDCoCBEbyB5b3UgdGhpbmsgSSBzaG91bGQgc2VuZCBhIG5ldyBwYXRjaCBiYXNlZCBvbiA1 LjhyYz8KPiAKPiBObyBuZWVkIHRvLiBJJ20gYWJvdXQgdG8gc2VuZCBvdXQgdGhlIHB1bGwgcmVx dWVzdCBmb3IgdjUuOS1yYzEsIHNvIEknbGwKPiBqdXN0IGRlZmVyIHRoaXMgdG8gdjUuMTAgc2lu Y2UgaXQgZG9lc24ndCBsb29rIGxpa2UgaXQncyBhbnl0aGluZwo+IHVyZ2VudC4KPiAKPiBUaGll cnJ5Cj4KSGksIFRoaWVycnkKCkkndmUgc2VudCBhIG5ldyBwYXRjaCBhZ2FpbnN0IGxpbnV4LW5l eHQoMjAyMDA5MTcpLCBhbmQgY2FuIGJlIGFwcGxpZWQgCnRvIG1haW5saW5lIGNsZWFubHkgbm93 LiBTbyBJIHN1Z2dlc3QgeW91IHYyIHBhdGNoLgoKVGhhbmtzLgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK