From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v4 10/19] xen: setup hypercall page for PVH Date: Wed, 21 Nov 2018 14:58:14 +0100 Message-ID: References: <20181102123738.16395-1-jgross@suse.com> <20181102123738.16395-11-jgross@suse.com> <20181109181249.GD4363@olila.i.net-space.pl> <0885fcf7-ce75-6457-d535-d44b2b86f7c4@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <0885fcf7-ce75-6457-d535-d44b2b86f7c4@suse.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Daniel Kiper Cc: hans@knorrie.org, grub-devel@gnu.org, xen-devel@lists.xen.org, phcoder@gmail.com List-Id: xen-devel@lists.xenproject.org T24gMjAvMTEvMjAxOCAxMDoyNywgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiBPbiAwOS8xMS8yMDE4 IDE5OjEyLCBEYW5pZWwgS2lwZXIgd3JvdGU6Cj4+IE9uIEZyaSwgTm92IDAyLCAyMDE4IGF0IDAx OjM3OjI5UE0gKzAxMDAsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6Pj4+ICsKPj4+ICsgIGFzbSB2b2xh dGlsZSAoIndybXNyIiA6IDogImMiIChtc3IpLCAiYSIgKHBmbiksICJkIiAoMCkgOiAibWVtb3J5 Iik7Cj4+PiArfQo+Pj4gKwo+Pj4gK2ludAo+Pj4gK2dydWJfeGVuX2h5cGVyY2FsbCAoZ3J1Yl91 aW50MzJfdCBjYWxsbm8sIGdydWJfdWludDMyX3QgYTAsCj4+PiArCQkgICAgZ3J1Yl91aW50MzJf dCBhMSwgZ3J1Yl91aW50MzJfdCBhMiwKPj4+ICsJCSAgICBncnViX3VpbnQzMl90IGEzLCBncnVi X3VpbnQzMl90IGE0LAo+Pj4gKwkJICAgIGdydWJfdWludDMyX3QgYTUgX19hdHRyaWJ1dGVfXyAo KHVudXNlZCkpKQo+Pj4gK3sKPj4+ICsgIGdydWJfdWludDMyX3QgX19yZXMsIF9faWduMCwgX19p Z24xLCBfX2lnbjIsIF9faWduMywgX19pZ240Owo+Pj4gKwo+Pj4gKyAgYXNtIHZvbGF0aWxlICgi Y2FsbCAqJVtjYWxsbm9dIgo+Pj4gKwkJOiAiPWEiIChfX3JlcyksICI9YiIgKF9faWduMCksICI9 YyIgKF9faWduMSksICI9ZCIgKF9faWduMiksCj4+PiArCQkgICI9UyIgKF9faWduMyksICI9RCIg KF9faWduNCkKPj4+ICsJCTogIjEiIChhMCksICIyIiAoYTEpLCAiMyIgKGEyKSwgIjQiIChhMyks ICI1IiAoYTQpLAo+Pgo+PiBJIHRoaW5rIHRoYXQgeW91IGNhbiBkcm9wIGFsbCBfX2lnbiogdmFy aWFibGVzIGlmIHlvdSBzcGVjaWZ5IHByb3Blcgo+PiByZWdpc3RlcnMgaW4gaW5wdXQgYXJndW1l bnQuIElmIHRoaXMgZG9lcyBub3Qgd29yayB5b3UgY2FuIHVzZSAiKyIKPj4gbW9kaWZpZXIgaW5z dGVhZCBvZiAiPSIgaW4gdGhlIG91dHB1dCBhcmd1bWVudC4KPiAKPiBJJ2xsIGhhdmUgYSB0cnku CgpEb2Vzbid0IHdvcmsuCgpTcGVjaWZ5aW5nIG9ubHkgdGhlIGlucHV0IHJlZ2lzdGVycyBuZWds ZWN0cyB0aGUgaHlwZXJjYWxsCmNsb2JiZXJpbmcgdGhvc2UuCgpVc2luZyB0aGUgIisiIG1vZGlm aWVyIGxldHMgZ2NjIGNvbXBsYWluLgoKSSdsbCBqdXN0IHVzZSBhIHNpbmdsZSBkdW1teSB2YXJp YWJsZS4KCgpKdWVyZ2VuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gPT2I-000200-Ph for mharc-grub-devel@gnu.org; Wed, 21 Nov 2018 08:59:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPT2H-0001z1-2H for grub-devel@gnu.org; Wed, 21 Nov 2018 08:59:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPT2E-0006tx-EE for grub-devel@gnu.org; Wed, 21 Nov 2018 08:59:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:46070 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPT2E-0005CG-56 for grub-devel@gnu.org; Wed, 21 Nov 2018 08:59:18 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8E3BAAC55; Wed, 21 Nov 2018 13:58:15 +0000 (UTC) Subject: Re: [Xen-devel] [PATCH v4 10/19] xen: setup hypercall page for PVH To: Daniel Kiper Cc: hans@knorrie.org, grub-devel@gnu.org, phcoder@gmail.com, xen-devel@lists.xen.org References: <20181102123738.16395-1-jgross@suse.com> <20181102123738.16395-11-jgross@suse.com> <20181109181249.GD4363@olila.i.net-space.pl> <0885fcf7-ce75-6457-d535-d44b2b86f7c4@suse.com> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: Date: Wed, 21 Nov 2018 14:58:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <0885fcf7-ce75-6457-d535-d44b2b86f7c4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 13:59:21 -0000 On 20/11/2018 10:27, Juergen Gross wrote: > On 09/11/2018 19:12, Daniel Kiper wrote: >> On Fri, Nov 02, 2018 at 01:37:29PM +0100, Juergen Gross wrote:>>> + >>> + asm volatile ("wrmsr" : : "c" (msr), "a" (pfn), "d" (0) : "memory"); >>> +} >>> + >>> +int >>> +grub_xen_hypercall (grub_uint32_t callno, grub_uint32_t a0, >>> + grub_uint32_t a1, grub_uint32_t a2, >>> + grub_uint32_t a3, grub_uint32_t a4, >>> + grub_uint32_t a5 __attribute__ ((unused))) >>> +{ >>> + grub_uint32_t __res, __ign0, __ign1, __ign2, __ign3, __ign4; >>> + >>> + asm volatile ("call *%[callno]" >>> + : "=a" (__res), "=b" (__ign0), "=c" (__ign1), "=d" (__ign2), >>> + "=S" (__ign3), "=D" (__ign4) >>> + : "1" (a0), "2" (a1), "3" (a2), "4" (a3), "5" (a4), >> >> I think that you can drop all __ign* variables if you specify proper >> registers in input argument. If this does not work you can use "+" >> modifier instead of "=" in the output argument. > > I'll have a try. Doesn't work. Specifying only the input registers neglects the hypercall clobbering those. Using the "+" modifier lets gcc complain. I'll just use a single dummy variable. Juergen