All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Marcos Paulo de Souza <mpdesouza@suse.com>,
	linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Cc: dsterba@suse.com, guaneryu@gmail.com, wqu@suse.com
Subject: Re: [PATCH v2] btrfs/177: Ignore resize output message
Date: Wed, 28 Jul 2021 08:15:00 +0800	[thread overview]
Message-ID: <cc2005f7-605b-2c22-3a9f-1bbb8177888f@gmx.com> (raw)
In-Reply-To: <20210727182125.29210-1-mpdesouza@suse.com>



On 2021/7/28 上午2:21, Marcos Paulo de Souza wrote:
> Commit 78aa1d95dd99 ("btrfs-progs: fi resize: make output more
> readable") added the device id of the resized fs along with a pretty
> printed size. Remove the resize output message from 117.out.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> ---
>
>   Qu, btrfs/217 is also ignoring the resize output, so I believe it would be
>   easier if we do the same here. We would see other problems if the resize fail,
>   so I think we are safe here.

But unfortunately, we have hit case where the output of the resize
commands is insane.

One recent regression is, resize will always output the resized size as 0.

Thus I believe we may still want to properly check the output value.
Although I don't think it should be in golden output.

Thanks,
Qu

>
>   tests/btrfs/177     | 5 ++---
>   tests/btrfs/177.out | 2 --
>   2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tests/btrfs/177 b/tests/btrfs/177
> index 966d29d7..f59f54a7 100755
> --- a/tests/btrfs/177
> +++ b/tests/btrfs/177
> @@ -36,8 +36,7 @@ dd if=/dev/zero of="$SCRATCH_MNT/refill" bs=4096 >> $seqres.full 2>&1
>   # Now add more space and create a swap file. We know that the first $fssize
>   # of the filesystem was used, so the swap file must be in the new part of the
>   # filesystem.
> -$BTRFS_UTIL_PROG filesystem resize $((3 * fssize)) "$SCRATCH_MNT" | \
> -							_filter_scratch
> +$BTRFS_UTIL_PROG filesystem resize $((3 * fssize)) "$SCRATCH_MNT" >>$seqres.full
>   _format_swapfile "$swapfile" $((32 * 1024 * 1024))
>   swapon "$swapfile"
>
> @@ -55,7 +54,7 @@ $BTRFS_UTIL_PROG filesystem resize 1G "$SCRATCH_MNT" 2>&1 | grep -o "Text file b
>   swapoff "$swapfile"
>
>   # It should work again after swapoff.
> -$BTRFS_UTIL_PROG filesystem resize $fssize "$SCRATCH_MNT" | _filter_scratch
> +$BTRFS_UTIL_PROG filesystem resize $fssize "$SCRATCH_MNT" >>$seqres.full
>
>   status=0
>   exit
> diff --git a/tests/btrfs/177.out b/tests/btrfs/177.out
> index 63aca0e5..0293ee36 100644
> --- a/tests/btrfs/177.out
> +++ b/tests/btrfs/177.out
> @@ -1,4 +1,2 @@
>   QA output created by 177
> -Resize 'SCRATCH_MNT' of '3221225472'
>   Text file busy
> -Resize 'SCRATCH_MNT' of '1073741824'
>

      reply	other threads:[~2021-07-28  0:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 18:21 [PATCH v2] btrfs/177: Ignore resize output message Marcos Paulo de Souza
2021-07-28  0:15 ` Qu Wenruo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc2005f7-605b-2c22-3a9f-1bbb8177888f@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mpdesouza@suse.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.