From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH] nfp: restore the unlink
	operation
Date: Fri, 18 May 2018 10:48:16 +0100
Message-ID: <cc273a83-fddf-e5a4-4abc-861037f60b7a@intel.com>
References: <20180514144658.9671-1-aconole@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>,
 Luca Boccassi <bluca@debian.org>, Eelco Chaudron <echaudro@redhat.com>,
 Yuanhan Liu <yliu@fridaylinux.org>, dev@dpdk.org
To: Aaron Conole <aconole@redhat.com>, stable@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180514144658.9671-1-aconole@redhat.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/14/2018 3:46 PM, Aaron Conole wrote:
> For the stable versions of DPDK, the NFP driver's NSP user space
> driver was modified to account for non-root usage.  When that
> happened, commit 515933ad8385 ("nfp: allow for non-root user")
> inadvertently removed the unlink() call.

This patch is for stable tree.

Which stable branches are effected? Only 18.02?


And a generic stable tree question, is there a easy way to find out which stable
versions has a fix? For this example which versions get "nfp: allow for non-root
user" fix?

> 
> Fixes: 515933ad8385 ("nfp: allow for non-root user")
> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
> Cc: Luca Boccassi <bluca@debian.org>
> Cc: Eelco Chaudron <echaudro@redhat.com>
> Cc: Yuanhan Liu <yliu@fridaylinux.org>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>  drivers/net/nfp/nfp_nfpu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
> index ae2e07220..c003640c7 100644
> --- a/drivers/net/nfp/nfp_nfpu.c
> +++ b/drivers/net/nfp/nfp_nfpu.c
> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>  	close(desc->lock);
>  
>  	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
> +	unlink(lockname);
>  	return 0;
>  }
>