From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58641C4332F for ; Sun, 19 Dec 2021 14:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235938AbhLSOhU (ORCPT ); Sun, 19 Dec 2021 09:37:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230483AbhLSOhT (ORCPT ); Sun, 19 Dec 2021 09:37:19 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C66EC061574; Sun, 19 Dec 2021 06:37:19 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id e3so27962947edu.4; Sun, 19 Dec 2021 06:37:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=u2C58Qi3vb54QmI4e1AHKNijekgERo9skjEIXUUovfk=; b=d+xFCA0DmryqNr7Q2/XOn6ZcLLwYoPgTigUHBKiFiDvLu/W3lbTZi0rBLjioW/Gzcr xXm1LSdJg/vJf6iJkMN4qKqshQjrUi+P1bxEavtjgO+AhAomRX22AB1l75xPI9ubkzhW W3jiVoPsg7LLudUB23e4iGPEuqTkG1SsT3dpVZbbgbYQOLEpxqbO8iRUjrHNmszwfjdk rh8kJ59csG3IHaaXK/1yUXPCKpcTpY0/4D9xa8r22aLg1AUg730BdhW7H2lk+8+dvDcz wQZkokR8Oc8G/CQF1bcE/rnbGxsSQUMjNsAv6K99m4p/J6IZtoqSWThM4AefOlXKGEzK WCfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=u2C58Qi3vb54QmI4e1AHKNijekgERo9skjEIXUUovfk=; b=aw7jryvoReS3rYUNtPdQj68NudO9l+H88rsP/SMiEE48rUc1SaeDQhUm/dJTtZaDTB v3pgdz99JmS4xhzd4gGi7yfjLQWNRSxLnd24W0fQ9aMgwN+Jaau0ieVAJ97wcYpGFZFC HvHgA7seAcW31Ja6PlFfA+zkCTBPYMW6BnHFU+1oBAGdfv3B4IClRKu2PheM18xJsMq3 ipPE34D1jLEwT22sFfU56Z7kVAMDkE3jpI/r5xsGnhvIIQjYeQFYvdUKZdI6n8Ze0s00 EoNBO/APM5Bnl7mmSLyjMDmxkhHTJFL4tk4uDfRzy06d88WdZUFfYOdeKTBdzdDxf0ra Jk9A== X-Gm-Message-State: AOAM5316yPgs4A0C6E75IbgyZpEkJRZxouFDpkiKtNMZzUnFCeDWX7gj cJIlGtQsoyzabG6Ly1lli/0= X-Google-Smtp-Source: ABdhPJzTD5T7sNxYkWs3Xb1a9cHuHPhEG7tWJB9oARXo+VmyQsN3aR/Loo/BAps3N7FB2XfybEnIBA== X-Received: by 2002:a05:6402:2814:: with SMTP id h20mr11746954ede.288.1639924637585; Sun, 19 Dec 2021 06:37:17 -0800 (PST) Received: from ?IPv6:2a02:ab88:368f:2080:eab:126a:947d:3008? ([2a02:ab88:368f:2080:eab:126a:947d:3008]) by smtp.gmail.com with ESMTPSA id cs12sm4512689ejc.15.2021.12.19.06.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Dec 2021 06:37:16 -0800 (PST) Message-ID: Subject: Re: [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC From: David Virag To: Marc Zyngier Cc: Sam Protsenko , Krzysztof Kozlowski , Rob Herring , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Date: Sun, 19 Dec 2021 15:36:20 +0100 In-Reply-To: References: <20211206153124.427102-1-virag.david003@gmail.com> <20211206153124.427102-8-virag.david003@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-12-07 at 19:42 +0000, Marc Zyngier wrote: > On 2021-12-06 15:31, David Virag wrote: > > Add initial Exynos7885 device tree nodes with dts for the Samsung > > Galaxy > > A8 (2018), a.k.a. "jackpotlte", with model number "SM-A530F". > > Currently this includes some clock support, UART support, and I2C > > nodes. > > > > Signed-off-by: David Virag > > [...] > > > +       psci { > > +               compatible = "arm,psci"; > > +               method = "smc"; > > +               cpu_suspend = <0xc4000001>; > > +               cpu_off = <0x84000002>; > > +               cpu_on = <0xc4000003>; > > Aren't these the standard PSCI 0.2 function numbers? Can't you > make the compatible "arm,psci-0.2" instead? This is not a proper PSCI 0.2 implementation. For example 0.2 has a get version call which is definitely not implemented properly as after setting the compatible to 0.2 I get the following: [ 0.000000] psci: PSCIv65535.65535 detected in firmware. Which is obviously not right. > > > +       }; > > + > > +       timer { > > +               compatible = "arm,armv8-timer"; > > +               /* Hypervisor Virtual Timer interrupt is not wired > > to GIC */ > > I don't understand this comment. You seem to have a bunch of > ARMv8.0 cores, for which there is no such thing as a hypervisor > virtual timer (this is an ARMv8.1 addition). My bad, will remove it! Should have read docs better. > > > +               interrupts = > IRQ_TYPE_LEVEL_LOW)>, > > +                            > IRQ_TYPE_LEVEL_LOW)>, > > +                            > IRQ_TYPE_LEVEL_LOW)>, > > +                            > IRQ_TYPE_LEVEL_LOW)>; > > +       }; > > Thanks, > >          M. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBECAC433EF for ; Sun, 19 Dec 2021 14:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xeUXBfFPCqpGyOWnKK5LqU3iTPCToQzOLC6yt8xQQP4=; b=1PvzFLvO+mkJvp wx6Wgh7vfVB0ooqT7WWqmy0srTF8kQHK/0bZJhrcNtIq1A6p5Y/upzmfgOMl878sfA0UsRSLIsTyl rrpr1TT3I0hjOikYFpboQ3ShiJAWX2ejTP5dlSE6WpsbbjcwDOyk6wAq+GwVVkcdI/lvRH0OQv61p bU7sryUtNVoUE0iZ8+RWs7eB5LPlSOswlTFMCqW+76fF4DrhjB5qcH8vPqB9/OQIls283koWoPSys 0MDES2W8OC3JC6Ha1XryEpP0P8eybZTW+va43Iddhgi5QZ1pYKMn/s+4VIYlULfBOPyZFLiy4IGx+ 7vSsVMMHgwgN+9feypQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1myxJT-00G7sp-E0; Sun, 19 Dec 2021 14:37:23 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1myxJP-00G7rF-L7 for linux-arm-kernel@lists.infradead.org; Sun, 19 Dec 2021 14:37:21 +0000 Received: by mail-ed1-x534.google.com with SMTP id j6so7364596edw.12 for ; Sun, 19 Dec 2021 06:37:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=u2C58Qi3vb54QmI4e1AHKNijekgERo9skjEIXUUovfk=; b=d+xFCA0DmryqNr7Q2/XOn6ZcLLwYoPgTigUHBKiFiDvLu/W3lbTZi0rBLjioW/Gzcr xXm1LSdJg/vJf6iJkMN4qKqshQjrUi+P1bxEavtjgO+AhAomRX22AB1l75xPI9ubkzhW W3jiVoPsg7LLudUB23e4iGPEuqTkG1SsT3dpVZbbgbYQOLEpxqbO8iRUjrHNmszwfjdk rh8kJ59csG3IHaaXK/1yUXPCKpcTpY0/4D9xa8r22aLg1AUg730BdhW7H2lk+8+dvDcz wQZkokR8Oc8G/CQF1bcE/rnbGxsSQUMjNsAv6K99m4p/J6IZtoqSWThM4AefOlXKGEzK WCfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=u2C58Qi3vb54QmI4e1AHKNijekgERo9skjEIXUUovfk=; b=vI7nZZYJtOpRz6Gly4aHXY3Mq57uBKm4Bxfdsbp/iEaKrOoBD+my6BSsDBYFX2P00p G3BOhXQHN+LRVi079/uBZCX9NFfIs+DunJ2PO7CfoHZxQAYSEScN4dS29TuOwVePCAYi an5O+jcGueUq+w15/LQGWdSbjeo9PyyjQVrZZeG0OX8A3ASA53hISbW2X0XlhIJ0tPaq lOMo0pNYJnUWz0b2zRvUk+HzDEZv1bEmazOgap95ahvFP7C1O2K7m5337maqs9J9OP2s oZEYsv98cUpRrWuPI5zn4jJyIoQ9g/9pciFUnV8JYEH/5cv4hdkrLA2ZyHMrB8bkoEcP MpnQ== X-Gm-Message-State: AOAM530Fs3qMFb0l6DOneqhwhjRK6flLPro9XgKlly6UhFbWPdDWDf6j l6aYJnKvVZeB3MmNikGunDA= X-Google-Smtp-Source: ABdhPJzTD5T7sNxYkWs3Xb1a9cHuHPhEG7tWJB9oARXo+VmyQsN3aR/Loo/BAps3N7FB2XfybEnIBA== X-Received: by 2002:a05:6402:2814:: with SMTP id h20mr11746954ede.288.1639924637585; Sun, 19 Dec 2021 06:37:17 -0800 (PST) Received: from ?IPv6:2a02:ab88:368f:2080:eab:126a:947d:3008? ([2a02:ab88:368f:2080:eab:126a:947d:3008]) by smtp.gmail.com with ESMTPSA id cs12sm4512689ejc.15.2021.12.19.06.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Dec 2021 06:37:16 -0800 (PST) Message-ID: Subject: Re: [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC From: David Virag To: Marc Zyngier Cc: Sam Protsenko , Krzysztof Kozlowski , Rob Herring , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Date: Sun, 19 Dec 2021 15:36:20 +0100 In-Reply-To: References: <20211206153124.427102-1-virag.david003@gmail.com> <20211206153124.427102-8-virag.david003@gmail.com> User-Agent: Evolution 3.42.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211219_063719_735702_B4EF0523 X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyMDIxLTEyLTA3IGF0IDE5OjQyICswMDAwLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4g T24gMjAyMS0xMi0wNiAxNTozMSwgRGF2aWQgVmlyYWcgd3JvdGU6Cj4gPiBBZGQgaW5pdGlhbCBF eHlub3M3ODg1IGRldmljZSB0cmVlIG5vZGVzIHdpdGggZHRzIGZvciB0aGUgU2Ftc3VuZyAKPiA+ IEdhbGF4eQo+ID4gQTggKDIwMTgpLCBhLmsuYS4gImphY2twb3RsdGUiLCB3aXRoIG1vZGVsIG51 bWJlciAiU00tQTUzMEYiLgo+ID4gQ3VycmVudGx5IHRoaXMgaW5jbHVkZXMgc29tZSBjbG9jayBz dXBwb3J0LCBVQVJUIHN1cHBvcnQsIGFuZCBJMkMgCj4gPiBub2Rlcy4KPiA+IAo+ID4gU2lnbmVk LW9mZi1ieTogRGF2aWQgVmlyYWcgPHZpcmFnLmRhdmlkMDAzQGdtYWlsLmNvbT4KPiAKPiBbLi4u XQo+IAo+ID4gK8KgwqDCoMKgwqDCoMKgcHNjaSB7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgY29tcGF0aWJsZSA9ICJhcm0scHNjaSI7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgbWV0aG9kID0gInNtYyI7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgY3B1X3N1c3BlbmQgPSA8MHhjNDAwMDAwMT47Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgY3B1X29mZiA9IDwweDg0MDAwMDAyPjsKPiA+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqBjcHVfb24gPSA8MHhjNDAwMDAwMz47Cj4gCj4gQXJlbid0IHRoZXNlIHRo ZSBzdGFuZGFyZCBQU0NJIDAuMiBmdW5jdGlvbiBudW1iZXJzPyBDYW4ndCB5b3UKPiBtYWtlIHRo ZSBjb21wYXRpYmxlICJhcm0scHNjaS0wLjIiIGluc3RlYWQ/CgpUaGlzIGlzIG5vdCBhIHByb3Bl ciBQU0NJIDAuMiBpbXBsZW1lbnRhdGlvbi4gRm9yIGV4YW1wbGUgMC4yIGhhcyBhIGdldAp2ZXJz aW9uIGNhbGwgd2hpY2ggaXMgZGVmaW5pdGVseSBub3QgaW1wbGVtZW50ZWQgcHJvcGVybHkgYXMg YWZ0ZXIKc2V0dGluZyB0aGUgY29tcGF0aWJsZSB0byAwLjIgSSBnZXQgdGhlIGZvbGxvd2luZzoK ClsgICAgMC4wMDAwMDBdIHBzY2k6IFBTQ0l2NjU1MzUuNjU1MzUgZGV0ZWN0ZWQgaW4gZmlybXdh cmUuCgpXaGljaCBpcyBvYnZpb3VzbHkgbm90IHJpZ2h0LgoKPiAKPiA+ICvCoMKgwqDCoMKgwqDC oH07Cj4gPiArCj4gPiArwqDCoMKgwqDCoMKgwqB0aW1lciB7Cj4gPiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgY29tcGF0aWJsZSA9ICJhcm0sYXJtdjgtdGltZXIiOwo+ID4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoC8qIEh5cGVydmlzb3IgVmlydHVhbCBUaW1lciBpbnRl cnJ1cHQgaXMgbm90IHdpcmVkCj4gPiB0byBHSUMgKi8KPiAKPiBJIGRvbid0IHVuZGVyc3RhbmQg dGhpcyBjb21tZW50LiBZb3Ugc2VlbSB0byBoYXZlIGEgYnVuY2ggb2YKPiBBUk12OC4wIGNvcmVz LCBmb3Igd2hpY2ggdGhlcmUgaXMgbm8gc3VjaCB0aGluZyBhcyBhIGh5cGVydmlzb3IKPiB2aXJ0 dWFsIHRpbWVyICh0aGlzIGlzIGFuIEFSTXY4LjEgYWRkaXRpb24pLgoKTXkgYmFkLCB3aWxsIHJl bW92ZSBpdCEgU2hvdWxkIGhhdmUgcmVhZCBkb2NzIGJldHRlci4KCj4gCj4gPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgaW50ZXJydXB0cyA9IDxHSUNfUFBJIDEzIChHSUNfQ1BVX01B U0tfU0lNUExFKDgpIHwgCj4gPiBJUlFfVFlQRV9MRVZFTF9MT1cpPiwKPiA+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgPEdJQ19QUEkgMTQg KEdJQ19DUFVfTUFTS19TSU1QTEUoOCkgfAo+ID4gSVJRX1RZUEVfTEVWRUxfTE9XKT4sCj4gPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDxH SUNfUFBJIDExIChHSUNfQ1BVX01BU0tfU0lNUExFKDgpIHwKPiA+IElSUV9UWVBFX0xFVkVMX0xP Vyk+LAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCA8R0lDX1BQSSAxMCAoR0lDX0NQVV9NQVNLX1NJTVBMRSg4KSB8Cj4gPiBJUlFfVFlQ RV9MRVZFTF9MT1cpPjsKPiA+ICvCoMKgwqDCoMKgwqDCoH07Cj4gCj4gVGhhbmtzLAo+IAo+IMKg wqDCoMKgwqDCoMKgwqAgTS4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==