All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Antonov <alexander.antonov@linux.intel.com>,
	Alexei Budankov <abudankov@huawei.com>,
	Riccardo Mancini <rickyman7@gmail.com>
Subject: [PATCH v7 17/20] perf session: Move init into reader__init function
Date: Tue, 22 Jun 2021 11:42:26 +0300	[thread overview]
Message-ID: <cc317de29e93406dc6943ba09764cfbf78ae9805.1624350588.git.alexey.v.bayduraev@linux.intel.com> (raw)
In-Reply-To: <cover.1624350588.git.alexey.v.bayduraev@linux.intel.com>

Separating initialization code into reader__init function.

Design and implementation are based on the prototype [1], [2].

[1] git clone https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git -b perf/record_threads
[2] https://lore.kernel.org/lkml/20180913125450.21342-1-jolsa@kernel.org/

Suggested-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
---
 tools/perf/util/session.c | 34 ++++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 3c89fed4f93c..2b3548525229 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -2211,28 +2211,25 @@ static int __perf_session__process_decomp_events(struct perf_session *session)
 }
 
 static int
-reader__process_events(struct reader *rd, struct perf_session *session,
-		       struct ui_progress *prog)
+reader__init(struct reader *rd, bool *one_mmap)
 {
 	struct reader_state *st = &rd->state;
-	u64 page_offset, size;
-	int err = 0, mmap_prot, mmap_flags;
-	char *buf, **mmaps = st->mmaps;
-	union perf_event *event;
-	s64 skip;
+	u64 page_offset;
+	char **mmaps = st->mmaps;
+
+	pr_debug("reader processing %s\n", rd->path);
 
 	page_offset = page_size * (rd->data_offset / page_size);
 	st->file_offset = page_offset;
 	st->head = rd->data_offset - page_offset;
 
-	ui_progress__init_size(prog, rd->data_size, "Processing events...");
-
 	st->data_size = rd->data_size + rd->data_offset;
 
 	st->mmap_size = MMAP_SIZE;
 	if (st->mmap_size > st->data_size) {
 		st->mmap_size = st->data_size;
-		session->one_mmap = true;
+		if (one_mmap)
+			*one_mmap = true;
 	}
 
 	memset(mmaps, 0, sizeof(st->mmaps));
@@ -2240,6 +2237,20 @@ reader__process_events(struct reader *rd, struct perf_session *session,
 	if (zstd_init(&rd->zstd_data, 0))
 		return -1;
 
+	return 0;
+}
+
+static int
+reader__process_events(struct reader *rd, struct perf_session *session,
+		       struct ui_progress *prog)
+{
+	struct reader_state *st = &rd->state;
+	u64 page_offset, size;
+	int err = 0, mmap_prot, mmap_flags;
+	char *buf, **mmaps = st->mmaps;
+	union perf_event *event;
+	s64 skip;
+
 	mmap_prot  = PROT_READ;
 	mmap_flags = MAP_SHARED;
 
@@ -2355,6 +2366,9 @@ static int __perf_session__process_events(struct perf_session *session)
 
 	ui_progress__init_size(&prog, rd->data_size, "Processing events...");
 
+	err = reader__init(rd, &session->one_mmap);
+	if (err)
+		goto out_err;
 	err = reader__process_events(rd, session, &prog);
 	if (err)
 		goto out_err;
-- 
2.19.0


  parent reply	other threads:[~2021-06-22  8:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22  8:42 [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 01/20] perf record: Introduce thread affinity and mmap masks Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 02/20] perf record: Introduce thread specific data array Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 03/20] perf record: Introduce thread local variable Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 04/20] perf record: Stop threads in the end of trace streaming Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 05/20] perf record: Start threads in the beginning " Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 06/20] perf record: Introduce data file at mmap buffer object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 07/20] perf record: Introduce data transferred and compressed stats Alexey Bayduraev
2021-06-30  8:05   ` Riccardo Mancini
2021-06-30 12:19     ` Bayduraev, Alexey V
2021-06-30 14:48       ` Bayduraev, Alexey V
2021-06-22  8:42 ` [PATCH v7 08/20] perf record: Init data file at mmap buffer object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 09/20] tools lib: Introduce bitmap_intersects() operation Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 10/20] perf record: Introduce --threads=<spec> command line option Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 11/20] perf record: Document parallel data streaming mode Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 12/20] perf report: Output data file name in raw trace dump Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 13/20] perf session: Move reader structure to the top Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 14/20] perf session: Introduce reader_state in reader object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 15/20] perf session: Introduce reader objects in session object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 16/20] perf session: Introduce decompressor into trace reader object Alexey Bayduraev
2021-06-22  8:42 ` Alexey Bayduraev [this message]
2021-06-22  8:42 ` [PATCH v7 18/20] perf session: Move map/unmap into reader__mmap function Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 19/20] perf session: Load single file for analysis Alexey Bayduraev
2021-06-27  0:49   ` Namhyung Kim
2021-06-22  8:42 ` [PATCH v7 20/20] perf session: Load data directory files " Alexey Bayduraev
2021-06-30  6:14   ` Namhyung Kim
2021-06-27  0:46 ` [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation Namhyung Kim
2021-06-28  8:11   ` Bayduraev, Alexey V
2021-06-30  6:09     ` Namhyung Kim
2021-06-30  7:22       ` Bayduraev, Alexey V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc317de29e93406dc6943ba09764cfbf78ae9805.1624350588.git.alexey.v.bayduraev@linux.intel.com \
    --to=alexey.v.bayduraev@linux.intel.com \
    --cc=abudankov@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.antonov@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rickyman7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.