From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC20AC433EF for ; Tue, 15 Mar 2022 20:23:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 12EBF83C09; Tue, 15 Mar 2022 21:23:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=boundarydevices.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=boundarydevices.com header.i=@boundarydevices.com header.b="QkxKMzcC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8443383C0C; Tue, 15 Mar 2022 21:23:49 +0100 (CET) Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DD8D983C06 for ; Tue, 15 Mar 2022 21:23:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=boundarydevices.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=troy.kisky@boundarydevices.com Received: by mail-pf1-x436.google.com with SMTP id t2so735200pfj.10 for ; Tue, 15 Mar 2022 13:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=R1WgqS/JQZ8/Z0AmxExIFkELzsc5U77zYfuZGI/Rlv4=; b=QkxKMzcCBcVHldboOcOo8NtBztQZlT0zBIpTQim7CGKoHxkMwiwNvH5f2e31Xs1/BT CSmpfq8QxDqAnGSUmunNxhRBuKFry+0oAyNu+uS1sLtLo/WlYOr3bay7739IRVKqQIZN zku4oAQPAMDkbkyqYORRR5uLYJeURCworfTGo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=R1WgqS/JQZ8/Z0AmxExIFkELzsc5U77zYfuZGI/Rlv4=; b=EKhNgQ9eNyMDu53yRBTEBuuwYoyyp9XGi65g2PBvyM4UDuZy2NSb9XQEYSAbQDLJZH bHkDx7Dlkb/NS3ZPCQY8a5MONXYv5fbyik3QXSnC77hdnZ9M9gbXoYKii367bxsgqvCO Pxih2R6XTlAGJJOE8Mnl0Qeu9TqE1Jh8iD8mY0IjBlbo2YcgkXdWmd4u+kdOmmSZfD4W MOoxeUbRXzdseTXaj4sH8EsO9jig+ipUOBLeq6pR7VAwknDzmNjEg0j2w8zLIdaixESd 6TrrnwZUxLVthcBKL522/YkODcbn7kwbnqVSSZwhi4zmVmVWHZRFoETtO669Usk8zDjW 7mcA== X-Gm-Message-State: AOAM531zsh+v1dabRHdbUdmREN5/yWVwOHs0fVLof5JxNbU4ZVDf7VCU AWlu18k3vTozDrqocclKM0o8wg== X-Google-Smtp-Source: ABdhPJxemEBHkxAD+urdQkLUn9vvmybW5TZcm7SwWfxj/GljB0yXMoKvfaVTXMUqpgBUivljv7yhjg== X-Received: by 2002:a63:ff18:0:b0:380:f89f:c99d with SMTP id k24-20020a63ff18000000b00380f89fc99dmr21905209pgi.332.1647375824056; Tue, 15 Mar 2022 13:23:44 -0700 (PDT) Received: from [192.168.0.4] (wsip-72-200-236-186.oc.oc.cox.net. [72.200.236.186]) by smtp.googlemail.com with ESMTPSA id ic6-20020a17090b414600b001bf691499e4sm3874969pjb.33.2022.03.15.13.23.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 13:23:43 -0700 (PDT) Message-ID: Date: Tue, 15 Mar 2022 13:23:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v1 0/5] Move board specific files to board directory Content-Language: en-US To: Tom Rini Cc: Simon Glass , U-Boot Mailing List References: <20211217230131.2715940-1-troy.kisky@boundarydevices.com> <20211228131115.GZ2773246@bill-the-cat> <20220107151250.GK2773246@bill-the-cat> <20220208143016.GN7515@bill-the-cat> <15ff0408-7b2f-c892-9239-ed923c835365@boundarydevices.com> <20220315200114.GA577378@bill-the-cat> From: Troy Kisky In-Reply-To: <20220315200114.GA577378@bill-the-cat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/15/2022 1:01 PM, Tom Rini wrote: > On Tue, Mar 15, 2022 at 12:08:02PM -0700, Troy Kisky wrote: >> On 2/8/2022 6:30 AM, Tom Rini wrote: >>> On Fri, Jan 07, 2022 at 10:33:34AM -0800, Troy Kisky wrote: >>>> On 1/7/2022 7:12 AM, Tom Rini wrote: >>>>> On Thu, Jan 06, 2022 at 01:14:40PM -0800, Troy Kisky wrote: >>>>>> On 12/28/2021 5:11 AM, Tom Rini wrote: >>>>>>> On Tue, Dec 28, 2021 at 01:33:05AM -0700, Simon Glass wrote: >>>>>>>> Hi Troy, >>>>>>>> >>>>>>>> On Fri, 17 Dec 2021 at 16:02, Troy Kisky wrote: >>>>>>>>> >>>>>>>>> This series intends to let board specific files live in the boards >>>>>>>>> directory. The last patch moves files for nitrogen6x. >>>>>>>>> I have tested it with buildman >>>>>>>>> >>>>>>>>> ./tools/buildman/buildman boundary -b denx_master >>>>>>>>> >>>>>>>>> But it is likely the more scripts then just tools/genboardscfg.py would >>>>>>>>> need to be updated. >>>>>>>>> >>>>>>>>> Troy Kisky (5): >>>>>>>>> kconfig: allow defconfigs to live in board directory >>>>>>>>> dts: allow dts files in board directory >>>>>>>>> scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file to live >>>>>>>>> in board directory >>>>>>>>> genboardcfg: allow defconfigs in board directory >>>>>>>>> nitrogen6x: move board specific files to nitrogen6x directory >>>>>>>>> >>>>>>>>> arch/arm/dts/Makefile | 3 -- >>>>>>>>> board/boundary/nitrogen6x/MAINTAINERS | 13 ------- >>>>>>>>> board/boundary/nitrogen6x/Makefile | 13 +++++++ >>>>>>>>> .../nitrogen6x}/imx6dl-nitrogen6x.dts | 0 >>>>>>>>> .../boundary/nitrogen6x}/imx6q-nitrogen6x.dts | 0 >>>>>>>>> .../boundary/nitrogen6x}/imx6q-sabrelite.dts | 0 >>>>>>>>> .../nitrogen6x}/imx6qdl-nitrogen6x.dtsi | 0 >>>>>>>>> .../nitrogen6x}/imx6qdl-sabrelite.dtsi | 0 >>>>>>>>> .../nitrogen6x}/mx6qsabrelite_defconfig | 0 >>>>>>>>> .../nitrogen6x}/nitrogen6dl2g_defconfig | 0 >>>>>>>>> .../nitrogen6x}/nitrogen6dl_defconfig | 0 >>>>>>>>> .../nitrogen6x}/nitrogen6q2g_defconfig | 0 >>>>>>>>> .../boundary/nitrogen6x}/nitrogen6q_defconfig | 0 >>>>>>>>> .../nitrogen6x}/nitrogen6s1g_defconfig | 0 >>>>>>>>> .../boundary/nitrogen6x}/nitrogen6s_defconfig | 0 >>>>>>>>> .../boundary/nitrogen6x}/nitrogen6x.h | 2 +- >>>>>>>>> dts/Makefile | 11 +++++- >>>>>>>>> scripts/Makefile.autoconf | 9 ++++- >>>>>>>>> scripts/Makefile.lib | 1 + >>>>>>>>> scripts/kconfig/Makefile | 9 ++++- >>>>>>>>> tools/genboardscfg.py | 37 ++++++++++++++++++- >>>>>>>>> 21 files changed, 75 insertions(+), 23 deletions(-) >>>>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6dl-nitrogen6x.dts (100%) >>>>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6q-nitrogen6x.dts (100%) >>>>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6q-sabrelite.dts (100%) >>>>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6qdl-nitrogen6x.dtsi (100%) >>>>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6qdl-sabrelite.dtsi (100%) >>>>>>>>> rename {configs => board/boundary/nitrogen6x}/mx6qsabrelite_defconfig (100%) >>>>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6dl2g_defconfig (100%) >>>>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6dl_defconfig (100%) >>>>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6q2g_defconfig (100%) >>>>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6q_defconfig (100%) >>>>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6s1g_defconfig (100%) >>>>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6s_defconfig (100%) >>>>>>>>> rename {include/configs => board/boundary/nitrogen6x}/nitrogen6x.h (98%) I'm not about the goal. >>>>>>>> >>>>>>>> Can you please add a few notes about the motivation for this change? >>>>>>> >>>>>>> Sorry for the delayed reply here. I'm also not entirely sure this is a >>>>>>> good idea. Moving the defconfig files? Maybe. It does make checking >>>>>>> all configs a bit more tricky, but indeed the configs directory is >>>>>>> unwieldy. Moving the dts files? Those should be a direct cp from the >>>>>>> kernel, so that makes things less clear to me. Especially since it will >>>>>>> need other common files that will still be elsewhere. >>>>>>> >>>>>> >>>>>> They will still be a direct copy. Notice the 100% rename. Common files still living in the dts >>>>>> directory is less clear. I can try to address the "piecemeal building of .dts files" if this >>>>>> still has a chance of being accepted. >>>>> >>>>> So, here's my worry. Today, in an ideal world that we're not yet at, I >>>>> could do: >>>>> 1. cd ~/src/linux; git checkout v5.16 >>>>> 2. cd ~/src/u-boot; for DTS in arch/arm/dts/*.dts*; do \ >>>>> [ -f ~/src/linux/$DTS ] && cp ~/src/linux/$DTS $DTS; done >> >> Perhaps we can mimic Linux's arm/arm64 dts split and make the above work better? > > Along with making the distinction between what we're mirroring and what > we're adding more clear yes, that would be viable I think. > Do you envision the *u-boot.dts not moving with the other files ? Or moving to a directory with a different name? i.e. arm-u-boot, arm64-u-boot, with the same sub-directory structure.