From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:42406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjRY5-00049X-JT for qemu-devel@nongnu.org; Tue, 15 Jan 2019 11:26:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjRY1-0006LN-Li for qemu-devel@nongnu.org; Tue, 15 Jan 2019 11:26:43 -0500 From: Vladimir Sementsov-Ogievskiy Date: Tue, 15 Jan 2019 16:26:23 +0000 Message-ID: References: <20190112175812.27068-1-eblake@redhat.com> <20190112175812.27068-5-eblake@redhat.com> <3342cf43-21ba-60aa-4ca2-ed0e5b0ea4ae@virtuozzo.com> <8312fb33-1724-d0b0-c5af-763963250ced@redhat.com> In-Reply-To: <8312fb33-1724-d0b0-c5af-763963250ced@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 04/19] nbd/server: Hoist length check to qemp_nbd_server_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , "qemu-devel@nongnu.org" Cc: "nsoffer@redhat.com" , "rjones@redhat.com" , "jsnow@redhat.com" , "qemu-block@nongnu.org" , Kevin Wolf , Max Reitz MTUuMDEuMjAxOSAxODoyNSwgRXJpYyBCbGFrZSB3cm90ZToNCj4gT24gMS8xNS8xOSAzOjQ0IEFN LCBWbGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IHdyb3RlOg0KPj4gMTIuMDEuMjAxOSAyMDo1 NywgRXJpYyBCbGFrZSB3cm90ZToNCj4+PiBXZSBvbmx5IGhhZCB0d28gY2FsbGVycyB0byBuYmRf ZXhwb3J0X25ldzsgcWVtdS1uYmQuYyBhbHdheXMNCj4+PiBwYXNzZWQgYSB2YWxpZCBvZmZzZXQv bGVuZ3RoIHBhaXIgKGJlY2F1c2UgaXQgYWxyZWFkeSBjaGVja2VkDQo+Pj4gdGhlIGZpbGUgbGVu Z3RoLCB0byBlbnN1cmUgdGhhdCBvZmZzZXQgd2FzIGluIGJvdW5kcyksIHdoaWxlDQo+Pj4gYmxv Y2tkZXYtbmJkIGFsd2F5cyBwYXNzZWQgMC8tMS4gIFRoZW4gbmJkX2V4cG9ydF9uZXcgcmVkdWNl cw0KPj4+IHRoZSBzaXplIHRvIGEgbXVsdGlwbGUgb2YgQkRSVl9TRUNUT1JfU0laRSAoY2FuIG9u bHkgaGFwcGVuDQo+Pj4gd2hlbiBvZmZzZXQgaXMgbm90IHNlY3Rvci1hbGlnbmVkLCBzaW5jZSBi ZHJ2X2dldGxlbmd0aCgpDQo+Pj4gY3VycmVudGx5IHJvdW5kcyB1cCksIHdoaWNoIGNhbiByZXN1 bHQgaW4gb2Zmc2V0IGJlaW5nIGdyZWF0ZXINCj4+PiB0aGFuIHRoZSBlbmZvcmNlZCBsZW5ndGgs IGJ1dCB0aGF0J3Mgbm90IGZhdGFsICh0aGUgc2VydmVyDQo+Pj4gcmVqZWN0cyBjbGllbnQgcmVx dWVzdHMgdGhhdCBleGNlZWQgdGhlIGFkdmVydGlzZWQgbGVuZ3RoKS4NCj4+Pg0KPj4+IEhvd2V2 ZXIsIEknbSBmaW5kaW5nIGl0IGVhc2llciB0byB3b3JrIHdpdGggdGhlIGNvZGUgaWYgd2UgYXJl DQo+Pj4gY29uc2lzdGVudCBvbiBoYXZpbmcgYm90aCBjYWxsZXJzIHBhc3MgaW4gYSB2YWxpZCBs ZW5ndGgsIGFuZA0KPj4+IGp1c3QgYXNzZXJ0IHRoYXQgdGhpbmdzIGFyZSBzYW5lIGluIG5iZF9l eHBvcnRfbmV3Lg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogRXJpYyBCbGFrZSA8ZWJsYWtlQHJl ZGhhdC5jb20+DQo+Pj4NCj4gDQo+Pj4gKysrIGIvbmJkL3NlcnZlci5jDQo+Pj4gQEAgLTE0OTks MTMgKzE0OTksOCBAQCBOQkRFeHBvcnQgKm5iZF9leHBvcnRfbmV3KEJsb2NrRHJpdmVyU3RhdGUg KmJzLCBvZmZfdCBkZXZfb2Zmc2V0LCBvZmZfdCBzaXplLA0KPj4+ICAgICAgICBleHAtPm5hbWUg PSBnX3N0cmR1cChuYW1lKTsNCj4+PiAgICAgICAgZXhwLT5kZXNjcmlwdGlvbiA9IGdfc3RyZHVw KGRlc2NyaXB0aW9uKTsNCj4+PiAgICAgICAgZXhwLT5uYmRmbGFncyA9IG5iZGZsYWdzOw0KPj4+ IC0gICAgZXhwLT5zaXplID0gc2l6ZSA8IDAgPyBibGtfZ2V0bGVuZ3RoKGJsaykgOiBzaXplOw0K Pj4+IC0gICAgaWYgKGV4cC0+c2l6ZSA8IDApIHsNCj4+PiAtICAgICAgICBlcnJvcl9zZXRnX2Vy cm5vKGVycnAsIC1leHAtPnNpemUsDQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAiRmFp bGVkIHRvIGRldGVybWluZSB0aGUgTkJEIGV4cG9ydCdzIGxlbmd0aCIpOw0KPj4+IC0gICAgICAg IGdvdG8gZmFpbDsNCj4+PiAtICAgIH0NCj4+PiAtICAgIGV4cC0+c2l6ZSAtPSBleHAtPnNpemUg JSBCRFJWX1NFQ1RPUl9TSVpFOw0KPj4+ICsgICAgYXNzZXJ0KGRldl9vZmZzZXQgPD0gc2l6ZSk7 DQo+Pg0KPj4gQHNpemUgaXMgbm90IHNpemUgb2YgdGhlIGltYWdlLCBidXQgc2l6ZSBvZiB0aGUg ZXhwb3J0LCBzbyBpdCBtYXkgYmUgbGVzcyB0aGFuIGRldl9vZmZzZXQNCj4+IChxZW11LW5iZC5j IGRvICJmZF9zaXplIC09IGRldl9vZmZzZXQiIGJlZm9yZSAibmJkX2V4cG9ydF9uZXcoYnMsIGRl dl9vZmZzZXQsIGZkX3NpemUsICINCj4gDQo+IEJ1dCB0aGUgYXNzZXJ0IGlzIGZpbmUgYmVjYXVz ZSBwYXRjaCAzLzE5IGZpeGVkIHFlbXUtbmJkLmMgdG8gbmV2ZXIgcGFzcw0KPiBpbiBkZXZfb2Zm c2V0IGxhcmdlciB0aGFuIHNpemUgKGl0IGZhaWxzIHVwIGZyb250IGlmIGRldl9vZmZzZXQgaXMg b3V0DQo+IG9mIGJvdW5kcywgd2hldGhlciBmcm9tIHRoZSAtbyBjb21tYW5kIGxpbmUgb3B0aW9u IG9yIGZyb20gd2hhdCBpdCByZWFkDQo+IGZyb20gdGhlIHBhcnRpdGlvbiBoZWFkZXIgd2l0aCB0 aGUgLVAgY29tbWFuZCBsaW5lIG9wdGlvbikuDQo+IA0KDQpEb24ndCBmb2xsb3cgPSgNCg0KQXNz dW1lLCBpbWFnZSBzaXplIDNNLCBhbmQgd2UgaGF2ZSBvZmZzZXQgMk0sIGkuZS4gLW8gMk0uDQoN CnRoYW4gaW4gcWVtdS1uYmQuYywgd2UgaGF2ZQ0KDQpmZF9zaXplID0gYmxrX2dldGxlbmd0aChi bGspOyAjIDNNDQouLi4NCmZkX3NpemUgLT0gZGV2X29mZnNldDsgIyAxTQ0KLi4uDQpleHBvcnQg PSBuYmRfZXhwb3J0X25ldyhicywgZGV2X29mZnNldCwgZmRfc2l6ZSAjIGJzLCAyTSwgMU0NCg0K aW4gbmJkX2V4cG9ydF9uZXc6DQoNCmFzc2VydChkZXZfb2Zmc2V0IDw9IHNpemUpOyAjIDJNIDw9 IDFNDQoNCmZhaWwuDQoNCi0tIA0KQmVzdCByZWdhcmRzLA0KVmxhZGltaXINCg==