All of lore.kernel.org
 help / color / mirror / Atom feed
From: kirill@shutemov.name (Kirill A. Shutemov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 RESEND 1/2] ARM: Introduce ARM_L1_CACHE_SHIFT to define cache line size
Date: Sat, 12 Sep 2009 17:12:19 +0300	[thread overview]
Message-ID: <cc557aab0909120712j354238c3oe3396591287b5562@mail.gmail.com> (raw)
In-Reply-To: <4AABA3F7.2050301@ru.mvista.com>

On Sat, Sep 12, 2009 at 4:36 PM, Sergei Shtylyov
<sshtylyov@ru.mvista.com> wrote:
> Hello.
>
> Kirill A. Shutemov wrote:
>
>> Currently kernel believes that all ARM CPUs have L1_CACHE_SHIFT == 5.
>> It's not true at least for CPUs based on Cortex-A8.
>>
>> List of CPUs with cache line size != 32 should be expanded later.
>>
>> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
>> ---
>> ?arch/arm/include/asm/cache.h | ? ?2 +-
>> ?arch/arm/mm/Kconfig ? ? ? ? ?| ? ?5 +++++
>> ?2 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/cache.h b/arch/arm/include/asm/cache.h
>> index feaa75f..2ee7743 100644
>> --- a/arch/arm/include/asm/cache.h
>> +++ b/arch/arm/include/asm/cache.h
>> @@ -4,7 +4,7 @@
>> ?#ifndef __ASMARM_CACHE_H
>> ?#define __ASMARM_CACHE_H
>> ?-#define L1_CACHE_SHIFT ? ? ? ? 5
>> +#define L1_CACHE_SHIFT ? ? ? ? (CONFIG_ARM_L1_CACHE_SHIFT)
>>
>
> ?Parens not needed.

You can write anything in your .config (like 2+3), so I think parens is needed.

  reply	other threads:[~2009-09-12 14:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-12 15:59 [PATCH v2 RESEND 0/2] ARM: optimize copy_page() for systems with cache line != 32 Kirill A. Shutemov
2009-09-12 15:59 ` [PATCH v2 RESEND 1/2] ARM: Introduce ARM_L1_CACHE_SHIFT to define cache line size Kirill A. Shutemov
2009-09-12 13:36   ` Sergei Shtylyov
2009-09-12 14:12     ` Kirill A. Shutemov [this message]
2009-09-12 14:21       ` Sergei Shtylyov
2009-09-12 14:38         ` Kirill A. Shutemov
2009-09-12 14:53           ` Russell King - ARM Linux
2009-09-12 15:59   ` [PATCH v2 RESEND 2/2] ARM: copy_page.S: take into account the size of the cache line Kirill A. Shutemov
2009-09-12 13:48     ` Uwe Kleine-König
2009-09-12 14:04       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc557aab0909120712j354238c3oe3396591287b5562@mail.gmail.com \
    --to=kirill@shutemov.name \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.