From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, pbonzini@redhat.com, vkuznets@redhat.com
Cc: thuth@redhat.com, drjones@redhat.com, wei.huang2@amd.com
Subject: Re: [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum
Date: Fri, 7 Feb 2020 17:07:52 -0800 [thread overview]
Message-ID: <cc575b88-14f4-e2ee-9d91-9f5d2e06684b@oracle.com> (raw)
In-Reply-To: <20200207142715.6166-3-eric.auger@redhat.com>
On 2/7/20 6:27 AM, Eric Auger wrote:
> x86_register enum is not used. Its presence incites us
> to enumerate GPRs in the same order in other looming
> structs. So let's remove it.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> .../selftests/kvm/include/x86_64/processor.h | 20 -------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/include/x86_64/processor.h b/tools/testing/selftests/kvm/include/x86_64/processor.h
> index 6f7fffaea2e8..e48dac5c29e8 100644
> --- a/tools/testing/selftests/kvm/include/x86_64/processor.h
> +++ b/tools/testing/selftests/kvm/include/x86_64/processor.h
> @@ -36,26 +36,6 @@
> #define X86_CR4_SMAP (1ul << 21)
> #define X86_CR4_PKE (1ul << 22)
>
> -/* The enum values match the intruction encoding of each register */
> -enum x86_register {
> - RAX = 0,
> - RCX,
> - RDX,
> - RBX,
> - RSP,
> - RBP,
> - RSI,
> - RDI,
> - R8,
> - R9,
> - R10,
> - R11,
> - R12,
> - R13,
> - R14,
> - R15,
> -};
> -
> struct desc64 {
> uint16_t limit0;
> uint16_t base0;
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
next prev parent reply other threads:[~2020-02-08 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 14:27 [PATCH v5 0/4] selftests: KVM: AMD Nested SVM test infrastructure Eric Auger
2020-02-07 14:27 ` [PATCH v5 1/4] selftests: KVM: Replace get_[gdt | idt]_base() by get_[gdt | idt]() Eric Auger
2020-02-07 14:27 ` [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum Eric Auger
2020-02-07 15:07 ` Vitaly Kuznetsov
2020-02-08 1:07 ` Krish Sadhukhan [this message]
2020-02-07 14:27 ` [PATCH v5 3/4] selftests: KVM: AMD Nested test infrastructure Eric Auger
2020-02-07 15:09 ` Vitaly Kuznetsov
2020-02-08 1:15 ` Krish Sadhukhan
2020-02-07 14:27 ` [PATCH v5 4/4] selftests: KVM: SVM: Add vmcall test Eric Auger
2020-02-08 1:08 ` Krish Sadhukhan
2020-02-12 12:09 ` [PATCH v5 0/4] selftests: KVM: AMD Nested SVM test infrastructure Paolo Bonzini
2020-02-12 12:25 ` Auger Eric
2020-02-07 15:37 [PATCH v5 2/4] selftests: KVM: Remove unused x86_register enum linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc575b88-14f4-e2ee-9d91-9f5d2e06684b@oracle.com \
--to=krish.sadhukhan@oracle.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.