From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88634C7618B for ; Thu, 25 Jul 2019 14:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B8FC22C7D for ; Thu, 25 Jul 2019 14:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729112AbfGYOhX (ORCPT ); Thu, 25 Jul 2019 10:37:23 -0400 Received: from smtprelay0254.hostedemail.com ([216.40.44.254]:38403 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729058AbfGYOhU (ORCPT ); Thu, 25 Jul 2019 10:37:20 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 68FA18047AB9; Thu, 25 Jul 2019 14:37:18 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: mist49_3f8efb7ea8d42 X-Filterd-Recvd-Size: 3266 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Thu, 25 Jul 2019 14:37:16 +0000 (UTC) Message-ID: Subject: Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro From: Joe Perches To: Joel Stanley Cc: Andrew Jeffery , Andrew Morton , David Airlie , Daniel Vetter , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, Linux ARM , Linux Kernel Mailing List Date: Thu, 25 Jul 2019 07:37:14 -0700 In-Reply-To: References: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com> <4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com> <4e5bc8d61436024a30a8fb6a1516e29e23a75ede.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-07-25 at 02:52 +0000, Joel Stanley wrote: > On Thu, 25 Jul 2019 at 01:18, Joe Perches wrote: > > On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > > Arguments are supposed to be ordered high then low. > > > > > > > > > > Signed-off-by: Joe Perches > > > > > --- > > > > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > index a10358bb61ec..095ea03e5833 100644 > > > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > > > > > /* CTRL2 */ > > > > > #define CRT_CTRL_DAC_EN BIT(0) > > > > > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) > > > > > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) > > > > > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) > > > > > > Reviewed-by: Andrew Jeffery > > > > This hardly needs a review, it needs to be applied. > > There's a nominal git tree for aspeed here: > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > > > > But who's going to do apply this? > > This is a DRM patch, so it goes through the DRM tree. I am a > co-maintainer there and can apply it once I remember how to drive the > tools. > > (FYI, this macro is not used by the current driver). Then perhaps CRT_CTRL_VBLANK and _MASK defines should be removed instead. cheers, Joe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85570C7618B for ; Thu, 25 Jul 2019 14:37:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59AC5218EA for ; Thu, 25 Jul 2019 14:37:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LWE3m0uq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59AC5218EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ofiSBaWuyOr2GHSdEYemJoGw5b+XGpGB+DpfNmnlyR0=; b=LWE3m0uqjacStX nM5uTQRMkWzig9u+SNbmA150QkOkgOrysRc+uZUa6kewBcSUEh2L6siACh2BsKxDMXHEBYOQaryiD iXC1csdNZOK6JwUo4UUG0b8FLJHR0lfBt9JfolGt8Za/wRJ7fk6W/O1LsotivEHsNLmI+CHWjJd66 kehCvmKUAC/1nDBPjNZgutAPLSKmaHlzBc/s1qQB2fdfzW0unoV1oHoKz33PZ97mD72sH5RicPn22 FPtsrX3gn2zqg64jbt7Hbf0F7CP3F8pXAY5OBbNfUqeVC+Bj4KRu075c30LGLDuihFJ4Wodmfr5Dh l5gNVnEvQGw6M0G5sS9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqes1-00014X-FT; Thu, 25 Jul 2019 14:37:25 +0000 Received: from smtprelay0037.hostedemail.com ([216.40.44.37] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqerx-00013X-US for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2019 14:37:23 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 68FA18047AB9; Thu, 25 Jul 2019 14:37:18 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: mist49_3f8efb7ea8d42 X-Filterd-Recvd-Size: 3266 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Thu, 25 Jul 2019 14:37:16 +0000 (UTC) Message-ID: Subject: Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro From: Joe Perches To: Joel Stanley Date: Thu, 25 Jul 2019 07:37:14 -0700 In-Reply-To: References: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com> <4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com> <4e5bc8d61436024a30a8fb6a1516e29e23a75ede.camel@perches.com> User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_073722_115295_A37EB61D X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter , Andrew Morton , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-07-25 at 02:52 +0000, Joel Stanley wrote: > On Thu, 25 Jul 2019 at 01:18, Joe Perches wrote: > > On Thu, 2019-07-25 at 10:40 +0930, Andrew Jeffery wrote: > > > On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > > Arguments are supposed to be ordered high then low. > > > > > > > > > > Signed-off-by: Joe Perches > > > > > --- > > > > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > index a10358bb61ec..095ea03e5833 100644 > > > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > > > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > > > > > /* CTRL2 */ > > > > > #define CRT_CTRL_DAC_EN BIT(0) > > > > > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) > > > > > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) > > > > > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) > > > > > > Reviewed-by: Andrew Jeffery > > > > This hardly needs a review, it needs to be applied. > > There's a nominal git tree for aspeed here: > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git > > > > But who's going to do apply this? > > This is a DRM patch, so it goes through the DRM tree. I am a > co-maintainer there and can apply it once I remember how to drive the > tools. > > (FYI, this macro is not used by the current driver). Then perhaps CRT_CTRL_VBLANK and _MASK defines should be removed instead. cheers, Joe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro Date: Thu, 25 Jul 2019 07:37:14 -0700 Message-ID: References: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com> <4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com> <4e5bc8d61436024a30a8fb6a1516e29e23a75ede.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8AFAB6E70D for ; Thu, 25 Jul 2019 14:37:19 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, David Airlie , Andrew Morton , Linux ARM List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE5LTA3LTI1IGF0IDAyOjUyICswMDAwLCBKb2VsIFN0YW5sZXkgd3JvdGU6Cj4g T24gVGh1LCAyNSBKdWwgMjAxOSBhdCAwMToxOCwgSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNv bT4gd3JvdGU6Cj4gPiBPbiBUaHUsIDIwMTktMDctMjUgYXQgMTA6NDAgKzA5MzAsIEFuZHJldyBK ZWZmZXJ5IHdyb3RlOgo+ID4gPiBPbiBUaHUsIDI1IEp1bCAyMDE5LCBhdCAwMjo0NiwgSm9lIFBl cmNoZXMgd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCAyMDE5LTA3LTA5IGF0IDIyOjA0IC0wNzAwLCBK b2UgUGVyY2hlcyB3cm90ZToKPiA+ID4gPiA+IEFyZ3VtZW50cyBhcmUgc3VwcG9zZWQgdG8gYmUg b3JkZXJlZCBoaWdoIHRoZW4gbG93Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPgo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiAg ZHJpdmVycy9ncHUvZHJtL2FzcGVlZC9hc3BlZWRfZ2Z4LmggfCAyICstCj4gPiA+ID4gPiAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ID4gPiAKPiA+ ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXNwZWVkL2FzcGVlZF9nZnguaCBi L2RyaXZlcnMvZ3B1L2RybS9hc3BlZWQvYXNwZWVkX2dmeC5oCj4gPiA+ID4gPiBpbmRleCBhMTAz NThiYjYxZWMuLjA5NWVhMDNlNTgzMyAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hc3BlZWQvYXNwZWVkX2dmeC5oCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YXNwZWVkL2FzcGVlZF9nZnguaAo+ID4gPiA+ID4gQEAgLTc0LDcgKzc0LDcgQEAgaW50IGFzcGVl ZF9nZnhfY3JlYXRlX291dHB1dChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKTsKPiA+ID4gPiA+ICAv KiBDVFJMMiAqLwo+ID4gPiA+ID4gICNkZWZpbmUgQ1JUX0NUUkxfREFDX0VOICAgICAgICAgICAg ICAgICAgQklUKDApCj4gPiA+ID4gPiAgI2RlZmluZSBDUlRfQ1RSTF9WQkxBTktfTElORSh4KSAg ICAgICAgICAoKCh4KSA8PCAyMCkgJiBDUlRfQ1RSTF9WQkxBTktfTElORV9NQVNLKQo+ID4gPiA+ ID4gLSNkZWZpbmUgQ1JUX0NUUkxfVkJMQU5LX0xJTkVfTUFTSyAgICAgICAgR0VOTUFTSygyMCwg MzEpCj4gPiA+ID4gPiArI2RlZmluZSBDUlRfQ1RSTF9WQkxBTktfTElORV9NQVNLICAgICAgICBH RU5NQVNLKDMxLCAyMCkKPiA+ID4gCj4gPiA+IFJldmlld2VkLWJ5OiBBbmRyZXcgSmVmZmVyeSA8 YW5kcmV3QGFqLmlkLmF1Pgo+ID4gCj4gPiBUaGlzIGhhcmRseSBuZWVkcyBhIHJldmlldywgaXQg bmVlZHMgdG8gYmUgYXBwbGllZC4KPiA+IFRoZXJlJ3MgYSBub21pbmFsIGdpdCB0cmVlIGZvciBh c3BlZWQgaGVyZToKPiA+IAo+ID4gVDogICAgICBnaXQgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHVi L3NjbS9saW51eC9rZXJuZWwvZ2l0L2pvZWwvYXNwZWVkLmdpdAo+ID4gCj4gPiBCdXQgd2hvJ3Mg Z29pbmcgdG8gZG8gYXBwbHkgdGhpcz8KPiAKPiBUaGlzIGlzIGEgRFJNIHBhdGNoLCBzbyBpdCBn b2VzIHRocm91Z2ggdGhlIERSTSB0cmVlLiBJIGFtIGEKPiBjby1tYWludGFpbmVyIHRoZXJlIGFu ZCBjYW4gYXBwbHkgaXQgb25jZSBJIHJlbWVtYmVyIGhvdyB0byBkcml2ZSB0aGUKPiB0b29scy4K PiAKPiAoRllJLCB0aGlzIG1hY3JvIGlzIG5vdCB1c2VkIGJ5IHRoZSBjdXJyZW50IGRyaXZlciku CgpUaGVuIHBlcmhhcHMgQ1JUX0NUUkxfVkJMQU5LIGFuZCBfTUFTSyBkZWZpbmVzCnNob3VsZCBi ZSByZW1vdmVkIGluc3RlYWQuCgpjaGVlcnMsIEpvZQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs