From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6534C433DB for ; Tue, 2 Feb 2021 11:48:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60F3964EAC for ; Tue, 2 Feb 2021 11:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbhBBLs4 (ORCPT ); Tue, 2 Feb 2021 06:48:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbhBBLsy (ORCPT ); Tue, 2 Feb 2021 06:48:54 -0500 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECD68C061573 for ; Tue, 2 Feb 2021 03:48:13 -0800 (PST) Received: by mail-il1-x12f.google.com with SMTP id p15so18038172ilq.8 for ; Tue, 02 Feb 2021 03:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=i8yjWv7ZYVQ87c8yLM3My2cCeuFw/bHz0Id/b7ZzflI=; b=g1bjm1Cw4dRx9KuSznNwNqd9zMQxQ8mh/yPrLOZIv2NVpVGDtDfMGVabbrqiubOOz6 QEERr305GVQlhPfuD4A1r0tkvP90qZ4m0UQBQzKLtKq8Sywf15xP5pwELhTkU1pzySgX 4pzlOZF4NXUvhNa7Cq+XO/G2GwSWxIkjNc5JY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i8yjWv7ZYVQ87c8yLM3My2cCeuFw/bHz0Id/b7ZzflI=; b=h7l1dY1eeCwnNNSZPnOcWw/O7aibM2SMyREO5m28Z3fkFj7WP0UiqDkVC5007st3ML 1tQkQaOUlFcw1UlEdDxMIXUjswbiOTtqdKeN3bHuIe1VKoQtYXNRvOq0s187CJdEqOoE zlZ+Hqjh3ln7qyf1myw0uowd6FZZYgtWbklNW4rQrzMAu0xTR1+rpAFYH8sOSs/Vo/+9 um2t1Hrb91xnMhysA6W+zs0n49AtqFRMK2xTOrINUJwfYR0taNbXHQOUKjeRszbSNDgH Vx2nkUipaozjOPQ7thwPbyFQimV3MwKxg+qdOC8C9Y4uRhYXr3GshBVQta8yTMI2N81q q9kw== X-Gm-Message-State: AOAM530s1rLQSmdr5NNS2MZUGc1TimglZLu/VMa3mchoCIOjDDLADxWw guXxr6oO7iLBimfnQI46RQLwhA== X-Google-Smtp-Source: ABdhPJz0wwATr5H/UtuNxpv0rTHAbjagxB2WPYjGve68R6vxpl2aolDKibNUmvaHUK5vQ+GagzOt6Q== X-Received: by 2002:a05:6e02:48f:: with SMTP id b15mr18473415ils.144.1612266493375; Tue, 02 Feb 2021 03:48:13 -0800 (PST) Received: from [172.22.22.26] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id j25sm9762363iog.27.2021.02.02.03.48.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 03:48:12 -0800 (PST) Subject: Re: [PATCH net] net: ipa: pass correct dma_handle to dma_free_coherent() To: Dan Carpenter , Alex Elder Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Alex Elder Message-ID: Date: Tue, 2 Feb 2021 05:48:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/1/21 11:55 PM, Dan Carpenter wrote: > The "ring->addr = addr;" assignment is done a few lines later so we > can't use "ring->addr" yet. The correct dma_handle is "addr". > > Fixes: 650d1603825d ("soc: qcom: ipa: the generic software interface") > Signed-off-by: Dan Carpenter Yikes. Thank you for the fix. Reviewed-by: Alex Elder > --- > Smatch also complians about: > > drivers/net/ipa/gsi.c:1739 gsi_channel_setup() > warn: missing error code 'ret' > > It probably should return -EINVAL, but I'm not positive. > > drivers/net/ipa/gsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c > index f79cf3c327c1..b559d14271e2 100644 > --- a/drivers/net/ipa/gsi.c > +++ b/drivers/net/ipa/gsi.c > @@ -1373,7 +1373,7 @@ static int gsi_ring_alloc(struct gsi *gsi, struct gsi_ring *ring, u32 count) > /* Hardware requires a 2^n ring size, with alignment equal to size */ > ring->virt = dma_alloc_coherent(dev, size, &addr, GFP_KERNEL); > if (ring->virt && addr % size) { > - dma_free_coherent(dev, size, ring->virt, ring->addr); > + dma_free_coherent(dev, size, ring->virt, addr); > dev_err(dev, "unable to alloc 0x%zx-aligned ring buffer\n", > size); > return -EINVAL; /* Not a good error value, but distinct */ > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Date: Tue, 02 Feb 2021 11:48:11 +0000 Subject: Re: [PATCH net] net: ipa: pass correct dma_handle to dma_free_coherent() Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Alex Elder Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On 2/1/21 11:55 PM, Dan Carpenter wrote: > The "ring->addr = addr;" assignment is done a few lines later so we > can't use "ring->addr" yet. The correct dma_handle is "addr". > > Fixes: 650d1603825d ("soc: qcom: ipa: the generic software interface") > Signed-off-by: Dan Carpenter Yikes. Thank you for the fix. Reviewed-by: Alex Elder > --- > Smatch also complians about: > > drivers/net/ipa/gsi.c:1739 gsi_channel_setup() > warn: missing error code 'ret' > > It probably should return -EINVAL, but I'm not positive. > > drivers/net/ipa/gsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c > index f79cf3c327c1..b559d14271e2 100644 > --- a/drivers/net/ipa/gsi.c > +++ b/drivers/net/ipa/gsi.c > @@ -1373,7 +1373,7 @@ static int gsi_ring_alloc(struct gsi *gsi, struct gsi_ring *ring, u32 count) > /* Hardware requires a 2^n ring size, with alignment equal to size */ > ring->virt = dma_alloc_coherent(dev, size, &addr, GFP_KERNEL); > if (ring->virt && addr % size) { > - dma_free_coherent(dev, size, ring->virt, ring->addr); > + dma_free_coherent(dev, size, ring->virt, addr); > dev_err(dev, "unable to alloc 0x%zx-aligned ring buffer\n", > size); > return -EINVAL; /* Not a good error value, but distinct */ >