All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.thompson@linaro.org (Daniel Thompson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] arm64: Add support for on-demand backtrace of other CPUs
Date: Fri, 7 Apr 2017 18:09:39 +0100	[thread overview]
Message-ID: <cc6f2535-fa37-1368-e14e-e76e086d4e28@linaro.org> (raw)
In-Reply-To: <20170407170203.GC20645@e104818-lin.cambridge.arm.com>

On 07/04/17 18:02, Catalin Marinas wrote:
> On Fri, Mar 17, 2017 at 09:27:43AM +0200, Oleksandr Andrushchenko wrote:
>> From: Daniel Thompson <daniel.thompson@linaro.org>
>>
>> Currently arm64 has no implementation of arch_trigger_cpumask_backtrace.
>> The patch provides one using library code recently added by Russell King
>> for for the majority of the implementation. Currently this is realized
>> using regular irqs but could, in the future, be implemented using
>> NMI-like mechanisms.
>>
>> Note: There is a small (and nasty) change to the generic code to ensure
>>       good stack traces. The generic code currently assumes that
>>       show_regs() will include a stack trace but arch/arm64 does not do
>>       this so we must add extra code here. Ideas on a better approach
>>       here would be very welcome (is there any appetite to change arm64
>>       show_regs() or should we just tease out the dump code into a
>>       callback
>
> Please see this discussion here:
>
> http://lkml.kernel.org/r/20170323150357.GH9287 at leverpostej
>
> I'm not a ware of a follow up but if we change the arm64 show_regs() to
> dump the stack, we no longer need the generic code hunk in your patch.

Great. That hack did always irk me!

I'll tidy it up the next time I push out the PMR interrupt masking patch 
set.

Is there any interest in taking the patch before that. I don't mind 
separating it out... I'm just not sure how useful it is.

  reply	other threads:[~2017-04-07 17:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17  7:27 [PATCH v1] arm64: Add support for on-demand backtrace of other CPUs Oleksandr Andrushchenko
2017-03-17  7:27 ` Oleksandr Andrushchenko
2017-04-07 17:02   ` Catalin Marinas
2017-04-07 17:09     ` Daniel Thompson [this message]
2017-04-07 17:38       ` Oleksandr Andrushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc6f2535-fa37-1368-e14e-e76e086d4e28@linaro.org \
    --to=daniel.thompson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.