From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC405C433EF for ; Wed, 24 Nov 2021 09:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230089AbhKXJTw (ORCPT ); Wed, 24 Nov 2021 04:19:52 -0500 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:59633 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241440AbhKXJT0 (ORCPT ); Wed, 24 Nov 2021 04:19:26 -0500 Received: from [79.2.93.196] (port=52016 helo=[192.168.101.73]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mpoNw-0004yt-EW; Wed, 24 Nov 2021 10:16:12 +0100 Subject: Re: [PATCH v3 3/3] PCI: apple: Fix #PERST polarity To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, =?UTF-8?Q?Pali_Roh=c3=a1r?= , Alyssa Rosenzweig , Lorenzo Pieralisi , Bjorn Helgaas , Mark Kettenis , kernel-team@android.com References: <20211123180636.80558-1-maz@kernel.org> <20211123180636.80558-4-maz@kernel.org> <453389da-b041-94b3-009e-6c6323134936@lucaceresoli.net> <87fsrmc4e6.wl-maz@kernel.org> From: Luca Ceresoli Message-ID: Date: Wed, 24 Nov 2021 10:16:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <87fsrmc4e6.wl-maz@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 24/11/21 10:02, Marc Zyngier wrote: > On Tue, 23 Nov 2021 21:36:11 +0000, > Luca Ceresoli wrote: >> >> Hi Mark, >> >> On 23/11/21 19:06, Marc Zyngier wrote: >>> Now that #PERST is properly defined as active-low in the device tree, >>> fix the driver to correctly drive the line indemendently of the >>> implied polarity. >>> >>> Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up") >>> Suggested-by: Pali Rohár >>> Signed-off-by: Marc Zyngier >> >> Thanks for quickly addressing this! >> >> Do we need a transition path for backward compatibility with old DTs >> already around? Something like this [0]. You said [1] the DT actually >> used is not even the one in the kernel, thus how do we guarantee DT and >> driver switch to the new polarity all at once? > > No. As it turns out, neither u-boot nor OpenBSD (the only two other > payloads that can boot on M1) are upstreamed yet. So we're still in > that stage where we don't need to maintain backward compatibility. If > we don't get this patches merged by the end of this cycle, we will > have to revisit this though. Good news! Reviewed-by: Luca Ceresoli -- Luca From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C5A8C433FE for ; Wed, 24 Nov 2021 09:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=MdCDi7ocT5Aiq3ODsn17/zODDzDMClscGhdRYfquMPI=; b=ldB2x9YH2ZKb4L89+pa9QCdFQ0 fZf49inL9jatBFinz/x/dEE360jjVfIvAyTqdcfzKHyQuHLNrX676+vBqOE3PtPr+3r3Ftm6sMWHe UYs2ArTEvGohaDvY9mD1I/iF87iJCf0wepERHOWyYEY8ejJSwifurtwYa2dE4vpmIGRtNi2VoYx2/ 9Pu4TqS0aLWa59Cd0PUs08NdYiXDRVKPz1ZrLxP54g8Cc6p73zbRvpRmGv0ZDipcmYG1tVAlnhio5 O5SSj0xd53bYgXnU4QCg8wZabCaiZOvt/aJp0YfYMF0fAsU9WjjYaPcCcaC56CdlU8kY4P3rqcAwX +18JDvDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpoO3-004MiI-0J; Wed, 24 Nov 2021 09:16:19 +0000 Received: from hostingweb31-40.netsons.net ([89.40.174.40]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpoNz-004MhR-Aa for linux-arm-kernel@lists.infradead.org; Wed, 24 Nov 2021 09:16:17 +0000 Received: from [79.2.93.196] (port=52016 helo=[192.168.101.73]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mpoNw-0004yt-EW; Wed, 24 Nov 2021 10:16:12 +0100 Subject: Re: [PATCH v3 3/3] PCI: apple: Fix #PERST polarity To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, =?UTF-8?Q?Pali_Roh=c3=a1r?= , Alyssa Rosenzweig , Lorenzo Pieralisi , Bjorn Helgaas , Mark Kettenis , kernel-team@android.com References: <20211123180636.80558-1-maz@kernel.org> <20211123180636.80558-4-maz@kernel.org> <453389da-b041-94b3-009e-6c6323134936@lucaceresoli.net> <87fsrmc4e6.wl-maz@kernel.org> From: Luca Ceresoli Message-ID: Date: Wed, 24 Nov 2021 10:16:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <87fsrmc4e6.wl-maz@kernel.org> Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_011615_543003_393DADD1 X-CRM114-Status: GOOD ( 13.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiAyNC8xMS8yMSAxMDowMiwgTWFyYyBaeW5naWVyIHdyb3RlOgo+IE9uIFR1ZSwgMjMg Tm92IDIwMjEgMjE6MzY6MTEgKzAwMDAsCj4gTHVjYSBDZXJlc29saSA8bHVjYUBsdWNhY2VyZXNv bGkubmV0PiB3cm90ZToKPj4KPj4gSGkgTWFyaywKPj4KPj4gT24gMjMvMTEvMjEgMTk6MDYsIE1h cmMgWnluZ2llciB3cm90ZToKPj4+IE5vdyB0aGF0ICNQRVJTVCBpcyBwcm9wZXJseSBkZWZpbmVk IGFzIGFjdGl2ZS1sb3cgaW4gdGhlIGRldmljZSB0cmVlLAo+Pj4gZml4IHRoZSBkcml2ZXIgdG8g Y29ycmVjdGx5IGRyaXZlIHRoZSBsaW5lIGluZGVtZW5kZW50bHkgb2YgdGhlCj4+PiBpbXBsaWVk IHBvbGFyaXR5Lgo+Pj4KPj4+IEZpeGVzOiAxZTMzODg4ZmJlNDQgKCJQQ0k6IGFwcGxlOiBBZGQg aW5pdGlhbCBoYXJkd2FyZSBicmluZy11cCIpCj4+PiBTdWdnZXN0ZWQtYnk6IFBhbGkgUm9ow6Fy IDxwYWxpQGtlcm5lbC5vcmc+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIgPG1hekBr ZXJuZWwub3JnPgo+Pgo+PiBUaGFua3MgZm9yIHF1aWNrbHkgYWRkcmVzc2luZyB0aGlzIQo+Pgo+ PiBEbyB3ZSBuZWVkIGEgdHJhbnNpdGlvbiBwYXRoIGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5 IHdpdGggb2xkIERUcwo+PiBhbHJlYWR5IGFyb3VuZD8gU29tZXRoaW5nIGxpa2UgdGhpcyBbMF0u IFlvdSBzYWlkIFsxXSB0aGUgRFQgYWN0dWFsbHkKPj4gdXNlZCBpcyBub3QgZXZlbiB0aGUgb25l IGluIHRoZSBrZXJuZWwsIHRodXMgaG93IGRvIHdlIGd1YXJhbnRlZSBEVCBhbmQKPj4gZHJpdmVy IHN3aXRjaCB0byB0aGUgbmV3IHBvbGFyaXR5IGFsbCBhdCBvbmNlPwo+IAo+IE5vLiBBcyBpdCB0 dXJucyBvdXQsIG5laXRoZXIgdS1ib290IG5vciBPcGVuQlNEICh0aGUgb25seSB0d28gb3RoZXIK PiBwYXlsb2FkcyB0aGF0IGNhbiBib290IG9uIE0xKSBhcmUgdXBzdHJlYW1lZCB5ZXQuIFNvIHdl J3JlIHN0aWxsIGluCj4gdGhhdCBzdGFnZSB3aGVyZSB3ZSBkb24ndCBuZWVkIHRvIG1haW50YWlu IGJhY2t3YXJkIGNvbXBhdGliaWxpdHkuIElmCj4gd2UgZG9uJ3QgZ2V0IHRoaXMgcGF0Y2hlcyBt ZXJnZWQgYnkgdGhlIGVuZCBvZiB0aGlzIGN5Y2xlLCB3ZSB3aWxsCj4gaGF2ZSB0byByZXZpc2l0 IHRoaXMgdGhvdWdoLgoKR29vZCBuZXdzIQoKUmV2aWV3ZWQtYnk6IEx1Y2EgQ2VyZXNvbGkgPGx1 Y2FAbHVjYWNlcmVzb2xpLm5ldD4KCi0tIApMdWNhCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==