From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbeECHwr (ORCPT ); Thu, 3 May 2018 03:52:47 -0400 Received: from goliath.siemens.de ([192.35.17.28]:58901 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbeECHwn (ORCPT ); Thu, 3 May 2018 03:52:43 -0400 Subject: Re: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff To: Vladimir Zapolskiy , Bjorn Helgaas , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jingoo Han , Joao Pinto , Lorenzo Pieralisi , Will Deacon References: From: Jan Kiszka Message-ID: Date: Thu, 3 May 2018 09:52:16 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Vladimir, On 2018-05-03 09:12, Vladimir Zapolskiy wrote: > Hi Jan, > > On 04/30/2018 08:48 AM, Jan Kiszka wrote: >> Changes in v2: >> - patch 1: commit message reworking as suggested by Lorenzo >> - patch 3-6: split-up as suggested by Bjorn >> - patch 8: new >> - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than >> allowing manual choice, as suggested by Lorenzo >> >> This primarily enables to unbind the generic PCI host controller without >> leaving lots of memory leaks behind. A previous proposal patch 5 was >> rejected because of those issues [1]. >> >> The fixes have been validated in the Jailhouse setup, where we add and >> remove a virtual PCI host controller on hypervisor activation/ >> deactivation, with the help of kmemleak. > > by chance I was looking into a memleak in of_pci_get_host_bridge_resources(), > so I can give you a number of review tags. Thanks for the reviews and tests! And the pointer for the maintainers to the conflict around patch 7. > > FWIW the state of unfixably broken https://patchwork.kernel.org/patch/9662893/ > should be changed to obsoleted/deprecated/rejected. Indeed. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff To: Vladimir Zapolskiy , Bjorn Helgaas , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: From: Jan Kiszka Message-ID: Date: Thu, 3 May 2018 09:52:16 +0200 MIME-Version: 1.0 In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , Joao Pinto , Will Deacon , Lorenzo Pieralisi Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hey Vladimir, On 2018-05-03 09:12, Vladimir Zapolskiy wrote: > Hi Jan, > > On 04/30/2018 08:48 AM, Jan Kiszka wrote: >> Changes in v2: >> - patch 1: commit message reworking as suggested by Lorenzo >> - patch 3-6: split-up as suggested by Bjorn >> - patch 8: new >> - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than >> allowing manual choice, as suggested by Lorenzo >> >> This primarily enables to unbind the generic PCI host controller without >> leaving lots of memory leaks behind. A previous proposal patch 5 was >> rejected because of those issues [1]. >> >> The fixes have been validated in the Jailhouse setup, where we add and >> remove a virtual PCI host controller on hypervisor activation/ >> deactivation, with the help of kmemleak. > > by chance I was looking into a memleak in of_pci_get_host_bridge_resources(), > so I can give you a number of review tags. Thanks for the reviews and tests! And the pointer for the maintainers to the conflict around patch 7. > > FWIW the state of unfixably broken https://patchwork.kernel.org/patch/9662893/ > should be changed to obsoleted/deprecated/rejected. Indeed. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: jan.kiszka@siemens.com (Jan Kiszka) Date: Thu, 3 May 2018 09:52:16 +0200 Subject: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hey Vladimir, On 2018-05-03 09:12, Vladimir Zapolskiy wrote: > Hi Jan, > > On 04/30/2018 08:48 AM, Jan Kiszka wrote: >> Changes in v2: >> - patch 1: commit message reworking as suggested by Lorenzo >> - patch 3-6: split-up as suggested by Bjorn >> - patch 8: new >> - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than >> allowing manual choice, as suggested by Lorenzo >> >> This primarily enables to unbind the generic PCI host controller without >> leaving lots of memory leaks behind. A previous proposal patch 5 was >> rejected because of those issues [1]. >> >> The fixes have been validated in the Jailhouse setup, where we add and >> remove a virtual PCI host controller on hypervisor activation/ >> deactivation, with the help of kmemleak. > > by chance I was looking into a memleak in of_pci_get_host_bridge_resources(), > so I can give you a number of review tags. Thanks for the reviews and tests! And the pointer for the maintainers to the conflict around patch 7. > > FWIW the state of unfixably broken https://patchwork.kernel.org/patch/9662893/ > should be changed to obsoleted/deprecated/rejected. Indeed. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux