From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA7D3C433E2 for ; Mon, 7 Sep 2020 11:56:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79839207C3 for ; Mon, 7 Sep 2020 11:56:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="qHlnUduk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729077AbgIGL4q (ORCPT ); Mon, 7 Sep 2020 07:56:46 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:48037 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729166AbgIGLt7 (ORCPT ); Mon, 7 Sep 2020 07:49:59 -0400 Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20200907114934epoutp03e15cb2eb6f937405bb56a7a98b4b1fad~yfgReXRUs0310903109epoutp03w for ; Mon, 7 Sep 2020 11:49:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20200907114934epoutp03e15cb2eb6f937405bb56a7a98b4b1fad~yfgReXRUs0310903109epoutp03w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599479374; bh=JuJEikmWQ9aFfoxm8rT1yo9Xqd5OSbSLucviXZCpLU8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=qHlnUdukYTtW1xw4wQnzSIlKhcAr+z6SAaSBSTAzGzWy58eNkfnuyQQYwEe2W5ohr 0Ays4+pi1EBiVVz1XgUc2lVn9F5lzeQ7pwmDmIFmDbLykhEPu3AVwyJGPwF2fVlyja ao1IQ49vUi/f9FQYlqHN7AtRmAS7RhLDdtiI/0sA= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20200907114934epcas1p3ac102e5d964a9b8209008cec692e9914~yfgQ9iuNk2657026570epcas1p3i; Mon, 7 Sep 2020 11:49:34 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.40.152]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4BlRQh18YMzMqYkY; Mon, 7 Sep 2020 11:49:32 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id EE.AF.18978.B4E165F5; Mon, 7 Sep 2020 20:49:32 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20200907114930epcas1p4156f15f93e18b0824dc366033f9d82df~yfgN1-Dob1148911489epcas1p4a; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200907114930epsmtrp1a1d2cf27cd08ae880c50d6835a3b908d~yfgN1JghN3100631006epsmtrp1c; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) X-AuditID: b6c32a35-5edff70000004a22-dc-5f561e4bc92d Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id E1.0B.08382.A4E165F5; Mon, 7 Sep 2020 20:49:30 +0900 (KST) Received: from [10.113.111.64] (unknown [10.113.111.64]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200907114930epsmtip209df81b3885b5496fea475ad45e0b04c~yfgNizmuu1278912789epsmtip2y; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) Subject: Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline To: Maxime Ripard , Nicolas Saenz Julienne , Eric Anholt Cc: devicetree@vger.kernel.org, Tim Gover , Dave Stevenson , Stephen Boyd , Kamal Dasu , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org, Hoegeun Kwon From: Hoegeun Kwon Message-ID: Date: Mon, 7 Sep 2020 20:49:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 7bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJsWRmVeSWpSXmKPExsWy7bCmnq6PXFi8wfWljBZre4+yWLydu5jF Yv6Rc6wWV76+Z7M40HiZ0eL98i42i51X1rJYbHp8jdXi8q45bBYTb29gt5jx4x+jxbZZy9ks 1t16zWbRuvcIu8W/axtZLB5Nvc/oIODR9P4Ym8es+2fZPO6cO8/msXPWXXaPTas62Tzudx9n 8ti8pN6j9egvFo++LasYPTafrvb4vEkugDsq2yYjNTEltUghNS85PyUzL91WyTs43jne1MzA UNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6B8lhbLEnFKgUEBicbGSvp1NUX5pSapCRn5xia1SakFK ToFlgV5xYm5xaV66XnJ+rpWhgYGRKVBhQnZG74P1TAVzBCrO/njE2sB4m6eLkZNDQsBE4nn/ Q2YQW0hgB6NEe4N5FyMXkP2JUeLKu79MEM43Rolr/7exwXTce7aCBSKxF6jj2gso5y2jxNqV U1m7GDk4hAXcJRo2mYM0iAiUS7R37gdbwSzwnFni2EVOEJtNQFfia891JhCbV8BO4sbRw2A2 i4CKxO+Ox+wgtqhApMTOpy/ZIWoEJU7OfMICYnMKpEqsWHYAaqa8xPa3c6BscYlbT+aDXS0h 8IND4vP2XVBXu0g8urOPGcIWlnh1fAs7hC0l8bK/Dcoulrgy8xULRHMDo0T/xNlQCWOJ/Usn M4E8xiygKbF+lz5EWFFi5++5jBCL+STefe0B+11CgFeio00IokRN4lnDAVYIW0biVO9yJgjb Q2LVwWfMExgVZyF5bRaSd2YheWcWwuIFjCyrGMVSC4pz01OLDQsMkSN7EyM4qWuZ7mCc+PaD 3iFGJg7GQ4wSHMxKIrxdh0LjhXhTEiurUovy44tKc1KLDzGaAgN7IrOUaHI+MK/klcQbmhoZ GxtbmBiamRoaKonzPrylEC8kkJ5YkpqdmlqQWgTTx8TBKdXAFJj3e9I0+d9Ns0Qm6f0y3xbL t2R1x6RFvGonG3O+NTDszHy+baKV3u8Go1Cfe9a5XCf05/UaFG6Tmh/E6tGitXc5+/5SyxgD 0ehujobijTUl5l+YuV0npLyq/Fnx6fl1z7XOB7YtXvqt/4urTZpXQWdKlNaGizYMl7v1zmx6 +13qqO/BGLn5ou5flv+dIHP5yOJX/4NeNOzxtFiR1Rj6Rts51OHb5M1Pktb2bVl29MVFiXnn zOSuJaz3M516dv0HnmirJ7kZ/qm/Z0VfmaR/dvMBJYk3G+ovhJt+nMQcWqN02DL+zLlJqkX3 9JuKTl08NH2G59kkhvnyutyfN8VoHRVRm3f2/nPfqsrwzrgbXEosxRmJhlrMRcWJAJ1RhF1z BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWy7bCSvK6XXFi8wa2j5hZre4+yWLydu5jF Yv6Rc6wWV76+Z7M40HiZ0eL98i42i51X1rJYbHp8jdXi8q45bBYTb29gt5jx4x+jxbZZy9ks 1t16zWbRuvcIu8W/axtZLB5Nvc/oIODR9P4Ym8es+2fZPO6cO8/msXPWXXaPTas62Tzudx9n 8ti8pN6j9egvFo++LasYPTafrvb4vEkugDuKyyYlNSezLLVI3y6BK6P3wXqmgjkCFWd/PGJt YLzN08XIySEhYCJx79kKli5GLg4hgd2MEtuOfWCDSMhIrOrfwtrFyAFkC0scPlwMUfOaUWL+ jQPsIHFhAXeJhk3mIOUiApUSn+fsYgapYRZ4zixxYc97JoiGHYwSLw5cZQSpYhPQlfjac50J xOYVsJO4cfQwmM0ioCLxu+Mx2FBRgUiJnTssIUoEJU7OfMICYnMKpEqsWHaAGcRmFjCTmLf5 IZQtL7H97RwoW1zi1pP5TBMYhWYhaZ+FpGUWkpZZSFoWMLKsYpRMLSjOTc8tNiwwzEst1ytO zC0uzUvXS87P3cQIjmMtzR2M21d90DvEyMTBeIhRgoNZSYS361BovBBvSmJlVWpRfnxRaU5q 8SFGaQ4WJXHeG4UL44QE0hNLUrNTUwtSi2CyTBycUg1M7W6C91iztvVWVeQ8ebDX6T3DFnf2 qt5VJgtFJWdstlVkq8tQP7XhgcqdttbqtN/3Jl/Qqf4x8ajLmbeb2w9WpGpudS0PX711MrvS otPOti8+rV/22yTx6FvponJzTz8vtZcm0ao8PpNfqekrzZWb/+mn3PRzHD+Ul1xT51u+mZun ZFPDw2sqf++9m/u07md0LE+yO6N9Vem1enMrjwrNid/2rPu98Jhl/ao5wfN9UlNZKplmqHpL P779PKhuq90l69cXyq5+bd6+lffJb/kpi9ut6/t5H13R/uzAdpfDJ/GgWtihVUUBHBy7ugSb X+ee8jPeeiVZUfm082y2u2ZhZdn1CXMaOjguF16fW3tLiaU4I9FQi7moOBEAIfEHLFIDAAA= X-CMS-MailID: 20200907114930epcas1p4156f15f93e18b0824dc366033f9d82df X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200904071259epcas1p3de4209531c0bc5ed6ea9ef19827b6ed5 References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On 9/3/20 5:00 PM, Maxime Ripard wrote: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that there's > more pixelvalve now. Those pixelvalve come with a mux in the HVS that still > have only 3 FIFOs. Both of those differences are breaking a bunch of > expectations in the driver, so we first need a good bunch of cleanup and > reworks to introduce support for the new controllers. > > Similarly, the HDMI controller has all its registers shuffled and split in > multiple controllers now, so we need a bunch of changes to support this as > well. > > Only the HDMI support is enabled for now (even though the DPI and DSI > outputs have been tested too). > > Let me know if you have any comments > Maxime > > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: devicetree@vger.kernel.org > Cc: Kamal Dasu > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Stephen Boyd > > Changes from v4: > - Rebased on top of next-20200828 > - Collected the various tags > - Fixed some issues with 4k support and dual output (thanks Hoegeun!) Thanks for your v5 patchset. I tested all patches based on the next-20200812. Everything else is fine, but the dual hdmi modetest doesn't work well in my environment... In my environment, dsi is not connected, I have seen your answer[1]. Do you have any other settings? For example in config.txt. [1] https://lkml.org/lkml/2020/9/2/566 > - Fixed typos in commit logs (thanks Dave!) > - Split the csc setup hook into its own patch again > - Added the CEC clock to the DT binding > - Fixed the DT binding example > - Reduced the number of calls to of_device_is_compatible in vc4_kms_load > - Added back the check for the state commit in our commit hook Best regards, Hoegeun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91734C433E2 for ; Mon, 7 Sep 2020 11:51:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30ECB207C3 for ; Mon, 7 Sep 2020 11:51:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iDwdG1jW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="qHlnUduk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30ECB207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:MIME-Version:Date:Message-ID: From:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U6RBteJdJVhaXJtuLHBGiyPRoRniSUVFuBekbgX+dKg=; b=iDwdG1jWhSFlM9G+45qF6I6/P Z7VvCZeE36H1hRk481wO0NMBeyU7NV/+0YzH7X6CR5FIzZKMg4PsaJZ0r63Wk3nf4WjV5fvKGOZVq j2w7zwnPoM6kRBF0nVbM53QT7CXoY1JoMM25EML8TXWWtTVUYwLGXf/d7HCBt4fXFwMLFVD7YuLOB M7vJbZ8LU2u+dWbUCXGX7sNY+lOmJrlrv/shdUrtLEubifnJ6cVHeyVVBQG83eL2VxyyvSAVq2GPe RFJqJzM7vS6mDmRvTaNzB5cqiaq1Tins3r+ZTJvNrR6MfuEOfVhujijBiy8CLHQao5FSdiV2JuyoA fzolQ/ypQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFFeZ-0002qF-0n; Mon, 07 Sep 2020 11:49:43 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFFeU-0002oI-Kp for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 11:49:40 +0000 Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20200907114934epoutp01eb5d4cc1888046c130297ddf9ae416e5~yfgRX4XPd0696806968epoutp01h for ; Mon, 7 Sep 2020 11:49:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20200907114934epoutp01eb5d4cc1888046c130297ddf9ae416e5~yfgRX4XPd0696806968epoutp01h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599479374; bh=JuJEikmWQ9aFfoxm8rT1yo9Xqd5OSbSLucviXZCpLU8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=qHlnUdukYTtW1xw4wQnzSIlKhcAr+z6SAaSBSTAzGzWy58eNkfnuyQQYwEe2W5ohr 0Ays4+pi1EBiVVz1XgUc2lVn9F5lzeQ7pwmDmIFmDbLykhEPu3AVwyJGPwF2fVlyja ao1IQ49vUi/f9FQYlqHN7AtRmAS7RhLDdtiI/0sA= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20200907114934epcas1p3ac102e5d964a9b8209008cec692e9914~yfgQ9iuNk2657026570epcas1p3i; Mon, 7 Sep 2020 11:49:34 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.40.152]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4BlRQh18YMzMqYkY; Mon, 7 Sep 2020 11:49:32 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id EE.AF.18978.B4E165F5; Mon, 7 Sep 2020 20:49:32 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20200907114930epcas1p4156f15f93e18b0824dc366033f9d82df~yfgN1-Dob1148911489epcas1p4a; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200907114930epsmtrp1a1d2cf27cd08ae880c50d6835a3b908d~yfgN1JghN3100631006epsmtrp1c; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) X-AuditID: b6c32a35-5edff70000004a22-dc-5f561e4bc92d Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id E1.0B.08382.A4E165F5; Mon, 7 Sep 2020 20:49:30 +0900 (KST) Received: from [10.113.111.64] (unknown [10.113.111.64]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200907114930epsmtip209df81b3885b5496fea475ad45e0b04c~yfgNizmuu1278912789epsmtip2y; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) Subject: Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline To: Maxime Ripard , Nicolas Saenz Julienne , Eric Anholt From: Hoegeun Kwon Message-ID: Date: Mon, 7 Sep 2020 20:49:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJsWRmVeSWpSXmKPExsWy7bCmnq6PXFi8wfWljBZre4+yWLydu5jF Yv6Rc6wWV76+Z7M40HiZ0eL98i42i51X1rJYbHp8jdXi8q45bBYTb29gt5jx4x+jxbZZy9ks 1t16zWbRuvcIu8W/axtZLB5Nvc/oIODR9P4Ym8es+2fZPO6cO8/msXPWXXaPTas62Tzudx9n 8ti8pN6j9egvFo++LasYPTafrvb4vEkugDsq2yYjNTEltUghNS85PyUzL91WyTs43jne1MzA UNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6B8lhbLEnFKgUEBicbGSvp1NUX5pSapCRn5xia1SakFK ToFlgV5xYm5xaV66XnJ+rpWhgYGRKVBhQnZG74P1TAVzBCrO/njE2sB4m6eLkZNDQsBE4nn/ Q2YQW0hgB6NEe4N5FyMXkP2JUeLKu79MEM43Rolr/7exwXTce7aCBSKxF6jj2gso5y2jxNqV U1m7GDk4hAXcJRo2mYM0iAiUS7R37gdbwSzwnFni2EVOEJtNQFfia891JhCbV8BO4sbRw2A2 i4CKxO+Ox+wgtqhApMTOpy/ZIWoEJU7OfMICYnMKpEqsWHYAaqa8xPa3c6BscYlbT+aDXS0h 8IND4vP2XVBXu0g8urOPGcIWlnh1fAs7hC0l8bK/Dcoulrgy8xULRHMDo0T/xNlQCWOJ/Usn M4E8xiygKbF+lz5EWFFi5++5jBCL+STefe0B+11CgFeio00IokRN4lnDAVYIW0biVO9yJgjb Q2LVwWfMExgVZyF5bRaSd2YheWcWwuIFjCyrGMVSC4pz01OLDQsMkSN7EyM4qWuZ7mCc+PaD 3iFGJg7GQ4wSHMxKIrxdh0LjhXhTEiurUovy44tKc1KLDzGaAgN7IrOUaHI+MK/klcQbmhoZ GxtbmBiamRoaKonzPrylEC8kkJ5YkpqdmlqQWgTTx8TBKdXAFJj3e9I0+d9Ns0Qm6f0y3xbL t2R1x6RFvGonG3O+NTDszHy+baKV3u8Go1Cfe9a5XCf05/UaFG6Tmh/E6tGitXc5+/5SyxgD 0ehujobijTUl5l+YuV0npLyq/Fnx6fl1z7XOB7YtXvqt/4urTZpXQWdKlNaGizYMl7v1zmx6 +13qqO/BGLn5ou5flv+dIHP5yOJX/4NeNOzxtFiR1Rj6Rts51OHb5M1Pktb2bVl29MVFiXnn zOSuJaz3M516dv0HnmirJ7kZ/qm/Z0VfmaR/dvMBJYk3G+ovhJt+nMQcWqN02DL+zLlJqkX3 9JuKTl08NH2G59kkhvnyutyfN8VoHRVRm3f2/nPfqsrwzrgbXEosxRmJhlrMRcWJAJ1RhF1z BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWy7bCSvK6XXFi8wa2j5hZre4+yWLydu5jF Yv6Rc6wWV76+Z7M40HiZ0eL98i42i51X1rJYbHp8jdXi8q45bBYTb29gt5jx4x+jxbZZy9ks 1t16zWbRuvcIu8W/axtZLB5Nvc/oIODR9P4Ym8es+2fZPO6cO8/msXPWXXaPTas62Tzudx9n 8ti8pN6j9egvFo++LasYPTafrvb4vEkugDuKyyYlNSezLLVI3y6BK6P3wXqmgjkCFWd/PGJt YLzN08XIySEhYCJx79kKli5GLg4hgd2MEtuOfWCDSMhIrOrfwtrFyAFkC0scPlwMUfOaUWL+ jQPsIHFhAXeJhk3mIOUiApUSn+fsYgapYRZ4zixxYc97JoiGHYwSLw5cZQSpYhPQlfjac50J xOYVsJO4cfQwmM0ioCLxu+Mx2FBRgUiJnTssIUoEJU7OfMICYnMKpEqsWHaAGcRmFjCTmLf5 IZQtL7H97RwoW1zi1pP5TBMYhWYhaZ+FpGUWkpZZSFoWMLKsYpRMLSjOTc8tNiwwzEst1ytO zC0uzUvXS87P3cQIjmMtzR2M21d90DvEyMTBeIhRgoNZSYS361BovBBvSmJlVWpRfnxRaU5q 8SFGaQ4WJXHeG4UL44QE0hNLUrNTUwtSi2CyTBycUg1M7W6C91iztvVWVeQ8ebDX6T3DFnf2 qt5VJgtFJWdstlVkq8tQP7XhgcqdttbqtN/3Jl/Qqf4x8ajLmbeb2w9WpGpudS0PX711MrvS otPOti8+rV/22yTx6FvponJzTz8vtZcm0ao8PpNfqekrzZWb/+mn3PRzHD+Ul1xT51u+mZun ZFPDw2sqf++9m/u07md0LE+yO6N9Vem1enMrjwrNid/2rPu98Jhl/ao5wfN9UlNZKplmqHpL P779PKhuq90l69cXyq5+bd6+lffJb/kpi9ut6/t5H13R/uzAdpfDJ/GgWtihVUUBHBy7ugSb X+ee8jPeeiVZUfm082y2u2ZhZdn1CXMaOjguF16fW3tLiaU4I9FQi7moOBEAIfEHLFIDAAA= X-CMS-MailID: 20200907114930epcas1p4156f15f93e18b0824dc366033f9d82df X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200904071259epcas1p3de4209531c0bc5ed6ea9ef19827b6ed5 References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_074939_219073_7EDC7B07 X-CRM114-Status: GOOD ( 30.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tim Gover , Kamal Dasu , Stephen Boyd , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hoegeun Kwon , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On 9/3/20 5:00 PM, Maxime Ripard wrote: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that there's > more pixelvalve now. Those pixelvalve come with a mux in the HVS that still > have only 3 FIFOs. Both of those differences are breaking a bunch of > expectations in the driver, so we first need a good bunch of cleanup and > reworks to introduce support for the new controllers. > > Similarly, the HDMI controller has all its registers shuffled and split in > multiple controllers now, so we need a bunch of changes to support this as > well. > > Only the HDMI support is enabled for now (even though the DPI and DSI > outputs have been tested too). > > Let me know if you have any comments > Maxime > > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: devicetree@vger.kernel.org > Cc: Kamal Dasu > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Stephen Boyd > > Changes from v4: > - Rebased on top of next-20200828 > - Collected the various tags > - Fixed some issues with 4k support and dual output (thanks Hoegeun!) Thanks for your v5 patchset. I tested all patches based on the next-20200812. Everything else is fine, but the dual hdmi modetest doesn't work well in my environment... In my environment, dsi is not connected, I have seen your answer[1]. Do you have any other settings? For example in config.txt. [1] https://lkml.org/lkml/2020/9/2/566 > - Fixed typos in commit logs (thanks Dave!) > - Split the csc setup hook into its own patch again > - Added the CEC clock to the DT binding > - Fixed the DT binding example > - Reduced the number of calls to of_device_is_compatible in vc4_kms_load > - Added back the check for the state commit in our commit hook Best regards, Hoegeun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2195C43461 for ; Mon, 7 Sep 2020 11:49:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23E15207C3 for ; Mon, 7 Sep 2020 11:49:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="qHlnUduk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23E15207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53CBE6E301; Mon, 7 Sep 2020 11:49:38 +0000 (UTC) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C1EF6E301 for ; Mon, 7 Sep 2020 11:49:37 +0000 (UTC) Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20200907114934epoutp03bf3d2c79f8d9b59049b56202a2b6ab57~yfgRX4Wcl0143501435epoutp03h for ; Mon, 7 Sep 2020 11:49:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20200907114934epoutp03bf3d2c79f8d9b59049b56202a2b6ab57~yfgRX4Wcl0143501435epoutp03h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599479374; bh=JuJEikmWQ9aFfoxm8rT1yo9Xqd5OSbSLucviXZCpLU8=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=qHlnUdukYTtW1xw4wQnzSIlKhcAr+z6SAaSBSTAzGzWy58eNkfnuyQQYwEe2W5ohr 0Ays4+pi1EBiVVz1XgUc2lVn9F5lzeQ7pwmDmIFmDbLykhEPu3AVwyJGPwF2fVlyja ao1IQ49vUi/f9FQYlqHN7AtRmAS7RhLDdtiI/0sA= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20200907114934epcas1p3ac102e5d964a9b8209008cec692e9914~yfgQ9iuNk2657026570epcas1p3i; Mon, 7 Sep 2020 11:49:34 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.40.152]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4BlRQh18YMzMqYkY; Mon, 7 Sep 2020 11:49:32 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id EE.AF.18978.B4E165F5; Mon, 7 Sep 2020 20:49:32 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20200907114930epcas1p4156f15f93e18b0824dc366033f9d82df~yfgN1-Dob1148911489epcas1p4a; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200907114930epsmtrp1a1d2cf27cd08ae880c50d6835a3b908d~yfgN1JghN3100631006epsmtrp1c; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) X-AuditID: b6c32a35-5edff70000004a22-dc-5f561e4bc92d Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id E1.0B.08382.A4E165F5; Mon, 7 Sep 2020 20:49:30 +0900 (KST) Received: from [10.113.111.64] (unknown [10.113.111.64]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200907114930epsmtip209df81b3885b5496fea475ad45e0b04c~yfgNizmuu1278912789epsmtip2y; Mon, 7 Sep 2020 11:49:30 +0000 (GMT) Subject: Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline To: Maxime Ripard , Nicolas Saenz Julienne , Eric Anholt From: Hoegeun Kwon Message-ID: Date: Mon, 7 Sep 2020 20:49:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAJsWRmVeSWpSXmKPExsWy7bCmnq6PXFi8wfWljBZre4+yWLydu5jF Yv6Rc6wWV76+Z7M40HiZ0eL98i42i51X1rJYbHp8jdXi8q45bBYTb29gt5jx4x+jxbZZy9ks 1t16zWbRuvcIu8W/axtZLB5Nvc/oIODR9P4Ym8es+2fZPO6cO8/msXPWXXaPTas62Tzudx9n 8ti8pN6j9egvFo++LasYPTafrvb4vEkugDsq2yYjNTEltUghNS85PyUzL91WyTs43jne1MzA UNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6B8lhbLEnFKgUEBicbGSvp1NUX5pSapCRn5xia1SakFK ToFlgV5xYm5xaV66XnJ+rpWhgYGRKVBhQnZG74P1TAVzBCrO/njE2sB4m6eLkZNDQsBE4nn/ Q2YQW0hgB6NEe4N5FyMXkP2JUeLKu79MEM43Rolr/7exwXTce7aCBSKxF6jj2gso5y2jxNqV U1m7GDk4hAXcJRo2mYM0iAiUS7R37gdbwSzwnFni2EVOEJtNQFfia891JhCbV8BO4sbRw2A2 i4CKxO+Ox+wgtqhApMTOpy/ZIWoEJU7OfMICYnMKpEqsWHYAaqa8xPa3c6BscYlbT+aDXS0h 8IND4vP2XVBXu0g8urOPGcIWlnh1fAs7hC0l8bK/Dcoulrgy8xULRHMDo0T/xNlQCWOJ/Usn M4E8xiygKbF+lz5EWFFi5++5jBCL+STefe0B+11CgFeio00IokRN4lnDAVYIW0biVO9yJgjb Q2LVwWfMExgVZyF5bRaSd2YheWcWwuIFjCyrGMVSC4pz01OLDQsMkSN7EyM4qWuZ7mCc+PaD 3iFGJg7GQ4wSHMxKIrxdh0LjhXhTEiurUovy44tKc1KLDzGaAgN7IrOUaHI+MK/klcQbmhoZ GxtbmBiamRoaKonzPrylEC8kkJ5YkpqdmlqQWgTTx8TBKdXAFJj3e9I0+d9Ns0Qm6f0y3xbL t2R1x6RFvGonG3O+NTDszHy+baKV3u8Go1Cfe9a5XCf05/UaFG6Tmh/E6tGitXc5+/5SyxgD 0ehujobijTUl5l+YuV0npLyq/Fnx6fl1z7XOB7YtXvqt/4urTZpXQWdKlNaGizYMl7v1zmx6 +13qqO/BGLn5ou5flv+dIHP5yOJX/4NeNOzxtFiR1Rj6Rts51OHb5M1Pktb2bVl29MVFiXnn zOSuJaz3M516dv0HnmirJ7kZ/qm/Z0VfmaR/dvMBJYk3G+ovhJt+nMQcWqN02DL+zLlJqkX3 9JuKTl08NH2G59kkhvnyutyfN8VoHRVRm3f2/nPfqsrwzrgbXEosxRmJhlrMRcWJAJ1RhF1z BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsWy7bCSvK6XXFi8wa2j5hZre4+yWLydu5jF Yv6Rc6wWV76+Z7M40HiZ0eL98i42i51X1rJYbHp8jdXi8q45bBYTb29gt5jx4x+jxbZZy9ks 1t16zWbRuvcIu8W/axtZLB5Nvc/oIODR9P4Ym8es+2fZPO6cO8/msXPWXXaPTas62Tzudx9n 8ti8pN6j9egvFo++LasYPTafrvb4vEkugDuKyyYlNSezLLVI3y6BK6P3wXqmgjkCFWd/PGJt YLzN08XIySEhYCJx79kKli5GLg4hgd2MEtuOfWCDSMhIrOrfwtrFyAFkC0scPlwMUfOaUWL+ jQPsIHFhAXeJhk3mIOUiApUSn+fsYgapYRZ4zixxYc97JoiGHYwSLw5cZQSpYhPQlfjac50J xOYVsJO4cfQwmM0ioCLxu+Mx2FBRgUiJnTssIUoEJU7OfMICYnMKpEqsWHaAGcRmFjCTmLf5 IZQtL7H97RwoW1zi1pP5TBMYhWYhaZ+FpGUWkpZZSFoWMLKsYpRMLSjOTc8tNiwwzEst1ytO zC0uzUvXS87P3cQIjmMtzR2M21d90DvEyMTBeIhRgoNZSYS361BovBBvSmJlVWpRfnxRaU5q 8SFGaQ4WJXHeG4UL44QE0hNLUrNTUwtSi2CyTBycUg1M7W6C91iztvVWVeQ8ebDX6T3DFnf2 qt5VJgtFJWdstlVkq8tQP7XhgcqdttbqtN/3Jl/Qqf4x8ajLmbeb2w9WpGpudS0PX711MrvS otPOti8+rV/22yTx6FvponJzTz8vtZcm0ao8PpNfqekrzZWb/+mn3PRzHD+Ul1xT51u+mZun ZFPDw2sqf++9m/u07md0LE+yO6N9Vem1enMrjwrNid/2rPu98Jhl/ao5wfN9UlNZKplmqHpL P779PKhuq90l69cXyq5+bd6+lffJb/kpi9ut6/t5H13R/uzAdpfDJ/GgWtihVUUBHBy7ugSb X+ee8jPeeiVZUfm082y2u2ZhZdn1CXMaOjguF16fW3tLiaU4I9FQi7moOBEAIfEHLFIDAAA= X-CMS-MailID: 20200907114930epcas1p4156f15f93e18b0824dc366033f9d82df X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200904071259epcas1p3de4209531c0bc5ed6ea9ef19827b6ed5 References: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tim Gover , Kamal Dasu , Stephen Boyd , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hoegeun Kwon , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, On 9/3/20 5:00 PM, Maxime Ripard wrote: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that there's > more pixelvalve now. Those pixelvalve come with a mux in the HVS that still > have only 3 FIFOs. Both of those differences are breaking a bunch of > expectations in the driver, so we first need a good bunch of cleanup and > reworks to introduce support for the new controllers. > > Similarly, the HDMI controller has all its registers shuffled and split in > multiple controllers now, so we need a bunch of changes to support this as > well. > > Only the HDMI support is enabled for now (even though the DPI and DSI > outputs have been tested too). > > Let me know if you have any comments > Maxime > > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: devicetree@vger.kernel.org > Cc: Kamal Dasu > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Stephen Boyd > > Changes from v4: > - Rebased on top of next-20200828 > - Collected the various tags > - Fixed some issues with 4k support and dual output (thanks Hoegeun!) Thanks for your v5 patchset. I tested all patches based on the next-20200812. Everything else is fine, but the dual hdmi modetest doesn't work well in my environment... In my environment, dsi is not connected, I have seen your answer[1]. Do you have any other settings? For example in config.txt. [1] https://lkml.org/lkml/2020/9/2/566 > - Fixed typos in commit logs (thanks Dave!) > - Split the csc setup hook into its own patch again > - Added the CEC clock to the DT binding > - Fixed the DT binding example > - Reduced the number of calls to of_device_is_compatible in vc4_kms_load > - Added back the check for the state commit in our commit hook Best regards, Hoegeun _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel