All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leigh Fiddes <leigh.fiddes@atomos.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Linux Bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: [Proposed Patch Bluez v5] btmon: Print connection latency correctly
Date: Fri, 19 Aug 2016 22:01:01 +1000	[thread overview]
Message-ID: <ccb0c2f9-0643-4030-3111-93f4d36f5b4e@atomos.com> (raw)
In-Reply-To: <35A91F39-E5C2-47F2-81D5-398797B31C1C@holtmann.org>

Hi Marcel,

> Hi Leigh,
>
>> I submit the following small patch for consideration.
>> Leigh
>> ---
>>
>> In at least two places the Connection Latency field was being displayed by btmon in units of 1.25mS,
>> which is incorrect. Print in decimal instead of hex as it is a number.
> then print the connection latency with a correct unit and the hex value in parentheses. This way is not acceptable. If we need a print_field_msec helper, then introduce that and use it throughout.
>
> Regards
>
> Marcel
>
Thank you for the quick response.
I think there may be a misunderstanding here. In these LE messages, the 
Connection Latency is not a time unit. It is a count of the number of
Connection messages from the Host that the Peripheral can ignore if the 
Peripheral has no new data to send at that time.
Since it is just a count, printing the same value in both decimal and 
hex is a stylistic decision.
Regards,
Leigh

      reply	other threads:[~2016-08-19 12:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19  7:00 [Proposed Patch Bluez v5] btmon: Print connection latency correctly Leigh Fiddes
2016-08-19  8:49 ` Marcel Holtmann
2016-08-19 12:01   ` Leigh Fiddes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccb0c2f9-0643-4030-3111-93f4d36f5b4e@atomos.com \
    --to=leigh.fiddes@atomos.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.