From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn83s-0006Bj-B9 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:50:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn83r-0007V6-CI for qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:50:00 -0400 References: From: Eric Blake Message-ID: Date: Wed, 30 Aug 2017 13:49:39 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CHchxNXHR9XVOaNg0WgjegUM4guPfJoNs" Subject: Re: [Qemu-devel] [PATCH v3 5/5] qemu-iotests: add option to save temp files on error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, armbru@redhat.com, jsnow@redhat.com, stefanha@redhat.com, kwolf@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CHchxNXHR9XVOaNg0WgjegUM4guPfJoNs From: Eric Blake To: Jeff Cody , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, armbru@redhat.com, jsnow@redhat.com, stefanha@redhat.com, kwolf@redhat.com Message-ID: Subject: Re: [PATCH v3 5/5] qemu-iotests: add option to save temp files on error References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/30/2017 11:52 AM, Jeff Cody wrote: > Now that ./check takes care of cleaning up after each tests, it > can also selectively not clean up. Add option to leave all output from= > tests intact if that test encountered an error. >=20 > Note: this currently only works for bash tests, as the python tests > still clean up after themselves manually. >=20 > Signed-off-by: Jeff Cody > --- > tests/qemu-iotests/check | 10 +++++++++- > tests/qemu-iotests/common | 6 ++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index f6ca85d..8a5fc0d 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -370,7 +370,15 @@ do > fi > fi > =20 > - rm -rf "$TEST_DIR_SEQ" > + #TODO: There is some intial work to save intermediate files s/intial/initial/ > + # in python tests, but it is imperfect. Having each > + # test record its test name, and the tearDown function > + # just move intermediate images to a subdirectory with > + # the test name may prove more useful. Comment works for me, and I'm fine with the idea you present here being in a followup patch. So with the typo fixed, Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --CHchxNXHR9XVOaNg0WgjegUM4guPfJoNs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlmnCMMACgkQp6FrSiUn Q2qD0Af+KWeWscBI9Rc87EWMF8vZZyFd6aFcFFrYgbLsHVY1IAwfFs48oPn0D7Nf zE1/JBHocXeXC/WsEe99fptiq23u91sjGK3irs9iBO9edgKbNpxmVKhxRLmS/z6B MSWOQZ9f7rhaN8Q/kLjNTtU7uOv83wJSkYAvqjON4CA7uId0cx9lWVVyxZqcb3jy yq5b7htVyEdgg/G7wngLD9vuLHrKsjb93352VbpBN/3jWKCtIPNS2clKR/UKUjLT K/81dikts42UR0oHyZee7HIyxGXhlY36wUwkpM4Cf4ngogsmruWGO5xdiG1btATV Yvrp2HsXwoe2UJG6ZpjINBOOuPS+eQ== =Bsft -----END PGP SIGNATURE----- --CHchxNXHR9XVOaNg0WgjegUM4guPfJoNs--