From: osalvador@suse.de
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
pavel.tatashin@microsoft.com, jglisse@redhat.com,
Jonathan.Cameron@huawei.com, rafael@kernel.org, david@redhat.com,
linux-mm@kvack.org, owner-linux-mm@kvack.org
Subject: Re: [PATCH v2 5/5] mm, memory_hotplug: Refactor shrink_zone/pgdat_span
Date: Wed, 28 Nov 2018 17:02:42 +0100 [thread overview]
Message-ID: <ccb78b1cf7879017f52f1803956f5e91@suse.de> (raw)
In-Reply-To: <20181128155030.GM6923@dhcp22.suse.cz>
>> Maybe that is fine, I am not sure.
>> Sorry for looping here, but it is being difficult for me to grasp it.
>
> OK, so let me try again. What is the difference for a pfn walker to
> start at an offline pfn start from any other offlined section withing a
> zone boundary? I believe there is none because the pfn walker needs to
> skip over offline pfns anyway whether they start at a zone boundary or
> not.
If the pfn walker in question skips over "invalid" (not online) pfn,
then we
are fine I guess.
But we need to make sure that this is the case, and that we do not have
someone
relaying on zone_start_pfn and trusting it blindly.
I will go through the code and check all cases to be sure that this is
not the case.
If that is the case, then I am fine with getting rid of the shrink code.
Thanks for explanations ;-)
next prev parent reply other threads:[~2018-11-28 16:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 16:20 [PATCH v2 0/5] Do not touch pages in hot-remove path Oscar Salvador
2018-11-27 16:20 ` [PATCH v2 1/5] mm, memory_hotplug: Add nid parameter to arch_remove_memory Oscar Salvador
2018-11-27 16:20 ` [PATCH v2 2/5] kernel, resource: Check for IORESOURCE_SYSRAM in release_mem_region_adjustable Oscar Salvador
2018-11-27 16:20 ` [PATCH v2 3/5] mm, memory_hotplug: Move zone/pages handling to offline stage Oscar Salvador
2018-11-28 7:52 ` Mike Rapoport
2018-11-28 14:25 ` osalvador
2018-11-28 14:15 ` osalvador
2018-11-27 16:20 ` [PATCH v2 4/5] mm, memory-hotplug: Rework unregister_mem_sect_under_nodes Oscar Salvador
2019-03-24 6:48 ` Anshuman Khandual
2019-03-25 7:40 ` Oscar Salvador
2019-03-25 8:04 ` Michal Hocko
2019-03-25 8:14 ` Oscar Salvador
2018-11-27 16:20 ` [PATCH v2 5/5] mm, memory_hotplug: Refactor shrink_zone/pgdat_span Oscar Salvador
2018-11-28 6:50 ` Michal Hocko
2018-11-28 7:07 ` Oscar Salvador
2018-11-28 10:03 ` David Hildenbrand
2018-11-28 10:14 ` Michal Hocko
2018-11-28 11:00 ` osalvador
2018-11-28 12:31 ` Michal Hocko
2018-11-28 12:51 ` osalvador
2018-11-28 13:08 ` Michal Hocko
2018-11-28 13:18 ` osalvador
2018-11-28 15:50 ` Michal Hocko
2018-11-28 16:02 ` osalvador [this message]
2018-11-29 9:29 ` osalvador
2018-11-28 13:09 ` osalvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccb78b1cf7879017f52f1803956f5e91@suse.de \
--to=osalvador@suse.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=owner-linux-mm@kvack.org \
--cc=pavel.tatashin@microsoft.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.