From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E10CC433F5 for ; Tue, 22 Feb 2022 16:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231835AbiBVQXH (ORCPT ); Tue, 22 Feb 2022 11:23:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230295AbiBVQXH (ORCPT ); Tue, 22 Feb 2022 11:23:07 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C960F166A79 for ; Tue, 22 Feb 2022 08:22:40 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id p15so44404693ejc.7 for ; Tue, 22 Feb 2022 08:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=q+My118MVhW0Ye9CMLkqYiEKe4aBqZcoI39IWD/unS0=; b=pvMkvfXmaWSL7HS+xyy70n9lAtmMhkhp+Jv4oA1m2QpPzXv/iYiXcfNPEOBK3UHrdu AcFAf9Vu4GROep7TFHJdx0oIKb9yS3mbcQsEfvwTPdXC85jYtebb5Y3eE8g7PblKZtff vhsXPa+P6Laor3KIqmlDIXP4ZnNQnvPlObzz5Bha+8gSbykpJ0/LmaNIoasnEnx6vIxV dNbRfINs+qEt6FR58bm02ESK81QDBF+5CXjTcYhbO6kp/+buXU/Id6CONuiqGTI/czfW OIYIrQANVyDwdZZu4dTZnNEntLm31ytjfg9GKeSaTBT+ZN8ZYK6IntvkT4/27q46dNQ3 rnpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=q+My118MVhW0Ye9CMLkqYiEKe4aBqZcoI39IWD/unS0=; b=r+ToBHUmx6c34eg+lTwsWrG5cqwDijK+CPwjnvOpDQPuw+FP0NtUrSwm9tt1Cs2iBA 0Y7XghplyRtDjL69ngF4Ftn3nFsdB+Eya42f9E+6Rg1HryY8fL2whU/axYLig+ItvUCp 95fjVmBtWLC1PcUA39JzVHQ72pmjbBH89PKeRwVVJdnsQRA0kJA8EUI4U+RdT+yEYL3B 223Jy2Eygdtq26LqbApPOreP0yC0DcPB9jMg2KXelP1jk6HoPFK+Gw6N2VCKfsDS2vGX Z9T+lLGwHuT9Kk9JL+bphYhjZpbJnrjTSIMv1yjrFSNiB400rwyHkoVAFlsI/IgqN2TV GluA== X-Gm-Message-State: AOAM532Lh8TPzWfanHg6eG0HflOAhrCS50CfLIadUOEQhvSIpGzClbLa 425vY2ugo6rzr1k7vkyT3vs= X-Google-Smtp-Source: ABdhPJxiZ/YD4QrnfvYntsavdPaFU6LgVRlEu7GPEQWh6CYDpnyjl3dRdGyKtloVvE5gVvg7045uuQ== X-Received: by 2002:a17:906:b04:b0:6bd:bf71:ed08 with SMTP id u4-20020a1709060b0400b006bdbf71ed08mr20337601ejg.585.1645546959316; Tue, 22 Feb 2022 08:22:39 -0800 (PST) Received: from ?IPV6:2a02:908:1252:fb60:21b6:6d72:8af6:ec7c? ([2a02:908:1252:fb60:21b6:6d72:8af6:ec7c]) by smtp.gmail.com with ESMTPSA id m17sm6385797ejq.22.2022.02.22.08.22.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Feb 2022 08:22:38 -0800 (PST) Message-ID: Date: Tue, 22 Feb 2022 17:22:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] PCI: Apply quirk_amd_harvest_no_ats to all navi10 and 14 asics Content-Language: en-US To: Alex Deucher , amd-gfx@lists.freedesktop.org, bhelgaas@google.com, linux-pci@vger.kernel.org References: <20220222160801.841643-1-alexander.deucher@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: <20220222160801.841643-1-alexander.deucher@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Am 22.02.22 um 17:08 schrieb Alex Deucher: > There are enough vbios escapes without the proper workaround > that some users still hit this. MS never productized ATS on > windows so OEM platforms that were windows only didn't always > validate ATS. > > The advantages of ATS are not worth it compared to the potential > instabilities on harvested boards. Just disable ATS on all navi10 > and 14 boards. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1760 > Signed-off-by: Alex Deucher Acked-by: Christian König > --- > drivers/pci/quirks.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 003950c738d2..ea2de1616510 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -5341,11 +5341,6 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0422, quirk_no_ext_tags); > */ > static void quirk_amd_harvest_no_ats(struct pci_dev *pdev) > { > - if ((pdev->device == 0x7312 && pdev->revision != 0x00) || > - (pdev->device == 0x7340 && pdev->revision != 0xc5) || > - (pdev->device == 0x7341 && pdev->revision != 0x00)) > - return; > - > if (pdev->device == 0x15d8) { > if (pdev->revision == 0xcf && > pdev->subsystem_vendor == 0xea50 && > @@ -5367,10 +5362,19 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x98e4, quirk_amd_harvest_no_ats); > /* AMD Iceland dGPU */ > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x6900, quirk_amd_harvest_no_ats); > /* AMD Navi10 dGPU */ > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7310, quirk_amd_harvest_no_ats); > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7312, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7318, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7319, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x731a, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x731b, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x731e, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x731f, quirk_amd_harvest_no_ats); > /* AMD Navi14 dGPU */ > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7340, quirk_amd_harvest_no_ats); > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7341, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x7347, quirk_amd_harvest_no_ats); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x734f, quirk_amd_harvest_no_ats); > /* AMD Raven platform iGPU */ > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x15d8, quirk_amd_harvest_no_ats); > #endif /* CONFIG_PCI_ATS */