From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbdDLLBc (ORCPT ); Wed, 12 Apr 2017 07:01:32 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:50071 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbdDLLB3 (ORCPT ); Wed, 12 Apr 2017 07:01:29 -0400 Subject: Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property To: Laurent Pinchart , dri-devel@lists.freedesktop.org References: <20170211184858.26421-1-noralf@tronnes.org> <20170211184858.26421-6-noralf@tronnes.org> <1802283.9kerWUhyh6@avalon> Cc: devicetree@vger.kernel.org, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Wed, 12 Apr 2017 13:01:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1802283.9kerWUhyh6@avalon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 11.04.2017 07.29, skrev Laurent Pinchart: > Hi Noralf, > > On Saturday 11 Feb 2017 19:48:56 Noralf Trønnes wrote: >> Display panels can be oriented many ways, especially in the embedded >> world. The rotation property is a way to describe this orientation. >> The counter clockwise direction is chosen because that's what fbdev >> and drm use. >> >> Signed-off-by: Noralf Trønnes >> Acked-by: Thierry Reding >> --- >> >> Changes since version 3: >> - Changed display/display.txt -> display/panel/panel.txt >> >> Documentation/devicetree/bindings/display/panel/panel.txt | 4 ++++ > We now have both Documentation/devicetree/bindings/display/panel/panel.txt and > Documentation/devicetree/bindings/display/panel/panel-common.txt as they have > been merged concurrently without being aware of each other. Would you mind if > I moved this property to panel-common.txt ? Not at all, please do. > I would also like to document the property in a bit more details to avoid > confusion about the rotation direction, as "display rotation" could be > interpreted as the angle by which the display output has to be rotated to > obtain an upside-up image. What would you think of the following, am I > overdoing it, or is it even more confusing ? I was more confused at least :-) It's not important to me what the actual wording is, but I see that I have used the word 'Display' which should have been 'Panel'. Noralf. > - rotation: Panels are commonly mounted rotated, with their native orientation > not aligned with the device's orientation. The rotation property specifies the > angle in degrees between the panel's orientation and the device's orientation > (corresponding to a counter-clockwise rotation of the panel). Valid values are > 0, 90, 180 and 270. > > >> 1 file changed, 4 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/panel/panel.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/panel.txt >> b/Documentation/devicetree/bindings/display/panel/panel.txt new file mode >> 100644 >> index 0000000..e2e6867 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/panel.txt >> @@ -0,0 +1,4 @@ >> +Common display properties >> +------------------------- >> + >> +- rotation: Display rotation in degrees counter clockwise (0,90,180,270) From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property Date: Wed, 12 Apr 2017 13:01:21 +0200 Message-ID: References: <20170211184858.26421-1-noralf@tronnes.org> <20170211184858.26421-6-noralf@tronnes.org> <1802283.9kerWUhyh6@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1802283.9kerWUhyh6@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: thomas.petazzoni@free-electrons.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org CkRlbiAxMS4wNC4yMDE3IDA3LjI5LCBza3JldiBMYXVyZW50IFBpbmNoYXJ0Ogo+IEhpIE5vcmFs ZiwKPgo+IE9uIFNhdHVyZGF5IDExIEZlYiAyMDE3IDE5OjQ4OjU2IE5vcmFsZiBUcsO4bm5lcyB3 cm90ZToKPj4gRGlzcGxheSBwYW5lbHMgY2FuIGJlIG9yaWVudGVkIG1hbnkgd2F5cywgZXNwZWNp YWxseSBpbiB0aGUgZW1iZWRkZWQKPj4gd29ybGQuIFRoZSByb3RhdGlvbiBwcm9wZXJ0eSBpcyBh IHdheSB0byBkZXNjcmliZSB0aGlzIG9yaWVudGF0aW9uLgo+PiBUaGUgY291bnRlciBjbG9ja3dp c2UgZGlyZWN0aW9uIGlzIGNob3NlbiBiZWNhdXNlIHRoYXQncyB3aGF0IGZiZGV2Cj4+IGFuZCBk cm0gdXNlLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9u bmVzLm9yZz4KPj4gQWNrZWQtYnk6IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+ Cj4+IC0tLQo+Pgo+PiBDaGFuZ2VzIHNpbmNlIHZlcnNpb24gMzoKPj4gLSBDaGFuZ2VkIGRpc3Bs YXkvZGlzcGxheS50eHQgLT4gZGlzcGxheS9wYW5lbC9wYW5lbC50eHQKPj4KPj4gICBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9wYW5lbC50eHQgfCA0ICsr KysKPiBXZSBub3cgaGF2ZSBib3RoIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9k aXNwbGF5L3BhbmVsL3BhbmVsLnR4dCBhbmQKPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9wYW5lbC9wYW5lbC1jb21tb24udHh0IGFzIHRoZXkgaGF2ZQo+IGJlZW4g bWVyZ2VkIGNvbmN1cnJlbnRseSB3aXRob3V0IGJlaW5nIGF3YXJlIG9mIGVhY2ggb3RoZXIuIFdv dWxkIHlvdSBtaW5kIGlmCj4gSSBtb3ZlZCB0aGlzIHByb3BlcnR5IHRvIHBhbmVsLWNvbW1vbi50 eHQgPwoKTm90IGF0IGFsbCwgcGxlYXNlIGRvLgoKPiBJIHdvdWxkIGFsc28gbGlrZSB0byBkb2N1 bWVudCB0aGUgcHJvcGVydHkgaW4gYSBiaXQgbW9yZSBkZXRhaWxzIHRvIGF2b2lkCj4gY29uZnVz aW9uIGFib3V0IHRoZSByb3RhdGlvbiBkaXJlY3Rpb24sIGFzICJkaXNwbGF5IHJvdGF0aW9uIiBj b3VsZCBiZQo+IGludGVycHJldGVkIGFzIHRoZSBhbmdsZSBieSB3aGljaCB0aGUgZGlzcGxheSBv dXRwdXQgaGFzIHRvIGJlIHJvdGF0ZWQgdG8KPiBvYnRhaW4gYW4gdXBzaWRlLXVwIGltYWdlLiBX aGF0IHdvdWxkIHlvdSB0aGluayBvZiB0aGUgZm9sbG93aW5nLCBhbSBJCj4gb3ZlcmRvaW5nIGl0 LCBvciBpcyBpdCBldmVuIG1vcmUgY29uZnVzaW5nID8KCkkgd2FzIG1vcmUgY29uZnVzZWQgYXQg bGVhc3QgOi0pCkl0J3Mgbm90IGltcG9ydGFudCB0byBtZSB3aGF0IHRoZSBhY3R1YWwgd29yZGlu ZyBpcywgYnV0IEkgc2VlIHRoYXQgSQpoYXZlIHVzZWQgdGhlIHdvcmQgJ0Rpc3BsYXknIHdoaWNo IHNob3VsZCBoYXZlIGJlZW4gJ1BhbmVsJy4KCk5vcmFsZi4KCj4gLSByb3RhdGlvbjogUGFuZWxz IGFyZSBjb21tb25seSBtb3VudGVkIHJvdGF0ZWQsIHdpdGggdGhlaXIgbmF0aXZlIG9yaWVudGF0 aW9uCj4gbm90IGFsaWduZWQgd2l0aCB0aGUgZGV2aWNlJ3Mgb3JpZW50YXRpb24uIFRoZSByb3Rh dGlvbiBwcm9wZXJ0eSBzcGVjaWZpZXMgdGhlCj4gYW5nbGUgaW4gZGVncmVlcyBiZXR3ZWVuIHRo ZSBwYW5lbCdzIG9yaWVudGF0aW9uIGFuZCB0aGUgZGV2aWNlJ3Mgb3JpZW50YXRpb24KPiAoY29y cmVzcG9uZGluZyB0byBhIGNvdW50ZXItY2xvY2t3aXNlIHJvdGF0aW9uIG9mIHRoZSBwYW5lbCku IFZhbGlkIHZhbHVlcyBhcmUKPiAwLCA5MCwgMTgwIGFuZCAyNzAuCj4KPgo+PiAgIDEgZmlsZSBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKykKPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQKPj4gRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvcGFuZWwudHh0Cj4+Cj4+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9w YW5lbC9wYW5lbC50eHQKPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlz cGxheS9wYW5lbC9wYW5lbC50eHQgbmV3IGZpbGUgbW9kZQo+PiAxMDA2NDQKPj4gaW5kZXggMDAw MDAwMC4uZTJlNjg2Nwo+PiAtLS0gL2Rldi9udWxsCj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3BhbmVsLnR4dAo+PiBAQCAtMCwwICsxLDQg QEAKPj4gK0NvbW1vbiBkaXNwbGF5IHByb3BlcnRpZXMKPj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPj4gKwo+PiArLSByb3RhdGlvbjoJRGlzcGxheSByb3RhdGlvbiBpbiBkZWdyZWVzIGNv dW50ZXIgY2xvY2t3aXNlICgwLDkwLDE4MCwyNzApCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK