From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 076D9C11F68 for ; Thu, 8 Jul 2021 17:38:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E547C6192C for ; Thu, 8 Jul 2021 17:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbhGHRlN (ORCPT ); Thu, 8 Jul 2021 13:41:13 -0400 Received: from smtprelay0011.hostedemail.com ([216.40.44.11]:46104 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229815AbhGHRlM (ORCPT ); Thu, 8 Jul 2021 13:41:12 -0400 Received: from omf16.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id A11C1180A9C98; Thu, 8 Jul 2021 17:38:29 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA id 3C77425511A; Thu, 8 Jul 2021 17:38:28 +0000 (UTC) Message-ID: Subject: Re: [PATCH net-next v2] drivers: net: Follow the indentation coding standard on printks From: Joe Perches To: Carlos Bilbao , davem@davemloft.net Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, gregkh@linuxfoundation.org Date: Thu, 08 Jul 2021 10:38:26 -0700 In-Reply-To: <5183009.Sb9uPGUboI@iron-maiden> References: <1884900.usQuhbGJ8B@iron-maiden> <03ad1f2319a608bbfe3fc09e901742455bf733a0.camel@perches.com> <5183009.Sb9uPGUboI@iron-maiden> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: 4r8o453uawndmydoihpe9mb65adrwyw8 X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: 3C77425511A X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18aO+OxNVt0tR2tBbw9r7VAFqEi8lL67G4= X-HE-Tag: 1625765908-184590 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-07-08 at 13:33 -0400, Carlos Bilbao wrote: > Fix indentation of printks that start at the beginning of the line. Change this > for the right number of space characters, or tabs if the file uses them. You are touching 2 different drivers and this should really be 2 separate patches. > diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c.rej b/drivers/net/ethernet/dec/tulip/de4x5.c.rej [] > +++ b/drivers/net/ethernet/dec/tulip/de4x5.c.rej > @@ -0,0 +1,11 @@ > +--- drivers/net/ethernet/dec/tulip/de4x5.c > ++++ drivers/net/ethernet/dec/tulip/de4x5.c > +@@ -3169,7 +3169,7 @@ dc2114x_autoconf(struct net_device *dev) > + > + default: > + lp->tcount++; > +-printk("Huh?: media:%02x\n", lp->media); > ++ printk("Huh?: media:%02x\n", lp->media); > + lp->media = INIT; > + break; > + } This is an interdiff that should not be part of this change.