All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] remove qemu-options* from root directory
Date: Tue, 18 May 2021 12:33:29 +0200	[thread overview]
Message-ID: <ccfae3ab-e05a-7860-a841-f2aac0169c89@redhat.com> (raw)
In-Reply-To: <875yzg776s.fsf@dusky.pond.sub.org>

On 18/05/21 10:54, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
>> These headers are also included from softmmu/vl.c, so they should be
>> in include/.  Removing qemu-options-wrapper.h, since elsewhere
>> we include "template" headers directly and #define the parameters in
>> the including file, and move qemu-options.h to include/.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>   qemu-options.h => include/qemu/qemu-options.h |  9 ++++-
>>   os-posix.c                                    |  2 +-
>>   os-win32.c                                    |  1 -
>>   qemu-options-wrapper.h                        | 40 -------------------
>>   qemu-options.hx                               |  4 ++
>>   softmmu/vl.c                                  | 24 ++++++++---
>>   6 files changed, 31 insertions(+), 49 deletions(-)
>>   rename qemu-options.h => include/qemu/qemu-options.h (88%)
>>   delete mode 100644 qemu-options-wrapper.h
> 
> Much nicer without qemu-options-wrapper.h.
> 
> I'd be tempted to rename qemu-options.def while there (what's .def?),
> but that's up to you.
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

I was tempted too, but qemu-options.h is already taken (well, 
qemu/qemu-options.h) and I didn't have any good ideas about the name.

Paolo



  reply	other threads:[~2021-05-18 10:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 12:19 [PATCH] remove qemu-options* from root directory Paolo Bonzini
2021-05-17 12:27 ` no-reply
2021-05-18  8:54 ` Markus Armbruster
2021-05-18 10:33   ` Paolo Bonzini [this message]
2021-05-18 10:57     ` Markus Armbruster
2021-05-18 12:30       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccfae3ab-e05a-7860-a841-f2aac0169c89@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.