From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B70BCA9EC3 for ; Tue, 29 Oct 2019 17:20:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25D312067D for ; Tue, 29 Oct 2019 17:20:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kMvDAfqN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390752AbfJ2RUA (ORCPT ); Tue, 29 Oct 2019 13:20:00 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42174 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390744AbfJ2RUA (ORCPT ); Tue, 29 Oct 2019 13:20:00 -0400 Received: by mail-wr1-f65.google.com with SMTP id a15so2263979wrf.9 for ; Tue, 29 Oct 2019 10:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=kMvDAfqNMsgwLVSlQz2HGv5SXkrMFIA/sC5PQVA0qHCk2uNpr3vgteNY32KO6XolN9 jrYaAZAZBspll0O/IT//xBGYiWDFZD8KU1uPmY2vK3KPsyhTb7mzyGHCGTLByQgbXpOx OeloXmN2vq/6bG5ZHNwG845uL6ZvA2Sdmd4uYMZ4E+4NJ7wccdnycw840yvcV4FBt6VL /xrA8JLUiBY/5hX+ugxid7ZLni4gqfgl/j7jRF06f5phYKlyiq6OI+yIzaRotZfKsIyc R7JU0GMg+/jruClJEMts6SYQJZeL4C+Qp1GS1gxReNthE6HvcZsnnoBEcT3avouO/n1H WYQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=D2Xu/1BwYb28of9oBY4/Q5vniZw1rnGyEuKA1LM8X0sauhU+nGvLWm/OhY5GKDb5dr fdAw/rYofM7Mn68cqlZAZ9MKWB5tg0lzUdUCCO739hR3b58mACdbdaZeJPoCwzP/DWkz +iy3wqnJyO8RyiNKLopNNo49oF3UCPeixU11JLbH1amNw/NLfesWGkGDlad+BcgIx44e BBNJXQic+5Jouu8Dx7tqvC1E1TrwHWBsSoGsJxx7YEmub0cCazgaquBBbv8PBiOZt4Y8 vDT1YEwd+cr2TOU4BSozEV9nyKqMFyy2v1V56cywdm/93KdXnBIGnqcR98a1HcjgKAdz ZxIA== X-Gm-Message-State: APjAAAVfFaRpXRo30FqCZ5l5leJws4mjZvHGBwJzZXzCboJLhxpHCren 1HG4oLCXdKs3g2UzqNQoM4g= X-Google-Smtp-Source: APXvYqyE7qwpgL7KV62AOaDM+oFRQdWcTDjdZKuljhwWYaRRqCfiSc2s9/fNi7ZWZZwXl8hUkkgUgA== X-Received: by 2002:adf:ef0a:: with SMTP id e10mr20205293wro.234.1572369597497; Tue, 29 Oct 2019 10:19:57 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id f8sm3544088wmb.37.2019.10.29.10.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2019 10:19:56 -0700 (PDT) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem To: "Kuehling, Felix" , Jason Gunthorpe , "linux-mm@kvack.org" , Jerome Glisse , Ralph Campbell , John Hubbard Cc: Juergen Gross , "Zhou, David(ChunMing)" , Mike Marciniszyn , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma@vger.kernel.org" , "nouveau@lists.freedesktop.org" , Dennis Dalessandro , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Jason Gunthorpe , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" , "xen-devel@lists.xenproject.org" , Boris Ostrovsky , Petr Cvek , "Koenig, Christian" , Ben Skeggs References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-13-jgg@ziepe.ca> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Tue, 29 Oct 2019 14:07:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Am 29.10.19 um 17:28 schrieb Kuehling, Felix: > On 2019-10-28 4:10 p.m., Jason Gunthorpe wrote: >> From: Jason Gunthorpe >> >> find_vma() must be called under the mmap_sem, reorganize this code to >> do the vma check after entering the lock. >> >> Further, fix the unlocked use of struct task_struct's mm, instead use >> the mm from hmm_mirror which has an active mm_grab. Also the mm_grab >> must be converted to a mm_get before acquiring mmap_sem or calling >> find_vma(). >> >> Fixes: 66c45500bfdc ("drm/amdgpu: use new HMM APIs and helpers") >> Fixes: 0919195f2b0d ("drm/amdgpu: Enable amdgpu_ttm_tt_get_user_pages in worker threads") >> Cc: Alex Deucher >> Cc: Christian König >> Cc: David (ChunMing) Zhou >> Cc: amd-gfx@lists.freedesktop.org >> Signed-off-by: Jason Gunthorpe > One question inline to confirm my understanding. Otherwise this patch is > > Reviewed-by: Felix Kuehling > > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 37 ++++++++++++++----------- >> 1 file changed, 21 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> index dff41d0a85fe96..c0e41f1f0c2365 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> @@ -35,6 +35,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -788,7 +789,7 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages) >> struct hmm_mirror *mirror = bo->mn ? &bo->mn->mirror : NULL; >> struct ttm_tt *ttm = bo->tbo.ttm; >> struct amdgpu_ttm_tt *gtt = (void *)ttm; >> - struct mm_struct *mm = gtt->usertask->mm; >> + struct mm_struct *mm; >> unsigned long start = gtt->userptr; >> struct vm_area_struct *vma; >> struct hmm_range *range; >> @@ -796,25 +797,14 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages) >> uint64_t *pfns; >> int r = 0; >> >> - if (!mm) /* Happens during process shutdown */ >> - return -ESRCH; >> - >> if (unlikely(!mirror)) { >> DRM_DEBUG_DRIVER("Failed to get hmm_mirror\n"); >> - r = -EFAULT; >> - goto out; >> + return -EFAULT; >> } >> >> - vma = find_vma(mm, start); >> - if (unlikely(!vma || start < vma->vm_start)) { >> - r = -EFAULT; >> - goto out; >> - } >> - if (unlikely((gtt->userflags & AMDGPU_GEM_USERPTR_ANONONLY) && >> - vma->vm_file)) { >> - r = -EPERM; >> - goto out; >> - } >> + mm = mirror->hmm->mmu_notifier.mm; >> + if (!mmget_not_zero(mm)) /* Happens during process shutdown */ > This works because mirror->hmm->mmu_notifier holds an mmgrab reference > to the mm? So the MM will not just go away, but if the mmget refcount is > 0, it means the mm is marked for destruction and shouldn't be used any more. Yes, exactly. That is a rather common pattern, one reference count for the functionality and one for the structure. When the functionality is gone the structure might still be alive for some reason. TTM and a couple of other structures use the same approach. Christian. > > >> + return -ESRCH; >> >> range = kzalloc(sizeof(*range), GFP_KERNEL); >> if (unlikely(!range)) { >> @@ -847,6 +837,17 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages) >> hmm_range_wait_until_valid(range, HMM_RANGE_DEFAULT_TIMEOUT); >> >> down_read(&mm->mmap_sem); >> + vma = find_vma(mm, start); >> + if (unlikely(!vma || start < vma->vm_start)) { >> + r = -EFAULT; >> + goto out_unlock; >> + } >> + if (unlikely((gtt->userflags & AMDGPU_GEM_USERPTR_ANONONLY) && >> + vma->vm_file)) { >> + r = -EPERM; >> + goto out_unlock; >> + } >> + >> r = hmm_range_fault(range, 0); >> up_read(&mm->mmap_sem); >> >> @@ -865,15 +866,19 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages) >> } >> >> gtt->range = range; >> + mmput(mm); >> >> return 0; >> >> +out_unlock: >> + up_read(&mm->mmap_sem); >> out_free_pfns: >> hmm_range_unregister(range); >> kvfree(pfns); >> out_free_ranges: >> kfree(range); >> out: >> + mmput(mm); >> return r; >> } >> > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem Date: Tue, 29 Oct 2019 14:07:37 +0100 Message-ID: References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-13-jgg@ziepe.ca> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Kuehling, Felix" , Jason Gunthorpe , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , Jerome Glisse , Ralph Campbell , John Hubbard Cc: Juergen Gross , "Zhou, David(ChunMing)" , Mike Marciniszyn , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Dennis Dalessandro , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Christoph Hellwig , Jason Gunthorpe , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Deucher, Alexander" , "xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org" , Boris Ostrovsky , Petr Cvek , "Koenig, Christian" , Ben Skeggs List-Id: nouveau.vger.kernel.org QW0gMjkuMTAuMTkgdW0gMTc6Mjggc2NocmllYiBLdWVobGluZywgRmVsaXg6Cj4gT24gMjAxOS0x MC0yOCA0OjEwIHAubS4sIEphc29uIEd1bnRob3JwZSB3cm90ZToKPj4gRnJvbTogSmFzb24gR3Vu dGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+Pgo+PiBmaW5kX3ZtYSgpIG11c3QgYmUgY2FsbGVk IHVuZGVyIHRoZSBtbWFwX3NlbSwgcmVvcmdhbml6ZSB0aGlzIGNvZGUgdG8KPj4gZG8gdGhlIHZt YSBjaGVjayBhZnRlciBlbnRlcmluZyB0aGUgbG9jay4KPj4KPj4gRnVydGhlciwgZml4IHRoZSB1 bmxvY2tlZCB1c2Ugb2Ygc3RydWN0IHRhc2tfc3RydWN0J3MgbW0sIGluc3RlYWQgdXNlCj4+IHRo ZSBtbSBmcm9tIGhtbV9taXJyb3Igd2hpY2ggaGFzIGFuIGFjdGl2ZSBtbV9ncmFiLiBBbHNvIHRo ZSBtbV9ncmFiCj4+IG11c3QgYmUgY29udmVydGVkIHRvIGEgbW1fZ2V0IGJlZm9yZSBhY3F1aXJp bmcgbW1hcF9zZW0gb3IgY2FsbGluZwo+PiBmaW5kX3ZtYSgpLgo+Pgo+PiBGaXhlczogNjZjNDU1 MDBiZmRjICgiZHJtL2FtZGdwdTogdXNlIG5ldyBITU0gQVBJcyBhbmQgaGVscGVycyIpCj4+IEZp eGVzOiAwOTE5MTk1ZjJiMGQgKCJkcm0vYW1kZ3B1OiBFbmFibGUgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyBpbiB3b3JrZXIgdGhyZWFkcyIpCj4+IENjOiBBbGV4IERldWNoZXIgPGFsZXhh bmRlci5kZXVjaGVyQGFtZC5jb20+Cj4+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4u a29lbmlnQGFtZC5jb20+Cj4+IENjOiBEYXZpZCAoQ2h1bk1pbmcpIFpob3UgPERhdmlkMS5aaG91 QGFtZC5jb20+Cj4+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBTaWduZWQt b2ZmLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4gT25lIHF1ZXN0aW9u IGlubGluZSB0byBjb25maXJtIG15IHVuZGVyc3RhbmRpbmcuIE90aGVyd2lzZSB0aGlzIHBhdGNo IGlzCj4KPiBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5j b20+Cj4KPgo+PiAtLS0KPj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0 bS5jIHwgMzcgKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+PiAgICAxIGZpbGUgY2hhbmdlZCwg MjEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdHRtLmMKPj4gaW5kZXggZGZmNDFkMGE4NWZlOTYuLmMwZTQxZjFmMGMy MzY1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRt LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4+IEBA IC0zNSw2ICszNSw3IEBACj4+ICAgICNpbmNsdWRlIDxsaW51eC9obW0uaD4KPj4gICAgI2luY2x1 ZGUgPGxpbnV4L3BhZ2VtYXAuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NjaGVkL3Rhc2suaD4K Pj4gKyNpbmNsdWRlIDxsaW51eC9zY2hlZC9tbS5oPgo+PiAgICAjaW5jbHVkZSA8bGludXgvc2Vx X2ZpbGUuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPj4gICAgI2luY2x1ZGUgPGxp bnV4L3N3YXAuaD4KPj4gQEAgLTc4OCw3ICs3ODksNyBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyhzdHJ1Y3QgYW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4g ICAgCXN0cnVjdCBobW1fbWlycm9yICptaXJyb3IgPSBiby0+bW4gPyAmYm8tPm1uLT5taXJyb3Ig OiBOVUxMOwo+PiAgICAJc3RydWN0IHR0bV90dCAqdHRtID0gYm8tPnRiby50dG07Cj4+ICAgIAlz dHJ1Y3QgYW1kZ3B1X3R0bV90dCAqZ3R0ID0gKHZvaWQgKil0dG07Cj4+IC0Jc3RydWN0IG1tX3N0 cnVjdCAqbW0gPSBndHQtPnVzZXJ0YXNrLT5tbTsKPj4gKwlzdHJ1Y3QgbW1fc3RydWN0ICptbTsK Pj4gICAgCXVuc2lnbmVkIGxvbmcgc3RhcnQgPSBndHQtPnVzZXJwdHI7Cj4+ICAgIAlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYTsKPj4gICAgCXN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlOwo+PiBA QCAtNzk2LDI1ICs3OTcsMTQgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMoc3Ry dWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAl1aW50NjRfdCAq cGZuczsKPj4gICAgCWludCByID0gMDsKPj4gICAgCj4+IC0JaWYgKCFtbSkgLyogSGFwcGVucyBk dXJpbmcgcHJvY2VzcyBzaHV0ZG93biAqLwo+PiAtCQlyZXR1cm4gLUVTUkNIOwo+PiAtCj4+ICAg IAlpZiAodW5saWtlbHkoIW1pcnJvcikpIHsKPj4gICAgCQlEUk1fREVCVUdfRFJJVkVSKCJGYWls ZWQgdG8gZ2V0IGhtbV9taXJyb3JcbiIpOwo+PiAtCQlyID0gLUVGQVVMVDsKPj4gLQkJZ290byBv dXQ7Cj4+ICsJCXJldHVybiAtRUZBVUxUOwo+PiAgICAJfQo+PiAgICAKPj4gLQl2bWEgPSBmaW5k X3ZtYShtbSwgc3RhcnQpOwo+PiAtCWlmICh1bmxpa2VseSghdm1hIHx8IHN0YXJ0IDwgdm1hLT52 bV9zdGFydCkpIHsKPj4gLQkJciA9IC1FRkFVTFQ7Cj4+IC0JCWdvdG8gb3V0Owo+PiAtCX0KPj4g LQlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FOT05P TkxZKSAmJgo+PiAtCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+IC0JCXIgPSAtRVBFUk07Cj4+IC0JCWdv dG8gb3V0Owo+PiAtCX0KPj4gKwltbSA9IG1pcnJvci0+aG1tLT5tbXVfbm90aWZpZXIubW07Cj4+ ICsJaWYgKCFtbWdldF9ub3RfemVybyhtbSkpIC8qIEhhcHBlbnMgZHVyaW5nIHByb2Nlc3Mgc2h1 dGRvd24gKi8KPiBUaGlzIHdvcmtzIGJlY2F1c2UgbWlycm9yLT5obW0tPm1tdV9ub3RpZmllciBo b2xkcyBhbiBtbWdyYWIgcmVmZXJlbmNlCj4gdG8gdGhlIG1tPyBTbyB0aGUgTU0gd2lsbCBub3Qg anVzdCBnbyBhd2F5LCBidXQgaWYgdGhlIG1tZ2V0IHJlZmNvdW50IGlzCj4gMCwgaXQgbWVhbnMg dGhlIG1tIGlzIG1hcmtlZCBmb3IgZGVzdHJ1Y3Rpb24gYW5kIHNob3VsZG4ndCBiZSB1c2VkIGFu eSBtb3JlLgoKWWVzLCBleGFjdGx5LiBUaGF0IGlzIGEgcmF0aGVyIGNvbW1vbiBwYXR0ZXJuLCBv bmUgcmVmZXJlbmNlIGNvdW50IGZvciAKdGhlIGZ1bmN0aW9uYWxpdHkgYW5kIG9uZSBmb3IgdGhl IHN0cnVjdHVyZS4KCldoZW4gdGhlIGZ1bmN0aW9uYWxpdHkgaXMgZ29uZSB0aGUgc3RydWN0dXJl IG1pZ2h0IHN0aWxsIGJlIGFsaXZlIGZvciAKc29tZSByZWFzb24uIFRUTSBhbmQgYSBjb3VwbGUg b2Ygb3RoZXIgc3RydWN0dXJlcyB1c2UgdGhlIHNhbWUgYXBwcm9hY2guCgpDaHJpc3RpYW4uCgo+ Cj4KPj4gKwkJcmV0dXJuIC1FU1JDSDsKPj4gICAgCj4+ICAgIAlyYW5nZSA9IGt6YWxsb2Moc2l6 ZW9mKCpyYW5nZSksIEdGUF9LRVJORUwpOwo+PiAgICAJaWYgKHVubGlrZWx5KCFyYW5nZSkpIHsK Pj4gQEAgLTg0Nyw2ICs4MzcsMTcgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMo c3RydWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAlobW1fcmFu Z2Vfd2FpdF91bnRpbF92YWxpZChyYW5nZSwgSE1NX1JBTkdFX0RFRkFVTFRfVElNRU9VVCk7Cj4+ ICAgIAo+PiAgICAJZG93bl9yZWFkKCZtbS0+bW1hcF9zZW0pOwo+PiArCXZtYSA9IGZpbmRfdm1h KG1tLCBzdGFydCk7Cj4+ICsJaWYgKHVubGlrZWx5KCF2bWEgfHwgc3RhcnQgPCB2bWEtPnZtX3N0 YXJ0KSkgewo+PiArCQlyID0gLUVGQVVMVDsKPj4gKwkJZ290byBvdXRfdW5sb2NrOwo+PiArCX0K Pj4gKwlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FO T05PTkxZKSAmJgo+PiArCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+ICsJCXIgPSAtRVBFUk07Cj4+ICsJ CWdvdG8gb3V0X3VubG9jazsKPj4gKwl9Cj4+ICsKPj4gICAgCXIgPSBobW1fcmFuZ2VfZmF1bHQo cmFuZ2UsIDApOwo+PiAgICAJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsKPj4gICAgCj4+IEBAIC04 NjUsMTUgKzg2NiwxOSBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRfdXNlcl9wYWdlcyhzdHJ1Y3Qg YW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4gICAgCX0KPj4gICAgCj4+ICAg IAlndHQtPnJhbmdlID0gcmFuZ2U7Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAKPj4gICAgCXJldHVy biAwOwo+PiAgICAKPj4gK291dF91bmxvY2s6Cj4+ICsJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsK Pj4gICAgb3V0X2ZyZWVfcGZuczoKPj4gICAgCWhtbV9yYW5nZV91bnJlZ2lzdGVyKHJhbmdlKTsK Pj4gICAgCWt2ZnJlZShwZm5zKTsKPj4gICAgb3V0X2ZyZWVfcmFuZ2VzOgo+PiAgICAJa2ZyZWUo cmFuZ2UpOwo+PiAgICBvdXQ6Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAJcmV0dXJuIHI7Cj4+ICAg IH0KPj4gICAgCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4 IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F25CA9EAE for ; Tue, 29 Oct 2019 17:20:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EED220856 for ; Tue, 29 Oct 2019 17:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EED220856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8365B6EC50; Tue, 29 Oct 2019 17:20:00 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id C88EE6EC4F; Tue, 29 Oct 2019 17:19:58 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id s1so14578830wro.0; Tue, 29 Oct 2019 10:19:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=S8hKaTz2G6pztg0JMTKZOTO4zP8wIcoSzmrsuB25x51JUb/xRmmKGJpWXzplNd9r6c Umk4q+UM6CatUexvnS0ClpzoxuinMymGe+fZHDl5xfiT1SBcoxpg2M6lkex8Dgs3qa4B 2W9R4H2YRiq85J4XMhmEGmBzwhMTAwKN6IOxPAL+PGcKeFNXbiClxFd9Z4/+1sAKaG0h Mx+RaLF9NPga4sBmwDWQV/w1eW35ajCfuuauUnxsrFAVc/ahoUvnbBaFobrDs3XuuVUk ouQHwnGjx5FbfHt1kbbkLVTP67a0IpDqDIv3AesmCnB15MqrkXoCux5F7TFDfFHIamWH vKnQ== X-Gm-Message-State: APjAAAVWdzQ5vAd3pviHoCaZLY5BjLj1y4wmL2a/uitOUIx41hNCYtKw IwgMGNr4adLFlJj6F1TDVGE= X-Google-Smtp-Source: APXvYqyE7qwpgL7KV62AOaDM+oFRQdWcTDjdZKuljhwWYaRRqCfiSc2s9/fNi7ZWZZwXl8hUkkgUgA== X-Received: by 2002:adf:ef0a:: with SMTP id e10mr20205293wro.234.1572369597497; Tue, 29 Oct 2019 10:19:57 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id f8sm3544088wmb.37.2019.10.29.10.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2019 10:19:56 -0700 (PDT) Subject: Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem To: "Kuehling, Felix" , Jason Gunthorpe , "linux-mm@kvack.org" , Jerome Glisse , Ralph Campbell , John Hubbard References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-13-jgg@ziepe.ca> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Tue, 29 Oct 2019 14:07:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=kMvDAfqNMsgwLVSlQz2HGv5SXkrMFIA/sC5PQVA0qHCk2uNpr3vgteNY32KO6XolN9 jrYaAZAZBspll0O/IT//xBGYiWDFZD8KU1uPmY2vK3KPsyhTb7mzyGHCGTLByQgbXpOx OeloXmN2vq/6bG5ZHNwG845uL6ZvA2Sdmd4uYMZ4E+4NJ7wccdnycw840yvcV4FBt6VL /xrA8JLUiBY/5hX+ugxid7ZLni4gqfgl/j7jRF06f5phYKlyiq6OI+yIzaRotZfKsIyc R7JU0GMg+/jruClJEMts6SYQJZeL4C+Qp1GS1gxReNthE6HvcZsnnoBEcT3avouO/n1H WYQw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: Juergen Gross , Mike Marciniszyn , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma@vger.kernel.org" , "nouveau@lists.freedesktop.org" , Dennis Dalessandro , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Jason Gunthorpe , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" , "xen-devel@lists.xenproject.org" , Boris Ostrovsky , Petr Cvek , "Koenig, Christian" , Ben Skeggs Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191029130737.Af-cJLa7b15MkFnwv0SFf7iCBbAf8hpTJI2X8wlZ69c@z> QW0gMjkuMTAuMTkgdW0gMTc6Mjggc2NocmllYiBLdWVobGluZywgRmVsaXg6Cj4gT24gMjAxOS0x MC0yOCA0OjEwIHAubS4sIEphc29uIEd1bnRob3JwZSB3cm90ZToKPj4gRnJvbTogSmFzb24gR3Vu dGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+Pgo+PiBmaW5kX3ZtYSgpIG11c3QgYmUgY2FsbGVk IHVuZGVyIHRoZSBtbWFwX3NlbSwgcmVvcmdhbml6ZSB0aGlzIGNvZGUgdG8KPj4gZG8gdGhlIHZt YSBjaGVjayBhZnRlciBlbnRlcmluZyB0aGUgbG9jay4KPj4KPj4gRnVydGhlciwgZml4IHRoZSB1 bmxvY2tlZCB1c2Ugb2Ygc3RydWN0IHRhc2tfc3RydWN0J3MgbW0sIGluc3RlYWQgdXNlCj4+IHRo ZSBtbSBmcm9tIGhtbV9taXJyb3Igd2hpY2ggaGFzIGFuIGFjdGl2ZSBtbV9ncmFiLiBBbHNvIHRo ZSBtbV9ncmFiCj4+IG11c3QgYmUgY29udmVydGVkIHRvIGEgbW1fZ2V0IGJlZm9yZSBhY3F1aXJp bmcgbW1hcF9zZW0gb3IgY2FsbGluZwo+PiBmaW5kX3ZtYSgpLgo+Pgo+PiBGaXhlczogNjZjNDU1 MDBiZmRjICgiZHJtL2FtZGdwdTogdXNlIG5ldyBITU0gQVBJcyBhbmQgaGVscGVycyIpCj4+IEZp eGVzOiAwOTE5MTk1ZjJiMGQgKCJkcm0vYW1kZ3B1OiBFbmFibGUgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyBpbiB3b3JrZXIgdGhyZWFkcyIpCj4+IENjOiBBbGV4IERldWNoZXIgPGFsZXhh bmRlci5kZXVjaGVyQGFtZC5jb20+Cj4+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4u a29lbmlnQGFtZC5jb20+Cj4+IENjOiBEYXZpZCAoQ2h1bk1pbmcpIFpob3UgPERhdmlkMS5aaG91 QGFtZC5jb20+Cj4+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBTaWduZWQt b2ZmLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4gT25lIHF1ZXN0aW9u IGlubGluZSB0byBjb25maXJtIG15IHVuZGVyc3RhbmRpbmcuIE90aGVyd2lzZSB0aGlzIHBhdGNo IGlzCj4KPiBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5j b20+Cj4KPgo+PiAtLS0KPj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0 bS5jIHwgMzcgKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+PiAgICAxIGZpbGUgY2hhbmdlZCwg MjEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdHRtLmMKPj4gaW5kZXggZGZmNDFkMGE4NWZlOTYuLmMwZTQxZjFmMGMy MzY1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRt LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4+IEBA IC0zNSw2ICszNSw3IEBACj4+ICAgICNpbmNsdWRlIDxsaW51eC9obW0uaD4KPj4gICAgI2luY2x1 ZGUgPGxpbnV4L3BhZ2VtYXAuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NjaGVkL3Rhc2suaD4K Pj4gKyNpbmNsdWRlIDxsaW51eC9zY2hlZC9tbS5oPgo+PiAgICAjaW5jbHVkZSA8bGludXgvc2Vx X2ZpbGUuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPj4gICAgI2luY2x1ZGUgPGxp bnV4L3N3YXAuaD4KPj4gQEAgLTc4OCw3ICs3ODksNyBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyhzdHJ1Y3QgYW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4g ICAgCXN0cnVjdCBobW1fbWlycm9yICptaXJyb3IgPSBiby0+bW4gPyAmYm8tPm1uLT5taXJyb3Ig OiBOVUxMOwo+PiAgICAJc3RydWN0IHR0bV90dCAqdHRtID0gYm8tPnRiby50dG07Cj4+ICAgIAlz dHJ1Y3QgYW1kZ3B1X3R0bV90dCAqZ3R0ID0gKHZvaWQgKil0dG07Cj4+IC0Jc3RydWN0IG1tX3N0 cnVjdCAqbW0gPSBndHQtPnVzZXJ0YXNrLT5tbTsKPj4gKwlzdHJ1Y3QgbW1fc3RydWN0ICptbTsK Pj4gICAgCXVuc2lnbmVkIGxvbmcgc3RhcnQgPSBndHQtPnVzZXJwdHI7Cj4+ICAgIAlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYTsKPj4gICAgCXN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlOwo+PiBA QCAtNzk2LDI1ICs3OTcsMTQgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMoc3Ry dWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAl1aW50NjRfdCAq cGZuczsKPj4gICAgCWludCByID0gMDsKPj4gICAgCj4+IC0JaWYgKCFtbSkgLyogSGFwcGVucyBk dXJpbmcgcHJvY2VzcyBzaHV0ZG93biAqLwo+PiAtCQlyZXR1cm4gLUVTUkNIOwo+PiAtCj4+ICAg IAlpZiAodW5saWtlbHkoIW1pcnJvcikpIHsKPj4gICAgCQlEUk1fREVCVUdfRFJJVkVSKCJGYWls ZWQgdG8gZ2V0IGhtbV9taXJyb3JcbiIpOwo+PiAtCQlyID0gLUVGQVVMVDsKPj4gLQkJZ290byBv dXQ7Cj4+ICsJCXJldHVybiAtRUZBVUxUOwo+PiAgICAJfQo+PiAgICAKPj4gLQl2bWEgPSBmaW5k X3ZtYShtbSwgc3RhcnQpOwo+PiAtCWlmICh1bmxpa2VseSghdm1hIHx8IHN0YXJ0IDwgdm1hLT52 bV9zdGFydCkpIHsKPj4gLQkJciA9IC1FRkFVTFQ7Cj4+IC0JCWdvdG8gb3V0Owo+PiAtCX0KPj4g LQlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FOT05P TkxZKSAmJgo+PiAtCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+IC0JCXIgPSAtRVBFUk07Cj4+IC0JCWdv dG8gb3V0Owo+PiAtCX0KPj4gKwltbSA9IG1pcnJvci0+aG1tLT5tbXVfbm90aWZpZXIubW07Cj4+ ICsJaWYgKCFtbWdldF9ub3RfemVybyhtbSkpIC8qIEhhcHBlbnMgZHVyaW5nIHByb2Nlc3Mgc2h1 dGRvd24gKi8KPiBUaGlzIHdvcmtzIGJlY2F1c2UgbWlycm9yLT5obW0tPm1tdV9ub3RpZmllciBo b2xkcyBhbiBtbWdyYWIgcmVmZXJlbmNlCj4gdG8gdGhlIG1tPyBTbyB0aGUgTU0gd2lsbCBub3Qg anVzdCBnbyBhd2F5LCBidXQgaWYgdGhlIG1tZ2V0IHJlZmNvdW50IGlzCj4gMCwgaXQgbWVhbnMg dGhlIG1tIGlzIG1hcmtlZCBmb3IgZGVzdHJ1Y3Rpb24gYW5kIHNob3VsZG4ndCBiZSB1c2VkIGFu eSBtb3JlLgoKWWVzLCBleGFjdGx5LiBUaGF0IGlzIGEgcmF0aGVyIGNvbW1vbiBwYXR0ZXJuLCBv bmUgcmVmZXJlbmNlIGNvdW50IGZvciAKdGhlIGZ1bmN0aW9uYWxpdHkgYW5kIG9uZSBmb3IgdGhl IHN0cnVjdHVyZS4KCldoZW4gdGhlIGZ1bmN0aW9uYWxpdHkgaXMgZ29uZSB0aGUgc3RydWN0dXJl IG1pZ2h0IHN0aWxsIGJlIGFsaXZlIGZvciAKc29tZSByZWFzb24uIFRUTSBhbmQgYSBjb3VwbGUg b2Ygb3RoZXIgc3RydWN0dXJlcyB1c2UgdGhlIHNhbWUgYXBwcm9hY2guCgpDaHJpc3RpYW4uCgo+ Cj4KPj4gKwkJcmV0dXJuIC1FU1JDSDsKPj4gICAgCj4+ICAgIAlyYW5nZSA9IGt6YWxsb2Moc2l6 ZW9mKCpyYW5nZSksIEdGUF9LRVJORUwpOwo+PiAgICAJaWYgKHVubGlrZWx5KCFyYW5nZSkpIHsK Pj4gQEAgLTg0Nyw2ICs4MzcsMTcgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMo c3RydWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAlobW1fcmFu Z2Vfd2FpdF91bnRpbF92YWxpZChyYW5nZSwgSE1NX1JBTkdFX0RFRkFVTFRfVElNRU9VVCk7Cj4+ ICAgIAo+PiAgICAJZG93bl9yZWFkKCZtbS0+bW1hcF9zZW0pOwo+PiArCXZtYSA9IGZpbmRfdm1h KG1tLCBzdGFydCk7Cj4+ICsJaWYgKHVubGlrZWx5KCF2bWEgfHwgc3RhcnQgPCB2bWEtPnZtX3N0 YXJ0KSkgewo+PiArCQlyID0gLUVGQVVMVDsKPj4gKwkJZ290byBvdXRfdW5sb2NrOwo+PiArCX0K Pj4gKwlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FO T05PTkxZKSAmJgo+PiArCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+ICsJCXIgPSAtRVBFUk07Cj4+ICsJ CWdvdG8gb3V0X3VubG9jazsKPj4gKwl9Cj4+ICsKPj4gICAgCXIgPSBobW1fcmFuZ2VfZmF1bHQo cmFuZ2UsIDApOwo+PiAgICAJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsKPj4gICAgCj4+IEBAIC04 NjUsMTUgKzg2NiwxOSBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRfdXNlcl9wYWdlcyhzdHJ1Y3Qg YW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4gICAgCX0KPj4gICAgCj4+ICAg IAlndHQtPnJhbmdlID0gcmFuZ2U7Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAKPj4gICAgCXJldHVy biAwOwo+PiAgICAKPj4gK291dF91bmxvY2s6Cj4+ICsJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsK Pj4gICAgb3V0X2ZyZWVfcGZuczoKPj4gICAgCWhtbV9yYW5nZV91bnJlZ2lzdGVyKHJhbmdlKTsK Pj4gICAgCWt2ZnJlZShwZm5zKTsKPj4gICAgb3V0X2ZyZWVfcmFuZ2VzOgo+PiAgICAJa2ZyZWUo cmFuZ2UpOwo+PiAgICBvdXQ6Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAJcmV0dXJuIHI7Cj4+ICAg IH0KPj4gICAgCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06889CA9EC4 for ; Tue, 29 Oct 2019 17:20:15 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF9F62067D for ; Tue, 29 Oct 2019 17:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kMvDAfqN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF9F62067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iPVA0-0007PM-7y; Tue, 29 Oct 2019 17:20:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iPV9z-0007PE-4x for xen-devel@lists.xenproject.org; Tue, 29 Oct 2019 17:19:59 +0000 X-Inumbo-ID: 54d87228-fa70-11e9-beca-bc764e2007e4 Received: from mail-wr1-x443.google.com (unknown [2a00:1450:4864:20::443]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 54d87228-fa70-11e9-beca-bc764e2007e4; Tue, 29 Oct 2019 17:19:58 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id p4so14535299wrm.8 for ; Tue, 29 Oct 2019 10:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=kMvDAfqNMsgwLVSlQz2HGv5SXkrMFIA/sC5PQVA0qHCk2uNpr3vgteNY32KO6XolN9 jrYaAZAZBspll0O/IT//xBGYiWDFZD8KU1uPmY2vK3KPsyhTb7mzyGHCGTLByQgbXpOx OeloXmN2vq/6bG5ZHNwG845uL6ZvA2Sdmd4uYMZ4E+4NJ7wccdnycw840yvcV4FBt6VL /xrA8JLUiBY/5hX+ugxid7ZLni4gqfgl/j7jRF06f5phYKlyiq6OI+yIzaRotZfKsIyc R7JU0GMg+/jruClJEMts6SYQJZeL4C+Qp1GS1gxReNthE6HvcZsnnoBEcT3avouO/n1H WYQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=kSfGQlj91eWo6PSUUr2ylB9mGcf84Th8g7xf0fvIyVSbwUp5qEmLTm4GrJeAryFU7y YCjN4NQGQTqvj4jCgRBuXjZ+y9ajQlVGdk5O8D64cgzUkcG4dGxoggG8l5eB+DX5Cvgk YfU5aLMJSd0/LH4JjpMwRsfP+oJN460P3+aRMso/l//Da0a2pd+8l2iswZFWQqk3Fa/M cjdCdVNWaMLZcSYyXtqykygbpWY9vt+ixFRS6mGKI3WctFdkJ+LPOKmBL/0W4HIWgXdN 831aDLTp70kmb0A1JJCfJbDtOCUYYEMA9ZVHIUoep/qq0IU90seLJ7pKcclOliJXe/Zg yrEg== X-Gm-Message-State: APjAAAVOJZjnLr1kaeXAJXDbyZZy+QTxAyZNqs/r7t33Up3CcI4/I2U0 ECTvsqr8DQtsRKohdH6Sz30= X-Google-Smtp-Source: APXvYqyE7qwpgL7KV62AOaDM+oFRQdWcTDjdZKuljhwWYaRRqCfiSc2s9/fNi7ZWZZwXl8hUkkgUgA== X-Received: by 2002:adf:ef0a:: with SMTP id e10mr20205293wro.234.1572369597497; Tue, 29 Oct 2019 10:19:57 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id f8sm3544088wmb.37.2019.10.29.10.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2019 10:19:56 -0700 (PDT) To: "Kuehling, Felix" , Jason Gunthorpe , "linux-mm@kvack.org" , Jerome Glisse , Ralph Campbell , John Hubbard References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-13-jgg@ziepe.ca> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Tue, 29 Oct 2019 14:07:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: Juergen Gross , "Zhou, David\(ChunMing\)" , Mike Marciniszyn , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma@vger.kernel.org" , "nouveau@lists.freedesktop.org" , Dennis Dalessandro , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Jason Gunthorpe , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" , "xen-devel@lists.xenproject.org" , Boris Ostrovsky , Petr Cvek , "Koenig, Christian" , Ben Skeggs Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" QW0gMjkuMTAuMTkgdW0gMTc6Mjggc2NocmllYiBLdWVobGluZywgRmVsaXg6Cj4gT24gMjAxOS0x MC0yOCA0OjEwIHAubS4sIEphc29uIEd1bnRob3JwZSB3cm90ZToKPj4gRnJvbTogSmFzb24gR3Vu dGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+Pgo+PiBmaW5kX3ZtYSgpIG11c3QgYmUgY2FsbGVk IHVuZGVyIHRoZSBtbWFwX3NlbSwgcmVvcmdhbml6ZSB0aGlzIGNvZGUgdG8KPj4gZG8gdGhlIHZt YSBjaGVjayBhZnRlciBlbnRlcmluZyB0aGUgbG9jay4KPj4KPj4gRnVydGhlciwgZml4IHRoZSB1 bmxvY2tlZCB1c2Ugb2Ygc3RydWN0IHRhc2tfc3RydWN0J3MgbW0sIGluc3RlYWQgdXNlCj4+IHRo ZSBtbSBmcm9tIGhtbV9taXJyb3Igd2hpY2ggaGFzIGFuIGFjdGl2ZSBtbV9ncmFiLiBBbHNvIHRo ZSBtbV9ncmFiCj4+IG11c3QgYmUgY29udmVydGVkIHRvIGEgbW1fZ2V0IGJlZm9yZSBhY3F1aXJp bmcgbW1hcF9zZW0gb3IgY2FsbGluZwo+PiBmaW5kX3ZtYSgpLgo+Pgo+PiBGaXhlczogNjZjNDU1 MDBiZmRjICgiZHJtL2FtZGdwdTogdXNlIG5ldyBITU0gQVBJcyBhbmQgaGVscGVycyIpCj4+IEZp eGVzOiAwOTE5MTk1ZjJiMGQgKCJkcm0vYW1kZ3B1OiBFbmFibGUgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyBpbiB3b3JrZXIgdGhyZWFkcyIpCj4+IENjOiBBbGV4IERldWNoZXIgPGFsZXhh bmRlci5kZXVjaGVyQGFtZC5jb20+Cj4+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4u a29lbmlnQGFtZC5jb20+Cj4+IENjOiBEYXZpZCAoQ2h1bk1pbmcpIFpob3UgPERhdmlkMS5aaG91 QGFtZC5jb20+Cj4+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBTaWduZWQt b2ZmLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4gT25lIHF1ZXN0aW9u IGlubGluZSB0byBjb25maXJtIG15IHVuZGVyc3RhbmRpbmcuIE90aGVyd2lzZSB0aGlzIHBhdGNo IGlzCj4KPiBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5j b20+Cj4KPgo+PiAtLS0KPj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0 bS5jIHwgMzcgKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+PiAgICAxIGZpbGUgY2hhbmdlZCwg MjEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdHRtLmMKPj4gaW5kZXggZGZmNDFkMGE4NWZlOTYuLmMwZTQxZjFmMGMy MzY1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRt LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4+IEBA IC0zNSw2ICszNSw3IEBACj4+ICAgICNpbmNsdWRlIDxsaW51eC9obW0uaD4KPj4gICAgI2luY2x1 ZGUgPGxpbnV4L3BhZ2VtYXAuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NjaGVkL3Rhc2suaD4K Pj4gKyNpbmNsdWRlIDxsaW51eC9zY2hlZC9tbS5oPgo+PiAgICAjaW5jbHVkZSA8bGludXgvc2Vx X2ZpbGUuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPj4gICAgI2luY2x1ZGUgPGxp bnV4L3N3YXAuaD4KPj4gQEAgLTc4OCw3ICs3ODksNyBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyhzdHJ1Y3QgYW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4g ICAgCXN0cnVjdCBobW1fbWlycm9yICptaXJyb3IgPSBiby0+bW4gPyAmYm8tPm1uLT5taXJyb3Ig OiBOVUxMOwo+PiAgICAJc3RydWN0IHR0bV90dCAqdHRtID0gYm8tPnRiby50dG07Cj4+ICAgIAlz dHJ1Y3QgYW1kZ3B1X3R0bV90dCAqZ3R0ID0gKHZvaWQgKil0dG07Cj4+IC0Jc3RydWN0IG1tX3N0 cnVjdCAqbW0gPSBndHQtPnVzZXJ0YXNrLT5tbTsKPj4gKwlzdHJ1Y3QgbW1fc3RydWN0ICptbTsK Pj4gICAgCXVuc2lnbmVkIGxvbmcgc3RhcnQgPSBndHQtPnVzZXJwdHI7Cj4+ICAgIAlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYTsKPj4gICAgCXN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlOwo+PiBA QCAtNzk2LDI1ICs3OTcsMTQgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMoc3Ry dWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAl1aW50NjRfdCAq cGZuczsKPj4gICAgCWludCByID0gMDsKPj4gICAgCj4+IC0JaWYgKCFtbSkgLyogSGFwcGVucyBk dXJpbmcgcHJvY2VzcyBzaHV0ZG93biAqLwo+PiAtCQlyZXR1cm4gLUVTUkNIOwo+PiAtCj4+ICAg IAlpZiAodW5saWtlbHkoIW1pcnJvcikpIHsKPj4gICAgCQlEUk1fREVCVUdfRFJJVkVSKCJGYWls ZWQgdG8gZ2V0IGhtbV9taXJyb3JcbiIpOwo+PiAtCQlyID0gLUVGQVVMVDsKPj4gLQkJZ290byBv dXQ7Cj4+ICsJCXJldHVybiAtRUZBVUxUOwo+PiAgICAJfQo+PiAgICAKPj4gLQl2bWEgPSBmaW5k X3ZtYShtbSwgc3RhcnQpOwo+PiAtCWlmICh1bmxpa2VseSghdm1hIHx8IHN0YXJ0IDwgdm1hLT52 bV9zdGFydCkpIHsKPj4gLQkJciA9IC1FRkFVTFQ7Cj4+IC0JCWdvdG8gb3V0Owo+PiAtCX0KPj4g LQlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FOT05P TkxZKSAmJgo+PiAtCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+IC0JCXIgPSAtRVBFUk07Cj4+IC0JCWdv dG8gb3V0Owo+PiAtCX0KPj4gKwltbSA9IG1pcnJvci0+aG1tLT5tbXVfbm90aWZpZXIubW07Cj4+ ICsJaWYgKCFtbWdldF9ub3RfemVybyhtbSkpIC8qIEhhcHBlbnMgZHVyaW5nIHByb2Nlc3Mgc2h1 dGRvd24gKi8KPiBUaGlzIHdvcmtzIGJlY2F1c2UgbWlycm9yLT5obW0tPm1tdV9ub3RpZmllciBo b2xkcyBhbiBtbWdyYWIgcmVmZXJlbmNlCj4gdG8gdGhlIG1tPyBTbyB0aGUgTU0gd2lsbCBub3Qg anVzdCBnbyBhd2F5LCBidXQgaWYgdGhlIG1tZ2V0IHJlZmNvdW50IGlzCj4gMCwgaXQgbWVhbnMg dGhlIG1tIGlzIG1hcmtlZCBmb3IgZGVzdHJ1Y3Rpb24gYW5kIHNob3VsZG4ndCBiZSB1c2VkIGFu eSBtb3JlLgoKWWVzLCBleGFjdGx5LiBUaGF0IGlzIGEgcmF0aGVyIGNvbW1vbiBwYXR0ZXJuLCBv bmUgcmVmZXJlbmNlIGNvdW50IGZvciAKdGhlIGZ1bmN0aW9uYWxpdHkgYW5kIG9uZSBmb3IgdGhl IHN0cnVjdHVyZS4KCldoZW4gdGhlIGZ1bmN0aW9uYWxpdHkgaXMgZ29uZSB0aGUgc3RydWN0dXJl IG1pZ2h0IHN0aWxsIGJlIGFsaXZlIGZvciAKc29tZSByZWFzb24uIFRUTSBhbmQgYSBjb3VwbGUg b2Ygb3RoZXIgc3RydWN0dXJlcyB1c2UgdGhlIHNhbWUgYXBwcm9hY2guCgpDaHJpc3RpYW4uCgo+ Cj4KPj4gKwkJcmV0dXJuIC1FU1JDSDsKPj4gICAgCj4+ICAgIAlyYW5nZSA9IGt6YWxsb2Moc2l6 ZW9mKCpyYW5nZSksIEdGUF9LRVJORUwpOwo+PiAgICAJaWYgKHVubGlrZWx5KCFyYW5nZSkpIHsK Pj4gQEAgLTg0Nyw2ICs4MzcsMTcgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMo c3RydWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAlobW1fcmFu Z2Vfd2FpdF91bnRpbF92YWxpZChyYW5nZSwgSE1NX1JBTkdFX0RFRkFVTFRfVElNRU9VVCk7Cj4+ ICAgIAo+PiAgICAJZG93bl9yZWFkKCZtbS0+bW1hcF9zZW0pOwo+PiArCXZtYSA9IGZpbmRfdm1h KG1tLCBzdGFydCk7Cj4+ICsJaWYgKHVubGlrZWx5KCF2bWEgfHwgc3RhcnQgPCB2bWEtPnZtX3N0 YXJ0KSkgewo+PiArCQlyID0gLUVGQVVMVDsKPj4gKwkJZ290byBvdXRfdW5sb2NrOwo+PiArCX0K Pj4gKwlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FO T05PTkxZKSAmJgo+PiArCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+ICsJCXIgPSAtRVBFUk07Cj4+ICsJ CWdvdG8gb3V0X3VubG9jazsKPj4gKwl9Cj4+ICsKPj4gICAgCXIgPSBobW1fcmFuZ2VfZmF1bHQo cmFuZ2UsIDApOwo+PiAgICAJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsKPj4gICAgCj4+IEBAIC04 NjUsMTUgKzg2NiwxOSBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRfdXNlcl9wYWdlcyhzdHJ1Y3Qg YW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4gICAgCX0KPj4gICAgCj4+ICAg IAlndHQtPnJhbmdlID0gcmFuZ2U7Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAKPj4gICAgCXJldHVy biAwOwo+PiAgICAKPj4gK291dF91bmxvY2s6Cj4+ICsJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsK Pj4gICAgb3V0X2ZyZWVfcGZuczoKPj4gICAgCWhtbV9yYW5nZV91bnJlZ2lzdGVyKHJhbmdlKTsK Pj4gICAgCWt2ZnJlZShwZm5zKTsKPj4gICAgb3V0X2ZyZWVfcmFuZ2VzOgo+PiAgICAJa2ZyZWUo cmFuZ2UpOwo+PiAgICBvdXQ6Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAJcmV0dXJuIHI7Cj4+ICAg IH0KPj4gICAgCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9s aXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5097ECA9EAE for ; Tue, 29 Oct 2019 17:20:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29AA32067D for ; Tue, 29 Oct 2019 17:20:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29AA32067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9B2A6EC4F; Tue, 29 Oct 2019 17:19:59 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id C88EE6EC4F; Tue, 29 Oct 2019 17:19:58 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id s1so14578830wro.0; Tue, 29 Oct 2019 10:19:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=S8hKaTz2G6pztg0JMTKZOTO4zP8wIcoSzmrsuB25x51JUb/xRmmKGJpWXzplNd9r6c Umk4q+UM6CatUexvnS0ClpzoxuinMymGe+fZHDl5xfiT1SBcoxpg2M6lkex8Dgs3qa4B 2W9R4H2YRiq85J4XMhmEGmBzwhMTAwKN6IOxPAL+PGcKeFNXbiClxFd9Z4/+1sAKaG0h Mx+RaLF9NPga4sBmwDWQV/w1eW35ajCfuuauUnxsrFAVc/ahoUvnbBaFobrDs3XuuVUk ouQHwnGjx5FbfHt1kbbkLVTP67a0IpDqDIv3AesmCnB15MqrkXoCux5F7TFDfFHIamWH vKnQ== X-Gm-Message-State: APjAAAVWdzQ5vAd3pviHoCaZLY5BjLj1y4wmL2a/uitOUIx41hNCYtKw IwgMGNr4adLFlJj6F1TDVGE= X-Google-Smtp-Source: APXvYqyE7qwpgL7KV62AOaDM+oFRQdWcTDjdZKuljhwWYaRRqCfiSc2s9/fNi7ZWZZwXl8hUkkgUgA== X-Received: by 2002:adf:ef0a:: with SMTP id e10mr20205293wro.234.1572369597497; Tue, 29 Oct 2019 10:19:57 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id f8sm3544088wmb.37.2019.10.29.10.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2019 10:19:56 -0700 (PDT) Subject: Re: [PATCH v2 12/15] drm/amdgpu: Call find_vma under mmap_sem To: "Kuehling, Felix" , Jason Gunthorpe , "linux-mm@kvack.org" , Jerome Glisse , Ralph Campbell , John Hubbard References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-13-jgg@ziepe.ca> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Tue, 29 Oct 2019 14:07:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+7k6Tgo7zdAI3sdkV2vUab4Qg2cErY2tDGH+QpqLC8g=; b=kMvDAfqNMsgwLVSlQz2HGv5SXkrMFIA/sC5PQVA0qHCk2uNpr3vgteNY32KO6XolN9 jrYaAZAZBspll0O/IT//xBGYiWDFZD8KU1uPmY2vK3KPsyhTb7mzyGHCGTLByQgbXpOx OeloXmN2vq/6bG5ZHNwG845uL6ZvA2Sdmd4uYMZ4E+4NJ7wccdnycw840yvcV4FBt6VL /xrA8JLUiBY/5hX+ugxid7ZLni4gqfgl/j7jRF06f5phYKlyiq6OI+yIzaRotZfKsIyc R7JU0GMg+/jruClJEMts6SYQJZeL4C+Qp1GS1gxReNthE6HvcZsnnoBEcT3avouO/n1H WYQw== X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: Juergen Gross , "Zhou, David\(ChunMing\)" , Mike Marciniszyn , Stefano Stabellini , Oleksandr Andrushchenko , "linux-rdma@vger.kernel.org" , "nouveau@lists.freedesktop.org" , Dennis Dalessandro , "amd-gfx@lists.freedesktop.org" , Christoph Hellwig , Jason Gunthorpe , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" , "xen-devel@lists.xenproject.org" , Boris Ostrovsky , Petr Cvek , "Koenig, Christian" , Ben Skeggs Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191029130737.gxNgys872jw9TlBc4SnHXYZ6sfhYU3VUeIKfauBltSs@z> QW0gMjkuMTAuMTkgdW0gMTc6Mjggc2NocmllYiBLdWVobGluZywgRmVsaXg6Cj4gT24gMjAxOS0x MC0yOCA0OjEwIHAubS4sIEphc29uIEd1bnRob3JwZSB3cm90ZToKPj4gRnJvbTogSmFzb24gR3Vu dGhvcnBlIDxqZ2dAbWVsbGFub3guY29tPgo+Pgo+PiBmaW5kX3ZtYSgpIG11c3QgYmUgY2FsbGVk IHVuZGVyIHRoZSBtbWFwX3NlbSwgcmVvcmdhbml6ZSB0aGlzIGNvZGUgdG8KPj4gZG8gdGhlIHZt YSBjaGVjayBhZnRlciBlbnRlcmluZyB0aGUgbG9jay4KPj4KPj4gRnVydGhlciwgZml4IHRoZSB1 bmxvY2tlZCB1c2Ugb2Ygc3RydWN0IHRhc2tfc3RydWN0J3MgbW0sIGluc3RlYWQgdXNlCj4+IHRo ZSBtbSBmcm9tIGhtbV9taXJyb3Igd2hpY2ggaGFzIGFuIGFjdGl2ZSBtbV9ncmFiLiBBbHNvIHRo ZSBtbV9ncmFiCj4+IG11c3QgYmUgY29udmVydGVkIHRvIGEgbW1fZ2V0IGJlZm9yZSBhY3F1aXJp bmcgbW1hcF9zZW0gb3IgY2FsbGluZwo+PiBmaW5kX3ZtYSgpLgo+Pgo+PiBGaXhlczogNjZjNDU1 MDBiZmRjICgiZHJtL2FtZGdwdTogdXNlIG5ldyBITU0gQVBJcyBhbmQgaGVscGVycyIpCj4+IEZp eGVzOiAwOTE5MTk1ZjJiMGQgKCJkcm0vYW1kZ3B1OiBFbmFibGUgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyBpbiB3b3JrZXIgdGhyZWFkcyIpCj4+IENjOiBBbGV4IERldWNoZXIgPGFsZXhh bmRlci5kZXVjaGVyQGFtZC5jb20+Cj4+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4u a29lbmlnQGFtZC5jb20+Cj4+IENjOiBEYXZpZCAoQ2h1bk1pbmcpIFpob3UgPERhdmlkMS5aaG91 QGFtZC5jb20+Cj4+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBTaWduZWQt b2ZmLWJ5OiBKYXNvbiBHdW50aG9ycGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4gT25lIHF1ZXN0aW9u IGlubGluZSB0byBjb25maXJtIG15IHVuZGVyc3RhbmRpbmcuIE90aGVyd2lzZSB0aGlzIHBhdGNo IGlzCj4KPiBSZXZpZXdlZC1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1ZWhsaW5nQGFtZC5j b20+Cj4KPgo+PiAtLS0KPj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0 bS5jIHwgMzcgKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+PiAgICAxIGZpbGUgY2hhbmdlZCwg MjEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdHRtLmMKPj4gaW5kZXggZGZmNDFkMGE4NWZlOTYuLmMwZTQxZjFmMGMy MzY1IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRt LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4+IEBA IC0zNSw2ICszNSw3IEBACj4+ICAgICNpbmNsdWRlIDxsaW51eC9obW0uaD4KPj4gICAgI2luY2x1 ZGUgPGxpbnV4L3BhZ2VtYXAuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NjaGVkL3Rhc2suaD4K Pj4gKyNpbmNsdWRlIDxsaW51eC9zY2hlZC9tbS5oPgo+PiAgICAjaW5jbHVkZSA8bGludXgvc2Vx X2ZpbGUuaD4KPj4gICAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPj4gICAgI2luY2x1ZGUgPGxp bnV4L3N3YXAuaD4KPj4gQEAgLTc4OCw3ICs3ODksNyBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRf dXNlcl9wYWdlcyhzdHJ1Y3QgYW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4g ICAgCXN0cnVjdCBobW1fbWlycm9yICptaXJyb3IgPSBiby0+bW4gPyAmYm8tPm1uLT5taXJyb3Ig OiBOVUxMOwo+PiAgICAJc3RydWN0IHR0bV90dCAqdHRtID0gYm8tPnRiby50dG07Cj4+ICAgIAlz dHJ1Y3QgYW1kZ3B1X3R0bV90dCAqZ3R0ID0gKHZvaWQgKil0dG07Cj4+IC0Jc3RydWN0IG1tX3N0 cnVjdCAqbW0gPSBndHQtPnVzZXJ0YXNrLT5tbTsKPj4gKwlzdHJ1Y3QgbW1fc3RydWN0ICptbTsK Pj4gICAgCXVuc2lnbmVkIGxvbmcgc3RhcnQgPSBndHQtPnVzZXJwdHI7Cj4+ICAgIAlzdHJ1Y3Qg dm1fYXJlYV9zdHJ1Y3QgKnZtYTsKPj4gICAgCXN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlOwo+PiBA QCAtNzk2LDI1ICs3OTcsMTQgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMoc3Ry dWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAl1aW50NjRfdCAq cGZuczsKPj4gICAgCWludCByID0gMDsKPj4gICAgCj4+IC0JaWYgKCFtbSkgLyogSGFwcGVucyBk dXJpbmcgcHJvY2VzcyBzaHV0ZG93biAqLwo+PiAtCQlyZXR1cm4gLUVTUkNIOwo+PiAtCj4+ICAg IAlpZiAodW5saWtlbHkoIW1pcnJvcikpIHsKPj4gICAgCQlEUk1fREVCVUdfRFJJVkVSKCJGYWls ZWQgdG8gZ2V0IGhtbV9taXJyb3JcbiIpOwo+PiAtCQlyID0gLUVGQVVMVDsKPj4gLQkJZ290byBv dXQ7Cj4+ICsJCXJldHVybiAtRUZBVUxUOwo+PiAgICAJfQo+PiAgICAKPj4gLQl2bWEgPSBmaW5k X3ZtYShtbSwgc3RhcnQpOwo+PiAtCWlmICh1bmxpa2VseSghdm1hIHx8IHN0YXJ0IDwgdm1hLT52 bV9zdGFydCkpIHsKPj4gLQkJciA9IC1FRkFVTFQ7Cj4+IC0JCWdvdG8gb3V0Owo+PiAtCX0KPj4g LQlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FOT05P TkxZKSAmJgo+PiAtCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+IC0JCXIgPSAtRVBFUk07Cj4+IC0JCWdv dG8gb3V0Owo+PiAtCX0KPj4gKwltbSA9IG1pcnJvci0+aG1tLT5tbXVfbm90aWZpZXIubW07Cj4+ ICsJaWYgKCFtbWdldF9ub3RfemVybyhtbSkpIC8qIEhhcHBlbnMgZHVyaW5nIHByb2Nlc3Mgc2h1 dGRvd24gKi8KPiBUaGlzIHdvcmtzIGJlY2F1c2UgbWlycm9yLT5obW0tPm1tdV9ub3RpZmllciBo b2xkcyBhbiBtbWdyYWIgcmVmZXJlbmNlCj4gdG8gdGhlIG1tPyBTbyB0aGUgTU0gd2lsbCBub3Qg anVzdCBnbyBhd2F5LCBidXQgaWYgdGhlIG1tZ2V0IHJlZmNvdW50IGlzCj4gMCwgaXQgbWVhbnMg dGhlIG1tIGlzIG1hcmtlZCBmb3IgZGVzdHJ1Y3Rpb24gYW5kIHNob3VsZG4ndCBiZSB1c2VkIGFu eSBtb3JlLgoKWWVzLCBleGFjdGx5LiBUaGF0IGlzIGEgcmF0aGVyIGNvbW1vbiBwYXR0ZXJuLCBv bmUgcmVmZXJlbmNlIGNvdW50IGZvciAKdGhlIGZ1bmN0aW9uYWxpdHkgYW5kIG9uZSBmb3IgdGhl IHN0cnVjdHVyZS4KCldoZW4gdGhlIGZ1bmN0aW9uYWxpdHkgaXMgZ29uZSB0aGUgc3RydWN0dXJl IG1pZ2h0IHN0aWxsIGJlIGFsaXZlIGZvciAKc29tZSByZWFzb24uIFRUTSBhbmQgYSBjb3VwbGUg b2Ygb3RoZXIgc3RydWN0dXJlcyB1c2UgdGhlIHNhbWUgYXBwcm9hY2guCgpDaHJpc3RpYW4uCgo+ Cj4KPj4gKwkJcmV0dXJuIC1FU1JDSDsKPj4gICAgCj4+ICAgIAlyYW5nZSA9IGt6YWxsb2Moc2l6 ZW9mKCpyYW5nZSksIEdGUF9LRVJORUwpOwo+PiAgICAJaWYgKHVubGlrZWx5KCFyYW5nZSkpIHsK Pj4gQEAgLTg0Nyw2ICs4MzcsMTcgQEAgaW50IGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJfcGFnZXMo c3RydWN0IGFtZGdwdV9ibyAqYm8sIHN0cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgIAlobW1fcmFu Z2Vfd2FpdF91bnRpbF92YWxpZChyYW5nZSwgSE1NX1JBTkdFX0RFRkFVTFRfVElNRU9VVCk7Cj4+ ICAgIAo+PiAgICAJZG93bl9yZWFkKCZtbS0+bW1hcF9zZW0pOwo+PiArCXZtYSA9IGZpbmRfdm1h KG1tLCBzdGFydCk7Cj4+ICsJaWYgKHVubGlrZWx5KCF2bWEgfHwgc3RhcnQgPCB2bWEtPnZtX3N0 YXJ0KSkgewo+PiArCQlyID0gLUVGQVVMVDsKPj4gKwkJZ290byBvdXRfdW5sb2NrOwo+PiArCX0K Pj4gKwlpZiAodW5saWtlbHkoKGd0dC0+dXNlcmZsYWdzICYgQU1ER1BVX0dFTV9VU0VSUFRSX0FO T05PTkxZKSAmJgo+PiArCQl2bWEtPnZtX2ZpbGUpKSB7Cj4+ICsJCXIgPSAtRVBFUk07Cj4+ICsJ CWdvdG8gb3V0X3VubG9jazsKPj4gKwl9Cj4+ICsKPj4gICAgCXIgPSBobW1fcmFuZ2VfZmF1bHQo cmFuZ2UsIDApOwo+PiAgICAJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsKPj4gICAgCj4+IEBAIC04 NjUsMTUgKzg2NiwxOSBAQCBpbnQgYW1kZ3B1X3R0bV90dF9nZXRfdXNlcl9wYWdlcyhzdHJ1Y3Qg YW1kZ3B1X2JvICpibywgc3RydWN0IHBhZ2UgKipwYWdlcykKPj4gICAgCX0KPj4gICAgCj4+ICAg IAlndHQtPnJhbmdlID0gcmFuZ2U7Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAKPj4gICAgCXJldHVy biAwOwo+PiAgICAKPj4gK291dF91bmxvY2s6Cj4+ICsJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsK Pj4gICAgb3V0X2ZyZWVfcGZuczoKPj4gICAgCWhtbV9yYW5nZV91bnJlZ2lzdGVyKHJhbmdlKTsK Pj4gICAgCWt2ZnJlZShwZm5zKTsKPj4gICAgb3V0X2ZyZWVfcmFuZ2VzOgo+PiAgICAJa2ZyZWUo cmFuZ2UpOwo+PiAgICBvdXQ6Cj4+ICsJbW1wdXQobW0pOwo+PiAgICAJcmV0dXJuIHI7Cj4+ICAg IH0KPj4gICAgCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4 IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=