From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring() Date: Sun, 28 Oct 2018 11:09:03 +0300 Message-ID: References: <1540697651-22993-1-git-send-email-tanhuazhong@huawei.com> <1540697651-22993-6-git-send-email-tanhuazhong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, yisen.zhuang@huawei.com, lipeng321@huawei.com, linyunsheng@huawei.com To: Huazhong Tan , davem@davemloft.net Return-path: Received: from mail-lj1-f181.google.com ([209.85.208.181]:45790 "EHLO mail-lj1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbeJ1QxO (ORCPT ); Sun, 28 Oct 2018 12:53:14 -0400 Received: by mail-lj1-f181.google.com with SMTP id j4-v6so4858526ljc.12 for ; Sun, 28 Oct 2018 01:09:18 -0700 (PDT) In-Reply-To: <1540697651-22993-6-git-send-email-tanhuazhong@huawei.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 28.10.2018 6:34, Huazhong Tan wrote: > It is not necessary to reset the queue in the hns3_uninit_all_ring(), > since the queue is stopped in the down operation, and will be reset > in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING Operation. > flag in the hclge_reset_tqp() is not correct, because we need to reset > tqp during pf reset, otherwise it may cause queue not be reset to Not being reset? > working state problem. > > Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") > Signed-off-by: Huazhong Tan [...] MBR, Sergei