From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F41C433EF for ; Fri, 3 Sep 2021 11:17:37 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 94A9F6108E for ; Fri, 3 Sep 2021 11:17:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 94A9F6108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ashroe.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F039340E64; Fri, 3 Sep 2021 13:17:35 +0200 (CEST) Received: from mail-108-mta234.mxroute.com (mail-108-mta234.mxroute.com [136.175.108.234]) by mails.dpdk.org (Postfix) with ESMTP id AF0E540E3C for ; Fri, 3 Sep 2021 13:17:33 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta234.mxroute.com (ZoneMTA) with ESMTPSA id 17bab60c6a800074ba.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 03 Sep 2021 11:17:31 +0000 X-Zone-Loop: 24e07c306df955ca1fddbe73f2bacd4f0a2310c6a5ff X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bpwdnQWCMdJ/oDQdZ5a3Ubp1TjbtO723a3MCaU6a4Ho=; b=YZALGH4vkAUTJ/rcYuyJOAOn95 1WC+GQ+7mArfbXl1kn0XfjNC9bjZrO7hpOvO29bLV3LAlleJAz3BNY1utmO9i/MiBv+KetU7Jb61v 3qj1wa87tRdkN/Zjn7YusmJmumjXLph2UE2wz3AmFaMYv9ufQdGityGYwNdBeSY6XNLKcqdNu4ekQ xX0UO+gkq614jguK8mC270oWS11twURqnLSgZ0dlxIzN0wMcVhE/u/h2gAz9FjM25QtXRcOEP72eA npiPER9tHXFwxUUzPwd8zp77qtjAlnH2Oj2HAI2noI5woP8IkYVwAMQWXOJ8+KvNkOlAy5PHhSoTD HSkJjl8w==; To: Aaron Conole , Stephen Hemminger Cc: dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, thomas@monjalon.net, ktraynor@redhat.com References: <20210618163659.85933-1-mdr@ashroe.eu> <20210831145017.856776-1-mdr@ashroe.eu> <20210901101757.41e83aa7@hermes.local> From: "Kinsella, Ray" Message-ID: Date: Fri, 3 Sep 2021 12:17:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v10 0/3] devtools: scripts to count and track symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/09/2021 20:04, Aaron Conole wrote: > Stephen Hemminger writes: > >> On Wed, 01 Sep 2021 08:31:27 -0400 >> Aaron Conole wrote: >> >>> $ flake8 ./usertools/dpdk-devbind.py | sed 's@./usertools/dpdk-devbind.py[:0-9]* @@' | sort -u >>> E128 continuation line under-indented for visual indent >>> E302 expected 2 blank lines, found 1 >>> E305 expected 2 blank lines after class or function definition, found 1 >>> E501 line too long (105 > 79 characters) >>> E501 line too long (80 > 79 characters) >>> E501 line too long (82 > 79 characters) >>> E501 line too long (83 > 79 characters) >>> E501 line too long (84 > 79 characters) >>> E501 line too long (85 > 79 characters) >>> E501 line too long (86 > 79 characters) >>> E501 line too long (91 > 79 characters) >> >> Current practice on many projects has allowed lines up to 100 characters. > > It is probably okay to run with '--ignore=E501' (which will squelch the > character limit). I added # noqa : E501 in the appropriate places, as we can't depend on folks using --ignore=E501.