From: Marek Vasut <marex@denx.de>
To: Humberto Naves <hsnaves@gmail.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] arm: socfpga: Add the terasic de10-standard board
Date: Sun, 22 May 2022 04:06:16 +0200 [thread overview]
Message-ID: <cd513d5f-044f-a578-10dc-3cb416b7282b@denx.de> (raw)
In-Reply-To: <20220521173221.6425-1-hsnaves@gmail.com>
On 5/21/22 19:32, Humberto Naves wrote:
> Used the de10-nano files as templates for the de10-standard board.
> Changed the iocsr_config.h and pinmux_config.h based on the handoff
> files generated by quartus. Finally, the pll_config.h was copied
> from the altera cyclone5-socdk board.
Doesn't the PLL config also come from quartus ? It should all come from
it. See doc/README.socfpga
> Signed-off-by: Humberto Naves <hsnaves@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
I think a lot of those board/config-specific copyright messages could
use an update, I think they should be assigned to you. Please do a quick
V2 with that change. Besides that:
Reviewed-by: Marek Vasut <marex@denx.de>
next prev parent reply other threads:[~2022-05-22 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 17:32 [PATCH] arm: socfpga: Add the terasic de10-standard board Humberto Naves
2022-05-22 2:06 ` Marek Vasut [this message]
2022-05-22 15:53 ` Humberto Naves
2022-05-22 17:01 ` Marek Vasut
2022-05-23 1:54 ` [PATCH v2] " Humberto Naves
2022-05-25 11:02 ` Marek Vasut
2022-05-25 15:37 ` Humberto Naves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd513d5f-044f-a578-10dc-3cb416b7282b@denx.de \
--to=marex@denx.de \
--cc=hsnaves@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.