From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA52EC433B4 for ; Tue, 6 Apr 2021 18:03:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96F5961154 for ; Tue, 6 Apr 2021 18:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96F5961154 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.106188.203095 (Exim 4.92) (envelope-from ) id 1lTq3E-0004Rp-Vq; Tue, 06 Apr 2021 18:03:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 106188.203095; Tue, 06 Apr 2021 18:03:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTq3E-0004Ri-SD; Tue, 06 Apr 2021 18:03:44 +0000 Received: by outflank-mailman (input) for mailman id 106188; Tue, 06 Apr 2021 18:03:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTq3E-0004RY-3y for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 18:03:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTq3C-0004K8-UX; Tue, 06 Apr 2021 18:03:42 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lTq3C-0002NC-K7; Tue, 06 Apr 2021 18:03:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=H1KREt+k46XAFO7M/nG21288UVAzga57uKnKtGMnA6w=; b=yh5e+tzL1nwgiVhbQ5f0nBTPdY RzYa6SPKpbMyEbIP3VAMEFaH9CVaGZ2bx27p3STD1GHalmzIY9IQNlluukdkJi53WqwcQh9NCnEA6 pHW4225YeWp5SudTvUDTZda5QSn8rRJ75uA4n4PGy2sxSdKSQmfbfUnNWR7TomruBTjo=; Subject: Re: [PATCH 01/14] xen: Constify the second parameter of rangeset_new() To: Jan Beulich Cc: Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-2-julien@xen.org> From: Julien Grall Message-ID: Date: Tue, 6 Apr 2021 19:03:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 06/04/2021 08:57, Jan Beulich wrote: > On 05.04.2021 17:57, Julien Grall wrote: >> From: Julien Grall >> >> The string 'name' will never get modified by the function, so mark it >> as const. >> >> Signed-off-by: Julien Grall > > Reviewed-by: Jan Beulich Thanks! > >> --- a/xen/common/rangeset.c >> +++ b/xen/common/rangeset.c >> @@ -421,7 +421,7 @@ bool_t rangeset_is_empty( >> } >> >> struct rangeset *rangeset_new( >> - struct domain *d, char *name, unsigned int flags) >> + struct domain *d, const char *name, unsigned int flags) >> { >> struct rangeset *r; > > Remotely along these lines the function also has no need anymore to > use snprintf() - safe_strcpy() very well fits both purposes. But > quite likely for another patch. I saw you already sent the patch for that. So I am assuming there is no action for me here. Cheers, -- Julien Grall