From: Brian Austin <brian.austin@cirrus.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
brian.austin@cirrus.com, Paul.Handrigan@cirrus.com,
lgirdwood@gmail.com, broonie@kernel.org
Subject: Re: [PATCH] ASoC: cs35l35: Clear reset_gpio on the error path in probe
Date: Mon, 27 Mar 2017 11:04:49 -0500 [thread overview]
Message-ID: <cd6a5b2d-8874-4adb-b940-54a11c68ef03@EX3.ad.cirrus.com> (raw)
In-Reply-To: <1490630067-23455-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon, 27 Mar 2017, Charles Keepax wrote:
> The error path in probe attempts to put the device back into reset.
> Should we fail to get the reset_gpio (such as a probe defer) we will
> leave the error value in there, which the gpiod_set_value_cansleep on
> the error path will attempt to deference.
>
> Fix this issue by clearing reset_gpio before we head into the error
> path.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
Acked-by: Brian Austin <brian.austin@cirrus.com>
next prev parent reply other threads:[~2017-03-27 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 15:54 [PATCH] ASoC: cs35l35: Clear reset_gpio on the error path in probe Charles Keepax
2017-03-27 16:04 ` Brian Austin [this message]
2017-03-29 11:02 ` Applied "ASoC: cs35l35: Clear reset_gpio on the error path in probe" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd6a5b2d-8874-4adb-b940-54a11c68ef03@EX3.ad.cirrus.com \
--to=brian.austin@cirrus.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.