On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: > > Please send a proper commit message and commit description. "modify > top-id's comments" says almost nothing and there is no commit > description. I don't know why you are making this change so I can't > review and apply it. > >> +++ b/qapi/block-core.json >> @@ -2184,7 +2184,7 @@ >> # @mode: the replication mode >> # >> # @top-id: #optional In secondary mode, node name or device ID of the root >> -# node who owns the replication node chain. Ignored in primary mode. >> +# node who owns the replication node chain. Must not be given in primary mode. That, and your line exceeds 80 columns; please wrap it. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org