From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpbUo-0004WC-LV for qemu-devel@nongnu.org; Thu, 29 Sep 2016 09:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpbUk-0003vo-LF for qemu-devel@nongnu.org; Thu, 29 Sep 2016 09:35:30 -0400 References: <1475040639-30203-1-git-send-email-wangww.fnst@cn.fujitsu.com> <20160928103144.GC4196@stefanha-x1.localdomain> From: Eric Blake Message-ID: Date: Thu, 29 Sep 2016 08:35:14 -0500 MIME-Version: 1.0 In-Reply-To: <20160928103144.GC4196@stefanha-x1.localdomain> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K5kTLCOB3ejrL9171p7iA7Bpq9VrM7olX" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Wang WeiWei Cc: Kevin Wolf , Changlong Xie , Fam Zheng , zhanghailiang , qemu block , Markus Armbruster , Jeff Cody , Jiang Yunhong , Dong Eddie , qemu devel , Max Reitz , Gonglei , Stefan Hajnoczi , Paolo Bonzini , "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K5kTLCOB3ejrL9171p7iA7Bpq9VrM7olX From: Eric Blake To: Stefan Hajnoczi , Wang WeiWei Cc: Kevin Wolf , Changlong Xie , Fam Zheng , zhanghailiang , qemu block , Markus Armbruster , Jeff Cody , Jiang Yunhong , Dong Eddie , qemu devel , Max Reitz , Gonglei , Stefan Hajnoczi , Paolo Bonzini , "Dr. David Alan Gilbert" Message-ID: Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments References: <1475040639-30203-1-git-send-email-wangww.fnst@cn.fujitsu.com> <20160928103144.GC4196@stefanha-x1.localdomain> In-Reply-To: <20160928103144.GC4196@stefanha-x1.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote: >=20 > Please send a proper commit message and commit description. "modify > top-id's comments" says almost nothing and there is no commit > description. I don't know why you are making this change so I can't > review and apply it. >=20 >> +++ b/qapi/block-core.json >> @@ -2184,7 +2184,7 @@ >> # @mode: the replication mode >> # >> # @top-id: #optional In secondary mode, node name or device ID of the= root >> -# node who owns the replication node chain. Ignored in prima= ry mode. >> +# node who owns the replication node chain. Must not be give= n in primary mode. That, and your line exceeds 80 columns; please wrap it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --K5kTLCOB3ejrL9171p7iA7Bpq9VrM7olX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX7RiSAAoJEKeha0olJ0NqpuoH/1lZBQ1cpbecoGIkILCP5F33 riyqXVMpjKTiX3fzJ4gVvgx+EDxIriHYpDwMdmsMC1AMLAAd4fv5vMZ6IHGZjRvP xF/5YL6h4C4TubY4hZ3puxQsTJiOmUt2mtBNyuPrm4qTIFGxo6iVymoJ/hBl03O7 xnCMJnJ7WA7LPWiy7he9kxjhaV42p2SAr0O7a43w3EL/PN5g8dF+mSnfs7EoZw9N z83oQXKejUqrcOJMTqueBK9Gi8C/fj4WxVTFf7o4AdcQW/Sk051IxxHcbJrLs9Qi 3DEkREoQr8ri74+8BaSkB1D/1ErjnbRO+htccqc0IHfNg2rgxT7ZOiQ261Z2ZHg= =8fTR -----END PGP SIGNATURE----- --K5kTLCOB3ejrL9171p7iA7Bpq9VrM7olX--