On 2018-09-04 19:09, John Snow wrote: > For purposes of minimum code movement, refactor the mirror_exit > callback to use the post-finalization callbacks in a trivial way. > > Signed-off-by: John Snow > --- > block/mirror.c | 34 +++++++++++++++++++++++++++------- > 1 file changed, 27 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz (Although I believe the ?: hunk from the previous patch should be here. Also note that we have a couple of places that make use of the GNU extension for "?:" as a binary operator (as in "x ?: y" returns x if x != 0). Just in case you find "s->to_replace ?: src" as appealing as I do.)