From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43C2AC41604 for ; Tue, 6 Oct 2020 14:30:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id ABF1C204EF for ; Tue, 6 Oct 2020 14:30:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABF1C204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9F9F1B3C8; Tue, 6 Oct 2020 16:30:31 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 726231B2A9 for ; Tue, 6 Oct 2020 16:30:29 +0200 (CEST) IronPort-SDR: 6KQR5I1mTWVoOQJ7vXeNWu/cvquUzJrra+lC6vrBlEj4qYyzWgynazlntSx2VS0XQMuqaigHe4 dEFY28gbZdmA== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="161121571" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="161121571" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 07:30:21 -0700 IronPort-SDR: pBvuifGKHdMuOM490ZYN6EERUXsTnVrM1eU+r3I3dBWejW0Csg+Vy32YXrSrzBs/OtXFk4XUev QFmIql81qyyw== X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342302673" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.102]) ([10.213.241.102]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 07:30:19 -0700 To: Ophir Munk , dev@dpdk.org, Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Olivier Matz Cc: Ophir Munk References: <20200915131717.18252-2-ophirmu@nvidia.com> <20200918141735.18488-1-ophirmu@nvidia.com> <20200918141735.18488-4-ophirmu@nvidia.com> From: Ferruh Yigit Message-ID: Date: Tue, 6 Oct 2020 15:30:15 +0100 MIME-Version: 1.0 In-Reply-To: <20200918141735.18488-4-ophirmu@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 3/3] app/testpmd: reduce tunnel parsing code duplication X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/18/2020 3:17 PM, Ophir Munk wrote: > From: Ophir Munk > > This is a cleanup commit. It assembles all tunnel outer updates into one > function call to avoid code duplications. > It defines RTE_VXLAN_GPE_DEFAULT_PORT (4790) in accordance with all > other tunnel protocol definitions. > > Signed-off-by: Ophir Munk > --- > app/test-pmd/csumonly.c | 72 +++++++++++++--------------------------------- > lib/librte_net/rte_vxlan.h | 1 + > 2 files changed, 21 insertions(+), 52 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index a9f33c6..7f9bfa6 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -63,7 +63,7 @@ > #define _htons(x) (x) > #endif > > -uint16_t vxlan_gpe_udp_port = 4790; > +uint16_t vxlan_gpe_udp_port = RTE_VXLAN_GPE_DEFAULT_PORT; > uint16_t geneve_udp_port = RTE_GENEVE_DEFAULT_PORT; 'RTE_VXLAN_DEFAULT_PORT' seems defined but '4789' still used as hardcoded in this file, since you are touching these, can you please update that usage too?