All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-pm@lists.linux-foundation.org
Cc: Len Brown <len.brown@intel.com>, x86@kernel.org.#.39.x
Subject: [PATCH 7/8] x86 idle: deprecate "no-hlt" cmdline param
Date: Sun, 29 May 2011 05:41:49 -0400	[thread overview]
Message-ID: <cdaab4a0d330f70c0e5ad8c3f7c65c2e375ea180.1306662035.git.len.brown@intel.com> (raw)
In-Reply-To: <1306662110-29954-1-git-send-email-lenb@kernel.org>
In-Reply-To: <7467571f4480b273007517b26297c07154c73924.1306662035.git.len.brown@intel.com>

From: Len Brown <len.brown@intel.com>

We'd rather that modern machines not check if HLT works on
every entry into idle, for the benefit of machines that had
marginal electricals 15-years ago.  If those machines are still running
the upstream kernel, they can use "idle=poll".  The only difference
will be that they'll now invoke HLT in machine_hlt().

cc: x86@kernel.org # .39.x
Signed-off-by: Len Brown <len.brown@intel.com>
---
 Documentation/feature-removal-schedule.txt |   11 +++++++++++
 arch/x86/kernel/cpu/bugs.c                 |    1 +
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index fc505c1..f1b0eb0 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -24,6 +24,17 @@ Who:	Len Brown <len.brown@intel.com>
 
 ----------------------------
 
+What:	x86_32 "no-hlt" cmdline param
+When:	2012
+Why:	remove a branch from idle path, simplify code used by everybody.
+	This option disabled the use of HLT in idle and machine_halt()
+	for hardware that was flakey 15-years ago.  Today we have
+	"idle=poll" that removed HLT from idle, and so if such a machine
+	is still running the upstream kernel, "idle=poll" is likely sufficient.
+Who:	Len Brown <len.brown@intel.com>
+
+----------------------------
+
 What:	PRISM54
 When:	2.6.34
 
diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
index c39576c..525514c 100644
--- a/arch/x86/kernel/cpu/bugs.c
+++ b/arch/x86/kernel/cpu/bugs.c
@@ -19,6 +19,7 @@
 
 static int __init no_halt(char *s)
 {
+	WARN_ONCE(1, "\"no-hlt\" is deprecated, please use \"idle=poll\"\n");
 	boot_cpu_data.hlt_works_ok = 0;
 	return 1;
 }
-- 
1.7.5.3.367.ga9930.dirty

  parent reply	other threads:[~2011-05-29  9:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-29  9:41 idle patches for 2.6.40.merge Len Brown
2011-05-29  9:41 ` [PATCH 1/8] cpuidle: menu: fixed wrapping timers at 4.294 seconds Len Brown
2011-05-29  9:41   ` [PATCH 2/8] idle governor: Avoid lock acquisition to read pm_qos before entering idle Len Brown
2011-05-29  9:41   ` [PATCH 3/8] x86 idle: clarify AMD erratum 400 workaround Len Brown
2011-05-29  9:41   ` [PATCH 4/8] x86 idle: EXPORT_SYMBOL(default_idle, pm_idle) only when APM demands it Len Brown
2011-05-29  9:41   ` [PATCH 5/8] x86 idle floppy: deprecate disable_hlt() Len Brown
2011-05-30  9:24     ` [stable] " Greg KH
2011-05-29  9:41   ` [PATCH 6/8] x86 idle APM: deprecate CONFIG_APM_CPU_IDLE Len Brown
2011-05-30  9:25     ` [stable] " Greg KH
2011-05-29  9:41   ` Len Brown [this message]
2011-05-29  9:41   ` [PATCH 8/8] x86 idle: deprecate mwait_idle() and "idle=mwait" cmdline param Len Brown
2011-05-30  9:25     ` [stable] " Greg KH
2011-05-30  8:12 ` idle patches for 2.6.40.merge Trinabh Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdaab4a0d330f70c0e5ad8c3f7c65c2e375ea180.1306662035.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=x86@kernel.org.#.39.x \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.