From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6633C433F5 for ; Wed, 5 Oct 2022 16:02:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbiJEQC3 (ORCPT ); Wed, 5 Oct 2022 12:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229942AbiJEQC0 (ORCPT ); Wed, 5 Oct 2022 12:02:26 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E93447B2A1 for ; Wed, 5 Oct 2022 09:02:23 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a29so3103324lfo.1 for ; Wed, 05 Oct 2022 09:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=nV8sn5fckcM1r2PSkDjQFkbKbz4kB84l0Mkh4PCptDc=; b=biOadCqVTkYihS9A1lwozegpbBCWdVtjyxKTngIIPs12kKTrrqxLkyqBFwbV9Zi5Vp mWjjRHPwcQ1Lfv3PSm/ifX0D44ssDjl9q9WkvYgoCXuee+OugiTH4468hnvddQMr82T1 wpsSWEGM8XCqZVMy6x8Fjw1PaJ8uf1gzeILv/SdgXSJVbAFOOmyB3+jy9QQIMv3aMGb4 aYm0Q9vGLXxgaCxbPw9SeSAy/HYYRBnIfb+yGu1EMRPlJa922+Ha7nNXJm8RlD13ptH9 bxnW3Gv/CODYMekSycuKsZYNqkPe1O9nvGFB7YSyiWC5qqAGhzCZKTKI6XHt5WSTay0/ v2dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=nV8sn5fckcM1r2PSkDjQFkbKbz4kB84l0Mkh4PCptDc=; b=a5MOppDFtKjEdIgpEo9KNSscXbEgk5GS4CsrUBKljSFkwqUP8tFVDM1DBTF0nybmP1 fevfTprq1zN4dAbq5hV9/ZACKBhuyJTs1m1AUTwNapQM//5/G/n038VS0dWh/bVDCEKR RK/pGv0gzuSqqoQd20ZdBqSBPM9VJhrcyfPMqydL68lHvhFnWO66kXEptUlNgDv74WmB pHOoQyonuPkYDfQ7h35ZwpZV2ZWddIzzhsppj2K3U5rcipUdI0gSt31X25GyUIkhvRYc W9lrofVmpJS4FTWcABWwIG4ldscET9wkm2gkgnFs4nU9q7zO6u05JJKjontOg8/vy5lk 63uQ== X-Gm-Message-State: ACrzQf3vogTMyumpYP5ITWxuGb7B1VstgymYNI4gmjPGfXb60zldcav3 5OVmXAZg7hmzb2wmyAuWHpDqUQ== X-Google-Smtp-Source: AMsMyM5OSRk7h6UVPriBwCMY+CnAJExrUJsFeU6ZP8I38AN34glsQMeVrQOJadHtOCXG6lkgJT58Ew== X-Received: by 2002:a05:6512:3996:b0:4a2:1c8c:c9a1 with SMTP id j22-20020a056512399600b004a21c8cc9a1mr213297lfu.230.1664985742272; Wed, 05 Oct 2022 09:02:22 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j15-20020a056512108f00b0049f87fb416dsm2396484lfg.12.2022.10.05.09.02.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 09:02:21 -0700 (PDT) Message-ID: Date: Wed, 5 Oct 2022 18:02:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators Content-Language: en-US To: Alexandre Mergnat , Lee Jones , Mark Brown , Matthias Brugger , Rob Herring , Liam Girdwood , Krzysztof Kozlowski , Dmitry Torokhov , Chen Zhong Cc: linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent References: <20221005-mt6357-support-v2-0-f17ba2d2d0a9@baylibre.com> <20221005-mt6357-support-v2-3-f17ba2d2d0a9@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20221005-mt6357-support-v2-3-f17ba2d2d0a9@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2022 16:57, Alexandre Mergnat wrote: > From: Fabien Parent > > Add YAML schema for the MediaTek MT6357 regulators. > > Signed-off-by: Fabien Parent > Signed-off-by: Alexandre Mergnat > --- > .../regulator/mediatek,mt6357-regulator.yaml | 284 +++++++++++++++++++++ > 1 file changed, 284 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml > new file mode 100644 > index 000000000000..83ce2cf287dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml > @@ -0,0 +1,284 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6357-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6357 Regulators > + > +maintainers: > + - Fabien Parent The email might be not correct. > + - Alexandre Mergnat > + > +description: | > + The MT6357 PMIC provides 5 BUCK and 29 LDO. > + Regulators and nodes are named according to the regulator type: > + buck- and ldo-. > + MT6357 regulators node should be sub node of the MT6397 MFD node. > + > +patternProperties: > + "^buck-v(core|modem|pa|proc|s1)$": > + type: object > + $ref: "regulator.yaml#" Drop quotes. > + > + properties: > + regulator-name: > + pattern: "^v(core|modem|pa|proc|s1)$" Why enforcing particular name of the regulator? Both comments apply to all other cases. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8FAAC433FE for ; Wed, 5 Oct 2022 16:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FBAF4JEzcaz4514suG7ywZN29cVK2r1j7aA0ypklquo=; b=zsiCcGkBFMlD1G AJE65HG9IRQuNQO+3ry3Yk+oP4nNd99CREwE2/p1enS62tSWsKaAGrDTbFkqA+A95xHyLqWEacsjb uwl99pNz71l7iQBiAKUfk7goKY96ZitygUK9bFLPqy4Fcn1grh7goLItJTD5OKUiHdWoYT46azpqO XGxHHInDFbJmeDlospDAKHG09E9JimCh6JoXLItWjLhKqKqViajUcxEv+uwoLeG0uk/A65Ryp/0Pj 6xcS5ljGjnLD9NnFkqtn0v6TEPOF/pj7Wn1H11vx980+gPu69HPiPkzZhd4unQZYak1/ZuNWsWgJw mOa3Xoqtbux7alcmgfyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1og6qq-00F0ak-9x; Wed, 05 Oct 2022 16:02:28 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1og6qm-00F0Zv-IT for linux-arm-kernel@lists.infradead.org; Wed, 05 Oct 2022 16:02:26 +0000 Received: by mail-lf1-x12b.google.com with SMTP id f37so7877865lfv.8 for ; Wed, 05 Oct 2022 09:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=nV8sn5fckcM1r2PSkDjQFkbKbz4kB84l0Mkh4PCptDc=; b=biOadCqVTkYihS9A1lwozegpbBCWdVtjyxKTngIIPs12kKTrrqxLkyqBFwbV9Zi5Vp mWjjRHPwcQ1Lfv3PSm/ifX0D44ssDjl9q9WkvYgoCXuee+OugiTH4468hnvddQMr82T1 wpsSWEGM8XCqZVMy6x8Fjw1PaJ8uf1gzeILv/SdgXSJVbAFOOmyB3+jy9QQIMv3aMGb4 aYm0Q9vGLXxgaCxbPw9SeSAy/HYYRBnIfb+yGu1EMRPlJa922+Ha7nNXJm8RlD13ptH9 bxnW3Gv/CODYMekSycuKsZYNqkPe1O9nvGFB7YSyiWC5qqAGhzCZKTKI6XHt5WSTay0/ v2dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=nV8sn5fckcM1r2PSkDjQFkbKbz4kB84l0Mkh4PCptDc=; b=K+jxVHnaq+sn9thcIUyXF9bMmL27OOQ0CBW8UPlpTzW8NlUU9SiM8Tb0Un4mCNL/mF j6Q6pOsIsLuMOOKoPy3/HQ3oIc9m+FSvSkykKn3McpCrqTrhgREclmlnHlBdNfeE3C5l w1FqYhGT+Evnk5Mwz3DbouUFB1aVImxYmkIf6M3dh7v4vuvPSd/ZuLgaEqUjn/5p3iPN 4HJYXwiVs25w15EPeb2InvAyKEHa+txjxx7YvwiibfmqzmsXiLarV+ZMulN1YW62m9GA koIW/dLRoGGxsGA1Hh3nvBIVuelIW3iSBGadkgeZxUHn0nBJvg8mrfACtn6nLU8VDmty l7uw== X-Gm-Message-State: ACrzQf27FYZp8tJI50LrNkL6gfVuKyBGlAqmaItw4d+V7iNHb2j52kN2 jFn6hS6Bp3lwZiXxPWTxcRWArg== X-Google-Smtp-Source: AMsMyM5OSRk7h6UVPriBwCMY+CnAJExrUJsFeU6ZP8I38AN34glsQMeVrQOJadHtOCXG6lkgJT58Ew== X-Received: by 2002:a05:6512:3996:b0:4a2:1c8c:c9a1 with SMTP id j22-20020a056512399600b004a21c8cc9a1mr213297lfu.230.1664985742272; Wed, 05 Oct 2022 09:02:22 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id j15-20020a056512108f00b0049f87fb416dsm2396484lfg.12.2022.10.05.09.02.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 09:02:21 -0700 (PDT) Message-ID: Date: Wed, 5 Oct 2022 18:02:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators Content-Language: en-US To: Alexandre Mergnat , Lee Jones , Mark Brown , Matthias Brugger , Rob Herring , Liam Girdwood , Krzysztof Kozlowski , Dmitry Torokhov , Chen Zhong Cc: linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Fabien Parent References: <20221005-mt6357-support-v2-0-f17ba2d2d0a9@baylibre.com> <20221005-mt6357-support-v2-3-f17ba2d2d0a9@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20221005-mt6357-support-v2-3-f17ba2d2d0a9@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221005_090224_616912_28A00295 X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/10/2022 16:57, Alexandre Mergnat wrote: > From: Fabien Parent > > Add YAML schema for the MediaTek MT6357 regulators. > > Signed-off-by: Fabien Parent > Signed-off-by: Alexandre Mergnat > --- > .../regulator/mediatek,mt6357-regulator.yaml | 284 +++++++++++++++++++++ > 1 file changed, 284 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml > new file mode 100644 > index 000000000000..83ce2cf287dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml > @@ -0,0 +1,284 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6357-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6357 Regulators > + > +maintainers: > + - Fabien Parent The email might be not correct. > + - Alexandre Mergnat > + > +description: | > + The MT6357 PMIC provides 5 BUCK and 29 LDO. > + Regulators and nodes are named according to the regulator type: > + buck- and ldo-. > + MT6357 regulators node should be sub node of the MT6397 MFD node. > + > +patternProperties: > + "^buck-v(core|modem|pa|proc|s1)$": > + type: object > + $ref: "regulator.yaml#" Drop quotes. > + > + properties: > + regulator-name: > + pattern: "^v(core|modem|pa|proc|s1)$" Why enforcing particular name of the regulator? Both comments apply to all other cases. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel