All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"QEMU Block" <qemu-block@nongnu.org>,
	"Stefan Weil" <sw@weilnetz.de>, "Peter Lieven" <pl@kamp.de>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v5 09/11] meson: Fixes qapi tests.
Date: Sat, 5 Sep 2020 10:42:22 +0200	[thread overview]
Message-ID: <cdbe94fa-01a3-52b2-c2bc-6f92d2fda154@redhat.com> (raw)
In-Reply-To: <20200905062333.1087-10-luoyonggang@gmail.com>

On 05/09/2020 08.23, Yonggang Luo wrote:
> The error are:
> +@end table
> +
> +@end deftypefn
> +
> make: *** [Makefile.mtest:63: check-qapi-schema] Error 1
> 
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  tests/qapi-schema/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qapi-schema/meson.build b/tests/qapi-schema/meson.build
> index c87d141417..67ba0a5ebd 100644
> --- a/tests/qapi-schema/meson.build
> +++ b/tests/qapi-schema/meson.build
> @@ -220,6 +220,7 @@ qapi_doc = custom_target('QAPI doc',
>  
>  # "full_path()" needed here to work around
>  # https://github.com/mesonbuild/meson/issues/7585
> -test('QAPI doc', diff, args: ['-u', files('doc-good.texi'), qapi_doc[0].full_path()],
> +test('QAPI doc', diff, args: ['--strip-trailing-cr',
> +                              '-u', files('doc-good.texi'), qapi_doc[0].full_path()],

I just had a look at the POSIX man page of "diff", and it seems like
"'--strip-trailing-cr" is not a portable option :-( Thus this will
likely fail on the BSDs and Solaris-based systems.
I think it's maybe best if you replace it with "-b" instead.

 Thomas



  reply	other threads:[~2020-09-05  8:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05  6:23 [PATCH v5 00/11] Green the msys2 CI make Yonggang Luo
2020-09-05  6:23 ` [PATCH v5 01/11] Revert "configure: add --ninja option" Yonggang Luo
2020-09-05  8:29   ` Thomas Huth
2020-09-05  8:45     ` Mark Cave-Ayland
2020-09-05  8:48     ` Paolo Bonzini
2020-09-05  6:23 ` [PATCH v5 02/11] block: Fixes nfs on msys2/mingw Yonggang Luo
2020-09-05  6:23 ` [PATCH v5 03/11] ci: fixes msys2 build by upgrading capstone to 4.0.2 Yonggang Luo
2020-09-05 11:14   ` Mark Cave-Ayland
2020-09-05 13:22     ` 罗勇刚(Yonggang Luo)
2020-09-05 14:28       ` Peter Maydell
2020-09-05  6:23 ` [PATCH v5 04/11] meson: upgrade meson for execute custom ninjatool under msys2 properly Yonggang Luo
2020-09-05 13:44   ` Paolo Bonzini
2020-09-05 14:21     ` 罗勇刚(Yonggang Luo)
2020-09-05  6:23 ` [PATCH v5 05/11] ci: Enable msys2 ci in cirrus Yonggang Luo
2020-09-05  6:23 ` [PATCH v5 06/11] tests: Trying fixes test-replication.c on msys2 Yonggang Luo
2020-09-05  6:23 ` [PATCH v5 07/11] block: get file-win32.c handle locking option consistence with file-posix.c Yonggang Luo
2020-09-05  6:23 ` [PATCH v5 08/11] osdep: These function are only available on Non-Win32 system Yonggang Luo
2020-09-05  8:33   ` Thomas Huth
2020-09-07 17:42     ` 罗勇刚(Yonggang Luo)
2020-09-05  6:23 ` [PATCH v5 09/11] meson: Fixes qapi tests Yonggang Luo
2020-09-05  8:42   ` Thomas Huth [this message]
2020-09-07  4:20     ` 罗勇刚(Yonggang Luo)
2020-09-05  6:23 ` [PATCH v5 10/11] docker: Add win32/msys2/mingw64 docker Yonggang Luo
2020-09-05  6:23 ` [PATCH v5 11/11] ci: Enable Github actions Yonggang Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdbe94fa-01a3-52b2-c2bc-6f92d2fda154@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.