From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC61EC33CB6 for ; Wed, 22 Jan 2020 08:46:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A47932465A for ; Wed, 22 Jan 2020 08:46:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="KPdK/Jce" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729160AbgAVIqS (ORCPT ); Wed, 22 Jan 2020 03:46:18 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:52636 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbgAVIqR (ORCPT ); Wed, 22 Jan 2020 03:46:17 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200122084613euoutp01ed0301969bddc8b1eabd2e45d9356b34~sKRzcHnb60537905379euoutp01B for ; Wed, 22 Jan 2020 08:46:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200122084613euoutp01ed0301969bddc8b1eabd2e45d9356b34~sKRzcHnb60537905379euoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1579682773; bh=j9OhfnmwsNsDseRLE6HNXD9Fo2QmKiNb/mx4gnijVoM=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=KPdK/JceJ90YE5w76bRSlh5YzOudvECHxOxPOC7uQqPr7kl6WCU7ckRafROJic3K3 wBu0/0Ls/kykcvkAlnOub25j6YRxRxnQ7FbLW5JQjh/CSamX09MNtvyKyAae5p4zrs 7glfKGuhNLbLCX5vd1Cq/O/VbpIAyCIzhDiZb+BY= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200122084612eucas1p213f4303164e7fba9c95bab308e9d65b1~sKRzHqZU_0204702047eucas1p28; Wed, 22 Jan 2020 08:46:12 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 8F.8B.61286.4DB082E5; Wed, 22 Jan 2020 08:46:12 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200122084612eucas1p22383370e24f6fa5f90ed70143bdd07fa~sKRytfySz1174911749eucas1p23; Wed, 22 Jan 2020 08:46:12 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200122084612eusmtrp22f7b4863d7520b69be98949895cf5599~sKRyseQG90741107411eusmtrp2T; Wed, 22 Jan 2020 08:46:12 +0000 (GMT) X-AuditID: cbfec7f2-ef1ff7000001ef66-05-5e280bd4b473 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E1.C2.07950.4DB082E5; Wed, 22 Jan 2020 08:46:12 +0000 (GMT) Received: from [106.120.51.74] (unknown [106.120.51.74]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200122084611eusmtip20b276d63216e5ad8b19be6e80f6427bf~sKRx3d6Vo0540005400eusmtip2k; Wed, 22 Jan 2020 08:46:11 +0000 (GMT) Subject: Re: [PATCH 2/2] drm/bridge: Add tc358768 driver To: Peter Ujfalusi , airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com, narmstrong@baylibre.com Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net From: Andrzej Hajda Message-ID: Date: Wed, 22 Jan 2020 09:46:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <14306079-500d-09ca-df94-4cf72c43f858@ti.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUhTURjGO/fe3V21G6dp7MXKaGBUUCZ9cPuSlIILQfhHRBitVl40clO2 tKxISy1LLJex3NI2RbPCWq2mKRll6RzaMlNTk4xahKmIuVkJVptXyf9+532e857ngcOQMrck lDmiOSZoNaokBR1IVTf9frOqI2i5ck19cQSX73IS3N9qPcmZX7kkXId3hOY6fw6QnHOok+Iu 6sul3Lu6YpqreP+W4Bou7+NMo78kXE79KylnNffS21i+6mYV4ke6c6R8/biF4m/kGiW87e5F mm8uaCf4mvFPEr4/z0Hwz/MLKd7RXUPwY7aw2KC4wC3xQtKRNEEbEXUwMLGnz0ukTJQRJwx9 WzPRg0F0CQUwgNfB8Kc22s8yfBtBTh0jsgdBl9HHgT4eQ3C+/Jt05kL52UlCFCoRfLNVSMXD MAJP0TPK7wrGHHz4bqb8Qgi+hsDoMUr8AokbERRUxPmZxitg8lGP722GYXEUNDt3+scUDofG TM+UfQHeC+6OL1PM4vngNLqn9gfgTdBjLUXiyiWQZb9BiiyHXreZEJPqGThnxyJvB8vHD7TI wfDd8Xi6zSL4Wzvjz4D+29mkPzPgXAT2B7WkKGyGPtfEVE7Sl9laFyGOo6Gpvwb5x4DnQffw fDHCPLhafZ0UxyzknpeJ7qXQ/9o+vVAOFW1eugApTLOKmWaVMc0qY/r/rgVRd5FcSNWpEwRd pEY4vlqnUutSNQmrDyerbcj391r+OH48Qd72Qw0IM0gxl038ukwpk6jSdOnqBgQMqQhhLefC lTI2XpV+UtAmH9CmJgm6BrSQoRRydm3ZwH4ZTlAdE44KQoqgnVEJJiA0E5URg3GdhUoh/sfp ha4ha5Kai/7cNecU3XqGeLIirCrHaI56WVr7i10csrjkuL01e0d70P3dnqzu0Z8tho23tk5q imLSmk3L7t1RVj/ccGBgDMcmXMnocrhKSq60ROyqnPsMPU2W5lnWZ+hji/vi5BcMkvReY6jh ZrBzkt8Tk/lCQekSVZErSa1O9Q/Pdf9fdwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFIsWRmVeSWpSXmKPExsVy+t/xe7pXuDXiDD5tF7foPXeSyeL/tonM FvOPnGO1uPL1PZvF1e8vmS1OvrnKYtE5cQm7xeVdc9gsll6/yGRxqC/aYtbHH6wWrXuPsFus n3+LzYHXY828NYwe72+0snvs/baAxWN2x0xWj02rOtk8Tky4xOSx/dsDVo/73ceZPA70Tmbx OH5jO5PH501yAdxRejZF+aUlqQoZ+cUltkrRhhZGeoaWFnpGJpZ6hsbmsVZGpkr6djYpqTmZ ZalF+nYJehk373xlKvi1iKli2h3bBsYNrxm7GDk5JARMJJY0/mXqYuTiEBJYyijx7u4PqIS4 xO75b5khbGGJP9e62CCKXjNK7Hx3nwkkISxgIXH71XwWkISIwBRGiR2zP4JVMQscZZSY8noa WJWQwBImiWmrpEBsNgFNib+bbwIVcXDwCthJnDjpDRJmEVCVONrwhRXEFhWIkHj7+yaYzSsg KHFy5hMWEJtTwEri5vqFYNcxC6hL/Jl3iRnClpdo3jobyhaXuPVkPtMERqFZSNpnIWmZhaRl FpKWBYwsqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3MQLjfduxn1t2MHa9Cz7EKMDBqMTDm/FU LU6INbGsuDL3EKMEB7OSCO+CJtU4Id6UxMqq1KL8+KLSnNTiQ4ymQM9NZJYSTc4HpqK8knhD U0NzC0tDc2NzYzMLJXHeDoGDMUIC6YklqdmpqQWpRTB9TBycUg2Mu7xOt36Pq7uyZC97E7/G mQPL7fd3dd+b9WzGp+ulWVWudxYGz2LN/dW1J3j605eiX0zaFzgtjdPcm1mnu35Zol36guKI cxdP34xRvmZ5rL3Vu5DpYuKbQI519pu42+c7Xi3i7UhtiXHaxHKD2ay0lOWD2M4TCdMPTX/F +vde65Wr/XlnuDO4lFiKMxINtZiLihMBfsq8NA0DAAA= X-CMS-MailID: 20200122084612eucas1p22383370e24f6fa5f90ed70143bdd07fa X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20191217101520epcas1p4a2bdee0cab0c11670b74fbe9e9397835 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20191217101520epcas1p4a2bdee0cab0c11670b74fbe9e9397835 References: <20191217101506.18910-1-peter.ujfalusi@ti.com> <20191217101506.18910-3-peter.ujfalusi@ti.com> <35d664fe-8091-2744-abf2-69828ebf1148@samsung.com> <14306079-500d-09ca-df94-4cf72c43f858@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.01.2020 16:11, Peter Ujfalusi wrote: > Hi Andrzej, > > On 16/01/2020 16.35, Andrzej Hajda wrote: >> On 17.12.2019 11:15, Peter Ujfalusi wrote: >>> Add basic support for the Toshiba TC358768 RGB to DSI bridge. >>> Not all the features of the TC358768 is implemented by the initial driver: >>> MIPI_DSI_MODE_VIDEO and MIPI_DSI_FMT_RGB888 is only supported and tested. >>> >>> Only write is implemented for mipi_dsi_host_ops.transfer. >>> >>> Signed-off-by: Peter Ujfalusi >>> --- >>> drivers/gpu/drm/bridge/Kconfig | 10 + >>> drivers/gpu/drm/bridge/Makefile | 1 + >>> drivers/gpu/drm/bridge/tc358768.c | 963 ++++++++++++++++++++++++++++++ >>> 3 files changed, 974 insertions(+) >>> create mode 100644 drivers/gpu/drm/bridge/tc358768.c >>> >>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >>> index ccc698c44f58..fd65666702e1 100644 >>> --- a/drivers/gpu/drm/bridge/Kconfig >>> +++ b/drivers/gpu/drm/bridge/Kconfig >>> @@ -122,6 +122,16 @@ config DRM_TOSHIBA_TC358767 >>> ---help--- >>> Toshiba TC358767 eDP bridge chip driver. >>> >>> +config DRM_TOSHIBA_TC358768 >>> + tristate "Toshiba TC358768 MIPI DSI bridge" >>> + depends on OF >>> + select DRM_KMS_HELPER >>> + select REGMAP_I2C >>> + select DRM_PANEL >>> + select DRM_MIPI_DSI >>> + help >>> + Toshiba TC358768AXBG/TC358778XBG DSI bridge chip driver. >>> + >>> config DRM_TI_TFP410 >>> tristate "TI TFP410 DVI/HDMI bridge" >>> depends on OF >>> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile >>> index a6c7dd7727ea..204696e30572 100644 >>> --- a/drivers/gpu/drm/bridge/Makefile >>> +++ b/drivers/gpu/drm/bridge/Makefile >>> @@ -11,6 +11,7 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o >>> obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o >>> obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o >>> obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o >>> +obj-$(CONFIG_DRM_TOSHIBA_TC358768) += tc358768.o >>> obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ >>> obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o >>> obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o >>> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c >>> new file mode 100644 >>> index 000000000000..63571191b1c4 >>> --- /dev/null >>> +++ b/drivers/gpu/drm/bridge/tc358768.c >>> @@ -0,0 +1,963 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright (C) 2018 Texas Instruments Incorporated - http://www.ti.com >> >> Just FYI, we have 2020 already, maybe update needed. > Oh, how time flies ;) > >> >>> + * Author: Peter Ujfalusi >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >> >> alphabetic order > Ok. > >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include