From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbeCISuB (ORCPT ); Fri, 9 Mar 2018 13:50:01 -0500 Received: from oms-m017e.mx.aol.com ([204.29.186.113]:37211 "EHLO oms-m017e.mx.aol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932157AbeCISt7 (ORCPT ); Fri, 9 Mar 2018 13:49:59 -0500 Subject: Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64 To: Arnaldo Carvalho de Melo , Kim Phillips , Jiri Olsa Cc: "Christian Hansen (chansen3)" , "linux-perf-users@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, Mathieu Poirier , "Vuille, Martin (Martin)" References: <20180226142726.cd413c792d0782f77b60a23e@arm.com> <20180226174040.6998bd3c0a79b2f19c491e4d@arm.com> <9B701F46-6AEA-48D8-9103-71D35C83776D@cisco.com> <20180308211030.4ee4a0d6ff6dc5cda1b567d4@arm.com> <20180309150627.GB8347@kernel.org> <20180309120720.9358515dbff3b1d1fdf70cc8@arm.com> <20180309182440.GA25111@kernel.org> From: Martin Vuille Message-ID: Date: Fri, 9 Mar 2018 13:49:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180309182440.GA25111@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US x-aol-global-disposition: S X-SPAM-FLAG: YES X-AOL-REROUTE: YES x-aol-sid: 3039ac1add4e5aa2d7500546 X-AOL-IP: 99.246.128.134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I made two other submissions that may also have been overlooked: https://patchwork.kernel.org/patch/10211401/ -- This one has the S-o-B https://patchwork.kernel.org/patch/10211473/ -- RFC, was looking for comments, has the S-o-B For https://patchwork.kernel.org/patch/10211483/, I'm not sure how to go about doing a reply to all. I had some email problems and was cut-off from the list for a while. MV On 03/09/18 13:24, Arnaldo Carvalho de Melo wrote: > Em Fri, Mar 09, 2018 at 12:07:20PM -0600, Kim Phillips escreveu: >> On Fri, 9 Mar 2018 12:06:27 -0300 >> Arnaldo Carvalho de Melo wrote: >> >> Hi Arnaldo, >> >>> Em Thu, Mar 08, 2018 at 09:10:30PM -0600, Kim Phillips escreveu: >>>> Based on prior work: >>>> >>>> https://lkml.org/lkml/2014/5/6/395 >>> Thanks, looks good, applying. >>> >>> Jean, is everything ok with you on this? >> By now your email to Jean should have bounced with "The email account >> that you tried to reach does not exist." Removing Jean from Cc. >> >> It seems like you're applying patches. There are a couple that have >> slipped through the cracks: Can you please take a look at applying them? >> >> - "perf tools: Fixing uninitialised variable" >> https://patchwork.kernel.org/patch/10179381/ > [acme@jouet perf]$ git tag --contains d2785de15f1bd42d613d56bbac5a007e7293b874 > perf-core-for-mingo-4.17-20180216 > > commit d2785de15f1bd42d613d56bbac5a007e7293b874 > Author: Mathieu Poirier > AuthorDate: Mon Feb 12 13:32:37 2018 -0700 > Commit: Arnaldo Carvalho de Melo > CommitDate: Fri Feb 16 14:55:40 2018 -0300 > > perf auxtrace arm: Fixing uninitialised variable > > When working natively on arm64 the compiler gets pesky and complains > that variable 'i' is uninitialised, something that breaks the > compilation. Here no further checks are needed since variable > 'found_spe' can only be true if variable 'i' has been initialised as > part of the for loop. > > Signed-off-by: Mathieu Poirier > Cc: Alexander Shishkin > Cc: Jin Yao > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: linux-arm-kernel@lists.infradead.org > Link: http://lkml.kernel.org/r/1518467557-18505-4-git-send-email-mathieu.poirier@linaro.org > Signed-off-by: Arnaldo Carvalho de Melo > > diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c > index 2323581b157d..fa639e3e52ac 100644 > --- a/tools/perf/arch/arm/util/auxtrace.c > +++ b/tools/perf/arch/arm/util/auxtrace.c > @@ -68,7 +68,7 @@ struct auxtrace_record > bool found_spe = false; > static struct perf_pmu **arm_spe_pmus = NULL; > static int nr_spes = 0; > - int i; > + int i = 0; > >> - "perf unwind: Report error from dwfl_attach_state" >> https://patchwork.kernel.org/patch/10211483/ >> [Martin, I guess it would help if you replied-all that patch and >> added your signed-off-by.] > Right, the S-o-B is needed > >> - "perf unwind: Unwind with libdw doesn't take symfs into account" >> https://patchwork.kernel.org/patch/10211599/ > This one has the S-o-B, applying, Jiri, holler if you disagree, > > - Arnaldo > >> Thanks, >> >> Kim > -- > To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html