From: Jarkko Sakkinen <jarkko@kernel.org>
To: amirmizi6@gmail.com, Eyal.Cohen@nuvoton.com,
oshrialkoby85@gmail.com, alexander.steffen@infineon.com,
robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de,
jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org,
benoit.houyere@st.com, eajames@linux.ibm.com, joel@jms.id.au
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com,
shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com,
Borys Movchan <borysmn@axis.com>
Subject: Re: [PATCH v18 3/6] tpm: Handle an exception for TPM Firmware Update mode.
Date: Tue, 02 Nov 2021 22:32:23 +0200 [thread overview]
Message-ID: <cde74ac682e031a033b506f4f5505f0587e8c8d2.camel@kernel.org> (raw)
In-Reply-To: <20211102152056.241769-4-amirmizi6@gmail.com>
On Tue, 2021-11-02 at 17:20 +0200, amirmizi6@gmail.com wrote:
> From: Amir Mizinski <amirmizi6@gmail.com>
>
> Add a condition to enable communication with the TPM while the TPM is in
> firmware update mode.
> In such a case if power was cut during the TPM firmware update, the driver
> should ignore the "selftest" command return code (TPM2_RC_UPGRADE or
> TPM2_RC_COMMAND_CODE) and skip the rest of the TPM initialization
> sequence.
>
> Suggested-by: Benoit Houyere <benoit.houyere@st.com>
> Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>
This is a half-baked handling of the FW upgrade mode.
There's another patch in progress that aims to do proper handling
for it:
https://lore.kernel.org/linux-integrity/20210930160241.9691-1-borysmn@axis.com/
I CC'd Borys for further comments/discussion.
/Jarkko
next prev parent reply other threads:[~2021-11-02 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 15:20 [PATCH v18 0/6] Add tpm i2c ptp driver amirmizi6
2021-11-02 15:20 ` [PATCH v18 1/6] tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception amirmizi6
2021-11-02 20:23 ` Jarkko Sakkinen
2021-11-02 15:20 ` [PATCH v18 2/6] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()" amirmizi6
2021-11-02 15:20 ` [PATCH v18 3/6] tpm: Handle an exception for TPM Firmware Update mode amirmizi6
2021-11-02 20:32 ` Jarkko Sakkinen [this message]
2021-11-02 15:20 ` [PATCH v18 4/6] tpm: tpm_tis: Verify TPM_STS register is valid after locality request amirmizi6
2021-11-02 20:35 ` Jarkko Sakkinen
2021-11-02 15:20 ` [PATCH v18 5/6] tpm: tpm_tis: Add tpm_tis_i2c driver amirmizi6
2021-11-02 20:46 ` Jarkko Sakkinen
2021-11-02 15:20 ` [PATCH v18 6/6] tpm: Add YAML schema for TPM TIS I2C options amirmizi6
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde74ac682e031a033b506f4f5505f0587e8c8d2.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=Dan.Morav@nuvoton.com \
--cc=Eyal.Cohen@nuvoton.com \
--cc=alexander.steffen@infineon.com \
--cc=amir.mizinski@nuvoton.com \
--cc=amirmizi6@gmail.com \
--cc=arnd@arndb.de \
--cc=benoit.houyere@st.com \
--cc=borysmn@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gcwilson@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oren.tanami@nuvoton.com \
--cc=oshri.alkoby@nuvoton.com \
--cc=oshrialkoby85@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=shmulik.hager@nuvoton.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.